From: Alexei Sheplyakov <varg@theor.jinr.ru>
Date: Fri, 12 Sep 2008 15:55:36 +0000 (+0400)
Subject: [nitpick] don't use int instead of std::size_t.
X-Git-Tag: release_1-5-0~59^2~16
X-Git-Url: https://www.ginac.de/ginac.git//ginac.git?p=ginac.git;a=commitdiff_plain;h=bd3ecf75ed2a77b9f56fc31f7923fc0f4d1982d4

[nitpick] don't use int instead of std::size_t.

This shuts up (some of) 'comparison between signed and unsigned integer
expressions'  warnings.
---

diff --git a/ginac/indexed.cpp b/ginac/indexed.cpp
index c8b710ae..aa850039 100644
--- a/ginac/indexed.cpp
+++ b/ginac/indexed.cpp
@@ -1409,7 +1409,7 @@ exvector get_all_dummy_indices_safely(const ex & e)
 	else if (is_a<mul>(e) || is_a<ncmul>(e)) {
 		exvector dummies;
 		exvector free_indices;
-		for (int i=0; i<e.nops(); ++i) {
+		for (std::size_t i = 0; i < e.nops(); ++i) {
 			exvector dummies_of_factor = get_all_dummy_indices_safely(e.op(i));
 			dummies.insert(dummies.end(), dummies_of_factor.begin(),
 				dummies_of_factor.end());
@@ -1425,7 +1425,7 @@ exvector get_all_dummy_indices_safely(const ex & e)
 	}
 	else if(is_a<add>(e)) {
 		exvector result;
-		for(int i=0; i<e.nops(); ++i) {
+		for(std::size_t i = 0; i < e.nops(); ++i) {
 			exvector dummies_of_term = get_all_dummy_indices_safely(e.op(i));
 			sort(dummies_of_term.begin(), dummies_of_term.end());
 			exvector new_vec;
diff --git a/ginac/matrix.cpp b/ginac/matrix.cpp
index 821e184d..d108bd4c 100644
--- a/ginac/matrix.cpp
+++ b/ginac/matrix.cpp
@@ -1418,7 +1418,7 @@ int matrix::fraction_free_elimination(const bool det)
 		// Searching the first non-zero element in-place here instead of calling
 		// pivot() allows us to do no more substitutions and back-substitutions
 		// than are actually necessary.
-		int indx = r0;
+		unsigned indx = r0;
 		while ((indx<m) &&
 		       (tmp_n[indx*n+c0].subs(srl, subs_options::no_pattern).expand().is_zero()))
 			++indx;
diff --git a/ginac/ncmul.cpp b/ginac/ncmul.cpp
index 5a7b94f8..a5969f31 100644
--- a/ginac/ncmul.cpp
+++ b/ginac/ncmul.cpp
@@ -124,7 +124,7 @@ bool ncmul::info(unsigned inf) const
 	return inherited::info(inf);
 }
 
-typedef std::vector<int> intvector;
+typedef std::vector<std::size_t> uintvector;
 
 ex ncmul::expand(unsigned options) const
 {
@@ -134,8 +134,8 @@ ex ncmul::expand(unsigned options) const
 	
 	// Now, look for all the factors that are sums and remember their
 	// position and number of terms.
-	intvector positions_of_adds(expanded_seq.size());
-	intvector number_of_add_operands(expanded_seq.size());
+	uintvector positions_of_adds(expanded_seq.size());
+	uintvector number_of_add_operands(expanded_seq.size());
 
 	size_t number_of_adds = 0;
 	size_t number_of_expanded_terms = 1;
@@ -167,7 +167,7 @@ ex ncmul::expand(unsigned options) const
 	exvector distrseq;
 	distrseq.reserve(number_of_expanded_terms);
 
-	intvector k(number_of_adds);
+	uintvector k(number_of_adds);
 
 	/* Rename indices in the static members of the product */
 	exvector expanded_seq_mod;