From: Richard Kreckel <Richard.Kreckel@uni-mainz.de>
Date: Fri, 25 Jan 2002 00:03:44 +0000 (+0000)
Subject: * mul::expand(): Considerable speedup through caching in nested loop.
X-Git-Tag: release_1-0-4~1
X-Git-Url: https://www.ginac.de/ginac.git//ginac.git?p=ginac.git;a=commitdiff_plain;h=bb3808bb989db7e81755f1bfc7c6863d7c960e06

* mul::expand(): Considerable speedup through caching in nested loop.
---

diff --git a/ginac/mul.cpp b/ginac/mul.cpp
index 81d648a5..c7fb32a1 100644
--- a/ginac/mul.cpp
+++ b/ginac/mul.cpp
@@ -693,9 +693,10 @@ ex mul::expand(unsigned options) const
 				exvector distrseq;
 				distrseq.reserve(n1*n2);
 				for (int i1=0; i1<n1; ++i1) {
-					for (int i2=0; i2<n2; ++i2) {
-						distrseq.push_back(add1.op(i1) * add2.op(i2));
-					}
+					// cache the first operand (for efficiency):
+					const ex op1 = add1.op(i1);
+					for (int i2=0; i2<n2; ++i2)
+						distrseq.push_back(op1 * add2.op(i2));
 				}
 				last_expanded = (new add(distrseq))->
 				                 setflag(status_flags::dynallocated | (options == 0 ? status_flags::expanded : 0));