From: Richard Kreckel <kreckel@ginac.de>
Date: Sat, 22 Oct 2011 19:37:13 +0000 (+0200)
Subject: Fix warning "control reaches end of non-void function".
X-Git-Tag: release_1-6-2~2
X-Git-Url: https://www.ginac.de/ginac.git//ginac.git?p=ginac.git;a=commitdiff_plain;h=265e5f9537e128887655119fc4cc8d3a46f3dcff;hp=9a4f392521083d28e1c238e7898ab1d2ac5b73cd

Fix warning "control reaches end of non-void function".

Being careful about this is required to pass the openSUSE build process.
---

diff --git a/ginac/polynomial/mgcd.cpp b/ginac/polynomial/mgcd.cpp
index cad99be2..9eb535af 100644
--- a/ginac/polynomial/mgcd.cpp
+++ b/ginac/polynomial/mgcd.cpp
@@ -40,6 +40,7 @@ static cln::cl_I extract_integer_content(ex& Apr, const ex& A)
 {
 	static const cln::cl_I n1(1);
 	const numeric icont_ = A.integer_content();
+	GINAC_ASSERT(cln::instanceof(icont_.to_cl_N(), cln::cl_RA_ring));
 	if (cln::instanceof(icont_.to_cl_N(), cln::cl_I_ring)) {
 		const cln::cl_I icont = cln::the<cln::cl_I>(icont_.to_cl_N());
 		if (icont != 1) {
@@ -49,14 +50,12 @@ static cln::cl_I extract_integer_content(ex& Apr, const ex& A)
 			Apr = A;
 			return n1;
 		}
-	}
-	if (cln::instanceof(icont_.to_cl_N(), cln::cl_RA_ring)) {
+	} else {
 		Apr = (A/icont_).expand();
 		// A is a polynomail over rationals, so GCD is defined
 		// up to arbitrary rational number.
 		return n1;
 	}
-	GINAC_ASSERT(NULL == "expected polynomial over integers or rationals");
 }
 
 ex chinrem_gcd(const ex& A_, const ex& B_, const exvector& vars)