primpart_content: correctly handle monomials.
authorAlexei Sheplyakov <alexei.sheplyakov@gmail.com>
Mon, 17 May 2010 22:20:08 +0000 (00:20 +0200)
committerRichard Kreckel <kreckel@ginac.de>
Mon, 17 May 2010 22:20:08 +0000 (00:20 +0200)
Impact: fixes (rare) incorrect gcd calculation and (potential) segfault.

Thanks to Aless Lasaruk for a bug report.

ginac/polynomial/collect_vargs.cpp
ginac/polynomial/primpart_content.cpp

index 89c3b8b..2593268 100644 (file)
@@ -148,8 +148,14 @@ ex_collect_to_ex(const ex_collect_t& ec, const GiNaC::exvector& vars)
                exvector tv;
                tv.reserve(vars.size() + 1);
                for (std::size_t j = 0; j < vars.size(); ++j) {
-                       if (ec[i].first[j] != 0)
-                               tv.push_back(power(vars[j], ec[i].first[j]));
+                       const exp_vector_t& exp_vector(ec[i].first);
+
+                       bug_on(exp_vector.size() != vars.size(),
+                               "expected " << vars.size() << " variables, "
+                               "expression has " << exp_vector.size() << " instead");
+
+                       if (exp_vector[j] != 0)
+                               tv.push_back(power(vars[j], exp_vector[j]));
                }
                tv.push_back(ec[i].second);
                ex tmp = (new mul(tv))->setflag(status_flags::dynallocated);
index f703ee7..694f29d 100644 (file)
@@ -62,7 +62,7 @@ void primpart_content(ex& pp, ex& c, ex e, const exvector& vars,
                // p_1(x_n) p_2(x_0, \ldots, x_{n-1})
                c = ec.rbegin()->second;
                ec.rbegin()->second = ex1;
-               pp = ex_collect_to_ex(ec, vars).expand().smod(numeric(p));
+               pp = ex_collect_to_ex(ec, rest_vars).expand().smod(numeric(p));
                return;
        }