Fixed bug in binomial(). binomial(n,0) erroneously returned 0.

diff --git a/check/exam_inifcns.cpp b/check/exam_inifcns.cpp
index b86b4703cf7306dcc623badebbeebb94cfd05aec..7d8cb978535aca9ce4cc7946e02077fdefbf37d9 100644 (file)
--- a/check/exam_inifcns.cpp
+++ b/check/exam_inifcns.cpp
@@ -215,6 +215,20 @@ static unsigned inifcns_consist_zeta()
        return result;
 }
 
        return result;
 }
 

+static unsigned inifcns_consist_various()
+{
+       unsigned result = 0;
+       symbol n;
+       ex e;
+       
+       if ( binomial(n, 0) != 1 ) {
+               clog << "ERROR: binomial(n,0) != 1" << endl;            
+               ++result;
+       }
+       
+       return result;
+}
+

 unsigned exam_inifcns()
 {
        unsigned result = 0;
 unsigned exam_inifcns()
 {
        unsigned result = 0;


@@ -225,6 +239,7 @@ unsigned exam_inifcns()
        result += inifcns_consist_gamma();  cout << '.' << flush;
        result += inifcns_consist_psi();  cout << '.' << flush;
        result += inifcns_consist_zeta();  cout << '.' << flush;
        result += inifcns_consist_gamma();  cout << '.' << flush;
        result += inifcns_consist_psi();  cout << '.' << flush;
        result += inifcns_consist_zeta();  cout << '.' << flush;

+       result += inifcns_consist_various();  cout << '.' << flush;

        
        return result;
 }
        
        return result;
 }

diff --git a/ginac/inifcns.cpp b/ginac/inifcns.cpp
index 17a080c9c35973a852255a1c1dc352f0e4f88159..fa998b234bc1c6ff8968b993b42808188bf4d4a7 100644 (file)
--- a/ginac/inifcns.cpp
+++ b/ginac/inifcns.cpp
@@ -759,7 +759,7 @@ static ex binomial_sym(const ex & x, const numeric & y)
        if (y.is_integer()) {
                if (y.is_nonneg_integer()) {
                        const unsigned N = y.to_int();
        if (y.is_integer()) {
                if (y.is_nonneg_integer()) {
                        const unsigned N = y.to_int();

-                       if (N == 0) return _ex0;
+                       if (N == 0) return _ex1;

                        if (N == 1) return x;
                        ex t = x.expand();
                        for (unsigned i = 2; i <= N; ++i)
                        if (N == 1) return x;
                        ex t = x.expand();
                        for (unsigned i = 2; i <= N; ++i)