]> www.ginac.de Git - ginac.git/commitdiff
Fix warning "control reaches end of non-void function".
authorRichard Kreckel <kreckel@ginac.de>
Sat, 22 Oct 2011 19:37:13 +0000 (21:37 +0200)
committerRichard Kreckel <kreckel@ginac.de>
Sat, 22 Oct 2011 19:37:13 +0000 (21:37 +0200)
Being careful about this is required to pass the openSUSE build process.

ginac/polynomial/mgcd.cpp

index cad99be2d7c6e135c58584b4d7cbd2e10699bf70..9eb535aff1dfad2e53e4e89e59a3bbaec5e8a930 100644 (file)
@@ -40,6 +40,7 @@ static cln::cl_I extract_integer_content(ex& Apr, const ex& A)
 {
        static const cln::cl_I n1(1);
        const numeric icont_ = A.integer_content();
+       GINAC_ASSERT(cln::instanceof(icont_.to_cl_N(), cln::cl_RA_ring));
        if (cln::instanceof(icont_.to_cl_N(), cln::cl_I_ring)) {
                const cln::cl_I icont = cln::the<cln::cl_I>(icont_.to_cl_N());
                if (icont != 1) {
@@ -49,14 +50,12 @@ static cln::cl_I extract_integer_content(ex& Apr, const ex& A)
                        Apr = A;
                        return n1;
                }
-       }
-       if (cln::instanceof(icont_.to_cl_N(), cln::cl_RA_ring)) {
+       } else {
                Apr = (A/icont_).expand();
                // A is a polynomail over rationals, so GCD is defined
                // up to arbitrary rational number.
                return n1;
        }
-       GINAC_ASSERT(NULL == "expected polynomial over integers or rationals");
 }
 
 ex chinrem_gcd(const ex& A_, const ex& B_, const exvector& vars)