X-Git-Url: https://www.ginac.de/ginac.git//ginac.git?p=ginac.git;a=blobdiff_plain;f=ginac%2Fnumeric.cpp;h=f8e4d93b406222046357042188ad12acb42ef9df;hp=986070b71ad26bd57c8e9c21683593332c84c869;hb=d54e497297f4687c385ff8fbc91296365887c7c0;hpb=e7cc6a764ff67b5885d6633385fac23ccc1dc9a7 diff --git a/ginac/numeric.cpp b/ginac/numeric.cpp index 986070b7..f8e4d93b 100644 --- a/ginac/numeric.cpp +++ b/ginac/numeric.cpp @@ -7,7 +7,7 @@ * of special functions or implement the interface to the bignum package. */ /* - * GiNaC Copyright (C) 1999-2002 Johannes Gutenberg University Mainz, Germany + * GiNaC Copyright (C) 1999-2003 Johannes Gutenberg University Mainz, Germany * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by @@ -30,10 +30,11 @@ #include #include #include +#include #include "numeric.h" #include "ex.h" -#include "print.h" +#include "operators.h" #include "archive.h" #include "tostring.h" #include "utils.h" @@ -59,10 +60,16 @@ namespace GiNaC { -GINAC_IMPLEMENT_REGISTERED_CLASS(numeric, basic) +GINAC_IMPLEMENT_REGISTERED_CLASS_OPT(numeric, basic, + print_func(&numeric::do_print). + print_func(&numeric::do_print_latex). + print_func(&numeric::do_print_csrc). + print_func(&numeric::do_print_csrc_cl_N). + print_func(&numeric::do_print_tree). + print_func(&numeric::do_print_python_repr)) ////////// -// default ctor, dtor, copy ctor, assignment operator and helpers +// default constructor ////////// /** default ctor. Numerically it initializes to an integer zero. */ @@ -72,16 +79,8 @@ numeric::numeric() : basic(TINFO_numeric) setflag(status_flags::evaluated | status_flags::expanded); } -void numeric::copy(const numeric &other) -{ - inherited::copy(other); - value = other.value; -} - -DEFAULT_DESTROY(numeric) - ////////// -// other ctors +// other constructors ////////// // public @@ -93,10 +92,10 @@ numeric::numeric(int i) : basic(TINFO_numeric) // emphasizes efficiency. However, if the integer is small enough // we save space and dereferences by using an immediate type. // (C.f. ) - if (i < (1U<= -(1L << (cl_value_len-1))) value = cln::cl_I(i); else - value = cln::cl_I((long) i); + value = cln::cl_I(static_cast(i)); setflag(status_flags::evaluated | status_flags::expanded); } @@ -108,10 +107,10 @@ numeric::numeric(unsigned int i) : basic(TINFO_numeric) // emphasizes efficiency. However, if the integer is small enough // we save space and dereferences by using an immediate type. // (C.f. ) - if (i < (1U<(i)); setflag(status_flags::evaluated | status_flags::expanded); } @@ -129,7 +128,8 @@ numeric::numeric(unsigned long i) : basic(TINFO_numeric) setflag(status_flags::evaluated | status_flags::expanded); } -/** Ctor for rational numerics a/b. + +/** Constructor for rational numerics a/b. * * @exception overflow_error (division by zero) */ numeric::numeric(long numer, long denom) : basic(TINFO_numeric) @@ -242,7 +242,7 @@ numeric::numeric(const cln::cl_N &z) : basic(TINFO_numeric) // archiving ////////// -numeric::numeric(const archive_node &n, const lst &sym_lst) : inherited(n, sym_lst) +numeric::numeric(const archive_node &n, lst &sym_lst) : inherited(n, sym_lst) { cln::cl_N ctorval = 0; @@ -313,7 +313,7 @@ DEFAULT_UNARCHIVE(numeric) * want to visibly distinguish from cl_LF. * * @see numeric::print() */ -static void print_real_number(const print_context & c, const cln::cl_R &x) +static void print_real_number(const print_context & c, const cln::cl_R & x) { cln::cl_print_flags ourflags; if (cln::instanceof(x, cln::cl_RA_ring)) { @@ -322,8 +322,10 @@ static void print_real_number(const print_context & c, const cln::cl_R &x) !is_a(c)) { cln::print_real(c.s, ourflags, x); } else { // rational output in LaTeX context + if (x < 0) + c.s << "-"; c.s << "\\frac{"; - cln::print_real(c.s, ourflags, cln::numerator(cln::the(x))); + cln::print_real(c.s, ourflags, cln::abs(cln::numerator(cln::the(x)))); c.s << "}{"; cln::print_real(c.s, ourflags, cln::denominator(cln::the(x))); c.s << '}'; @@ -337,122 +339,224 @@ static void print_real_number(const print_context & c, const cln::cl_R &x) } } -/** This method adds to the output so it blends more consistently together - * with the other routines and produces something compatible to ginsh input. - * - * @see print_real_number() */ -void numeric::print(const print_context & c, unsigned level) const -{ - if (is_a(c)) { - - c.s << std::string(level, ' ') << cln::the(value) - << " (" << class_name() << ")" - << std::hex << ", hash=0x" << hashvalue << ", flags=0x" << flags << std::dec - << std::endl; - - } else if (is_a(c)) { - - std::ios::fmtflags oldflags = c.s.flags(); - c.s.setf(std::ios::scientific); - if (this->is_rational() && !this->is_integer()) { - if (compare(_num0) > 0) { - c.s << "("; - if (is_a(c)) - c.s << "cln::cl_F(\"" << numer().evalf() << "\")"; - else - c.s << numer().to_double(); - } else { - c.s << "-("; - if (is_a(c)) - c.s << "cln::cl_F(\"" << -numer().evalf() << "\")"; - else - c.s << -numer().to_double(); - } - c.s << "/"; - if (is_a(c)) - c.s << "cln::cl_F(\"" << denom().evalf() << "\")"; - else - c.s << denom().to_double(); - c.s << ")"; +/** Helper function to print integer number in C++ source format. + * + * @see numeric::print() */ +static void print_integer_csrc(const print_context & c, const cln::cl_I & x) +{ + // Print small numbers in compact float format, but larger numbers in + // scientific format + const int max_cln_int = 536870911; // 2^29-1 + if (x >= cln::cl_I(-max_cln_int) && x <= cln::cl_I(max_cln_int)) + c.s << cln::cl_I_to_int(x) << ".0"; + else + c.s << cln::double_approx(x); +} + +/** Helper function to print real number in C++ source format. + * + * @see numeric::print() */ +static void print_real_csrc(const print_context & c, const cln::cl_R & x) +{ + if (cln::instanceof(x, cln::cl_I_ring)) { + + // Integer number + print_integer_csrc(c, cln::the(x)); + + } else if (cln::instanceof(x, cln::cl_RA_ring)) { + + // Rational number + const cln::cl_I numer = cln::numerator(cln::the(x)); + const cln::cl_I denom = cln::denominator(cln::the(x)); + if (cln::plusp(x) > 0) { + c.s << "("; + print_integer_csrc(c, numer); } else { - if (is_a(c)) - c.s << "cln::cl_F(\"" << evalf() << "\")"; - else - c.s << to_double(); + c.s << "-("; + print_integer_csrc(c, -numer); } - c.s.flags(oldflags); + c.s << "/"; + print_integer_csrc(c, denom); + c.s << ")"; } else { - const std::string par_open = is_a(c) ? "{(" : "("; - const std::string par_close = is_a(c) ? ")}" : ")"; - const std::string imag_sym = is_a(c) ? "i" : "I"; - const std::string mul_sym = is_a(c) ? " " : "*"; - const cln::cl_R r = cln::realpart(cln::the(value)); - const cln::cl_R i = cln::imagpart(cln::the(value)); - if (is_a(c)) - c.s << class_name() << "('"; - if (cln::zerop(i)) { - // case 1, real: x or -x - if ((precedence() <= level) && (!this->is_nonneg_integer())) { - c.s << par_open; - print_real_number(c, r); - c.s << par_close; - } else { - print_real_number(c, r); + + // Anything else + c.s << cln::double_approx(x); + } +} + +/** Helper function to print real number in C++ source format using cl_N types. + * + * @see numeric::print() */ +static void print_real_cl_N(const print_context & c, const cln::cl_R & x) +{ + if (cln::instanceof(x, cln::cl_I_ring)) { + + // Integer number + c.s << "cln::cl_I(\""; + print_real_number(c, x); + c.s << "\")"; + + } else if (cln::instanceof(x, cln::cl_RA_ring)) { + + // Rational number + cln::cl_print_flags ourflags; + c.s << "cln::cl_RA(\""; + cln::print_rational(c.s, ourflags, cln::the(x)); + c.s << "\")"; + + } else { + + // Anything else + c.s << "cln::cl_F(\""; + print_real_number(c, cln::cl_float(1.0, cln::default_float_format) * x); + c.s << "_" << Digits << "\")"; + } +} + +void numeric::print_numeric(const print_context & c, const char *par_open, const char *par_close, const char *imag_sym, const char *mul_sym, unsigned level) const +{ + const cln::cl_R r = cln::realpart(cln::the(value)); + const cln::cl_R i = cln::imagpart(cln::the(value)); + + if (cln::zerop(i)) { + + // case 1, real: x or -x + if ((precedence() <= level) && (!this->is_nonneg_integer())) { + c.s << par_open; + print_real_number(c, r); + c.s << par_close; + } else { + print_real_number(c, r); + } + + } else { + if (cln::zerop(r)) { + + // case 2, imaginary: y*I or -y*I + if (i == 1) + c.s << imag_sym; + else { + if (precedence()<=level) + c.s << par_open; + if (i == -1) + c.s << "-" << imag_sym; + else { + print_real_number(c, i); + c.s << mul_sym << imag_sym; + } + if (precedence()<=level) + c.s << par_close; } + } else { - if (cln::zerop(r)) { - // case 2, imaginary: y*I or -y*I - if ((precedence() <= level) && (i < 0)) { - if (i == -1) { - c.s << par_open+imag_sym+par_close; - } else { - c.s << par_open; - print_real_number(c, i); - c.s << mul_sym+imag_sym+par_close; - } + + // case 3, complex: x+y*I or x-y*I or -x+y*I or -x-y*I + if (precedence() <= level) + c.s << par_open; + print_real_number(c, r); + if (i < 0) { + if (i == -1) { + c.s << "-" << imag_sym; } else { - if (i == 1) { - c.s << imag_sym; - } else { - if (i == -1) { - c.s << "-" << imag_sym; - } else { - print_real_number(c, i); - c.s << mul_sym+imag_sym; - } - } + print_real_number(c, i); + c.s << mul_sym << imag_sym; } } else { - // case 3, complex: x+y*I or x-y*I or -x+y*I or -x-y*I - if (precedence() <= level) - c.s << par_open; - print_real_number(c, r); - if (i < 0) { - if (i == -1) { - c.s << "-"+imag_sym; - } else { - print_real_number(c, i); - c.s << mul_sym+imag_sym; - } + if (i == 1) { + c.s << "+" << imag_sym; } else { - if (i == 1) { - c.s << "+"+imag_sym; - } else { - c.s << "+"; - print_real_number(c, i); - c.s << mul_sym+imag_sym; - } + c.s << "+"; + print_real_number(c, i); + c.s << mul_sym << imag_sym; } - if (precedence() <= level) - c.s << par_close; } + if (precedence() <= level) + c.s << par_close; } - if (is_a(c)) - c.s << "')"; } } +void numeric::do_print(const print_context & c, unsigned level) const +{ + print_numeric(c, "(", ")", "I", "*", level); +} + +void numeric::do_print_latex(const print_latex & c, unsigned level) const +{ + print_numeric(c, "{(", ")}", "i", " ", level); +} + +void numeric::do_print_csrc(const print_csrc & c, unsigned level) const +{ + std::ios::fmtflags oldflags = c.s.flags(); + c.s.setf(std::ios::scientific); + int oldprec = c.s.precision(); + + // Set precision + if (is_a(c)) + c.s.precision(std::numeric_limits::digits10 + 1); + else + c.s.precision(std::numeric_limits::digits10 + 1); + + if (this->is_real()) { + + // Real number + print_real_csrc(c, cln::the(value)); + + } else { + + // Complex number + c.s << "std::complex<"; + if (is_a(c)) + c.s << "double>("; + else + c.s << "float>("; + + print_real_csrc(c, cln::realpart(cln::the(value))); + c.s << ","; + print_real_csrc(c, cln::imagpart(cln::the(value))); + c.s << ")"; + } + + c.s.flags(oldflags); + c.s.precision(oldprec); +} + +void numeric::do_print_csrc_cl_N(const print_csrc_cl_N & c, unsigned level) const +{ + if (this->is_real()) { + + // Real number + print_real_cl_N(c, cln::the(value)); + + } else { + + // Complex number + c.s << "cln::complex("; + print_real_cl_N(c, cln::realpart(cln::the(value))); + c.s << ","; + print_real_cl_N(c, cln::imagpart(cln::the(value))); + c.s << ")"; + } +} + +void numeric::do_print_tree(const print_tree & c, unsigned level) const +{ + c.s << std::string(level, ' ') << cln::the(value) + << " (" << class_name() << ")" << " @" << this + << std::hex << ", hash=0x" << hashvalue << ", flags=0x" << flags << std::dec + << std::endl; +} + +void numeric::do_print_python_repr(const print_python_repr & c, unsigned level) const +{ + c.s << class_name() << "('"; + print_numeric(c, "(", ")", "I", "*", level); + c.s << "')"; +} + bool numeric::info(unsigned inf) const { switch (inf) { @@ -498,6 +602,21 @@ bool numeric::info(unsigned inf) const return false; } +int numeric::degree(const ex & s) const +{ + return 0; +} + +int numeric::ldegree(const ex & s) const +{ + return 0; +} + +ex numeric::coeff(const ex & s, int n) const +{ + return n==0 ? *this : _ex0; +} + /** Disassemble real part and imaginary part to scan for the occurrence of a * single number. Also handles the imaginary unit. It ignores the sign on * both this and the argument, which may lead to what might appear as funny @@ -506,7 +625,7 @@ bool numeric::info(unsigned inf) const * sign as a multiplicative factor. */ bool numeric::has(const ex &other) const { - if (!is_ex_exactly_of_type(other, numeric)) + if (!is_exactly_a(other)) return false; const numeric &o = ex_to(other); if (this->is_equal(o) || this->is_equal(-o)) @@ -568,13 +687,15 @@ bool numeric::is_equal_same_type(const basic &other) const } -unsigned numeric::calchash(void) const +unsigned numeric::calchash() const { - // Use CLN's hashcode. Warning: It depends only on the number's value, not - // its type or precision (i.e. a true equivalence relation on numbers). As - // a consequence, 3 and 3.0 share the same hashvalue. + // Base computation of hashvalue on CLN's hashcode. Note: That depends + // only on the number's value, not its type or precision (i.e. a true + // equivalence relation on numbers). As a consequence, 3 and 3.0 share + // the same hashvalue. That shouldn't really matter, though. setflag(status_flags::hash_calculated); - return (hashvalue = cln::equal_hashcode(cln::the(value)) | 0x80000000U); + hashvalue = golden_ratio_hash(cln::equal_hashcode(cln::the(value))); + return hashvalue; } @@ -594,12 +715,6 @@ unsigned numeric::calchash(void) const * a numeric object. */ const numeric numeric::add(const numeric &other) const { - // Efficiency shortcut: trap the neutral element by pointer. - if (this==_num0_p) - return other; - else if (&other==_num0_p) - return *this; - return numeric(cln::the(value)+cln::the(other.value)); } @@ -616,12 +731,6 @@ const numeric numeric::sub(const numeric &other) const * result as a numeric object. */ const numeric numeric::mul(const numeric &other) const { - // Efficiency shortcut: trap the neutral element by pointer. - if (this==_num1_p) - return other; - else if (&other==_num1_p) - return *this; - return numeric(cln::the(value)*cln::the(other.value)); } @@ -642,8 +751,9 @@ const numeric numeric::div(const numeric &other) const * returns result as a numeric object. */ const numeric numeric::power(const numeric &other) const { - // Efficiency shortcut: trap the neutral exponent by pointer. - if (&other==_num1_p) + // Shortcut for efficiency and numeric stability (as in 1.0 exponent): + // trap the neutral exponent. + if (&other==_num1_p || cln::equal(cln::the(other.value),cln::the(_num1.value))) return *this; if (cln::zerop(cln::the(value))) { @@ -660,52 +770,87 @@ const numeric numeric::power(const numeric &other) const } + +/** Numerical addition method. Adds argument to *this and returns result as + * a numeric object on the heap. Use internally only for direct wrapping into + * an ex object, where the result would end up on the heap anyways. */ const numeric &numeric::add_dyn(const numeric &other) const { - // Efficiency shortcut: trap the neutral element by pointer. + // Efficiency shortcut: trap the neutral element by pointer. This hack + // is supposed to keep the number of distinct numeric objects low. if (this==_num0_p) return other; else if (&other==_num0_p) return *this; return static_cast((new numeric(cln::the(value)+cln::the(other.value)))-> - setflag(status_flags::dynallocated)); + setflag(status_flags::dynallocated)); } +/** Numerical subtraction method. Subtracts argument from *this and returns + * result as a numeric object on the heap. Use internally only for direct + * wrapping into an ex object, where the result would end up on the heap + * anyways. */ const numeric &numeric::sub_dyn(const numeric &other) const { + // Efficiency shortcut: trap the neutral exponent (first by pointer). This + // hack is supposed to keep the number of distinct numeric objects low. + if (&other==_num0_p || cln::zerop(cln::the(other.value))) + return *this; + return static_cast((new numeric(cln::the(value)-cln::the(other.value)))-> - setflag(status_flags::dynallocated)); + setflag(status_flags::dynallocated)); } +/** Numerical multiplication method. Multiplies *this and argument and returns + * result as a numeric object on the heap. Use internally only for direct + * wrapping into an ex object, where the result would end up on the heap + * anyways. */ const numeric &numeric::mul_dyn(const numeric &other) const { - // Efficiency shortcut: trap the neutral element by pointer. + // Efficiency shortcut: trap the neutral element by pointer. This hack + // is supposed to keep the number of distinct numeric objects low. if (this==_num1_p) return other; else if (&other==_num1_p) return *this; return static_cast((new numeric(cln::the(value)*cln::the(other.value)))-> - setflag(status_flags::dynallocated)); + setflag(status_flags::dynallocated)); } +/** Numerical division method. Divides *this by argument and returns result as + * a numeric object on the heap. Use internally only for direct wrapping + * into an ex object, where the result would end up on the heap + * anyways. + * + * @exception overflow_error (division by zero) */ const numeric &numeric::div_dyn(const numeric &other) const { + // Efficiency shortcut: trap the neutral element by pointer. This hack + // is supposed to keep the number of distinct numeric objects low. + if (&other==_num1_p) + return *this; if (cln::zerop(cln::the(other.value))) throw std::overflow_error("division by zero"); return static_cast((new numeric(cln::the(value)/cln::the(other.value)))-> - setflag(status_flags::dynallocated)); + setflag(status_flags::dynallocated)); } +/** Numerical exponentiation. Raises *this to the power given as argument and + * returns result as a numeric object on the heap. Use internally only for + * direct wrapping into an ex object, where the result would end up on the + * heap anyways. */ const numeric &numeric::power_dyn(const numeric &other) const { - // Efficiency shortcut: trap the neutral exponent by pointer. - if (&other==_num1_p) + // Efficiency shortcut: trap the neutral exponent (first try by pointer, then + // try harder, since calls to cln::expt() below may return amazing results for + // floating point exponent 1.0). + if (&other==_num1_p || cln::equal(cln::the(other.value),cln::the(_num1.value))) return *this; if (cln::zerop(cln::the(value))) { @@ -760,7 +905,7 @@ const numeric &numeric::operator=(const char * s) /** Inverse of a number. */ -const numeric numeric::inverse(void) const +const numeric numeric::inverse() const { if (cln::zerop(cln::the(value))) throw std::overflow_error("numeric::inverse(): division by zero"); @@ -773,7 +918,7 @@ const numeric numeric::inverse(void) const * csgn(x)==-1 for Re(x)<0 or Re(x)=0 and Im(x)<0. * * @see numeric::compare(const numeric &other) */ -int numeric::csgn(void) const +int numeric::csgn() const { if (cln::zerop(cln::the(value))) return 0; @@ -798,7 +943,7 @@ int numeric::csgn(void) const * to be compatible with our method csgn. * * @return csgn(*this-other) - * @see numeric::csgn(void) */ + * @see numeric::csgn() */ int numeric::compare(const numeric &other) const { // Comparing two real numbers? @@ -824,84 +969,86 @@ bool numeric::is_equal(const numeric &other) const /** True if object is zero. */ -bool numeric::is_zero(void) const +bool numeric::is_zero() const { return cln::zerop(cln::the(value)); } /** True if object is not complex and greater than zero. */ -bool numeric::is_positive(void) const +bool numeric::is_positive() const { - if (this->is_real()) + if (cln::instanceof(value, cln::cl_R_ring)) // real? return cln::plusp(cln::the(value)); return false; } /** True if object is not complex and less than zero. */ -bool numeric::is_negative(void) const +bool numeric::is_negative() const { - if (this->is_real()) + if (cln::instanceof(value, cln::cl_R_ring)) // real? return cln::minusp(cln::the(value)); return false; } /** True if object is a non-complex integer. */ -bool numeric::is_integer(void) const +bool numeric::is_integer() const { return cln::instanceof(value, cln::cl_I_ring); } /** True if object is an exact integer greater than zero. */ -bool numeric::is_pos_integer(void) const +bool numeric::is_pos_integer() const { - return (this->is_integer() && cln::plusp(cln::the(value))); + return (cln::instanceof(value, cln::cl_I_ring) && cln::plusp(cln::the(value))); } /** True if object is an exact integer greater or equal zero. */ -bool numeric::is_nonneg_integer(void) const +bool numeric::is_nonneg_integer() const { - return (this->is_integer() && !cln::minusp(cln::the(value))); + return (cln::instanceof(value, cln::cl_I_ring) && !cln::minusp(cln::the(value))); } /** True if object is an exact even integer. */ -bool numeric::is_even(void) const +bool numeric::is_even() const { - return (this->is_integer() && cln::evenp(cln::the(value))); + return (cln::instanceof(value, cln::cl_I_ring) && cln::evenp(cln::the(value))); } /** True if object is an exact odd integer. */ -bool numeric::is_odd(void) const +bool numeric::is_odd() const { - return (this->is_integer() && cln::oddp(cln::the(value))); + return (cln::instanceof(value, cln::cl_I_ring) && cln::oddp(cln::the(value))); } /** Probabilistic primality test. * * @return true if object is exact integer and prime. */ -bool numeric::is_prime(void) const +bool numeric::is_prime() const { - return (this->is_integer() && cln::isprobprime(cln::the(value))); + return (cln::instanceof(value, cln::cl_I_ring) // integer? + && cln::plusp(cln::the(value)) // positive? + && cln::isprobprime(cln::the(value))); } /** True if object is an exact rational number, may even be complex * (denominator may be unity). */ -bool numeric::is_rational(void) const +bool numeric::is_rational() const { return cln::instanceof(value, cln::cl_RA_ring); } /** True if object is a real integer, rational or float (but not complex). */ -bool numeric::is_real(void) const +bool numeric::is_real() const { return cln::instanceof(value, cln::cl_R_ring); } @@ -921,7 +1068,7 @@ bool numeric::operator!=(const numeric &other) const /** True if object is element of the domain of integers extended by I, i.e. is * of the form a+b*I, where a and b are integers. */ -bool numeric::is_cinteger(void) const +bool numeric::is_cinteger() const { if (cln::instanceof(value, cln::cl_I_ring)) return true; @@ -936,7 +1083,7 @@ bool numeric::is_cinteger(void) const /** True if object is an exact rational number, may even be complex * (denominator may be unity). */ -bool numeric::is_crational(void) const +bool numeric::is_crational() const { if (cln::instanceof(value, cln::cl_RA_ring)) return true; @@ -996,7 +1143,7 @@ bool numeric::operator>=(const numeric &other) const /** Converts numeric types to machine's int. You should check with * is_integer() if the number is really an integer before calling this method. * You may also consider checking the range first. */ -int numeric::to_int(void) const +int numeric::to_int() const { GINAC_ASSERT(this->is_integer()); return cln::cl_I_to_int(cln::the(value)); @@ -1006,7 +1153,7 @@ int numeric::to_int(void) const /** Converts numeric types to machine's long. You should check with * is_integer() if the number is really an integer before calling this method. * You may also consider checking the range first. */ -long numeric::to_long(void) const +long numeric::to_long() const { GINAC_ASSERT(this->is_integer()); return cln::cl_I_to_long(cln::the(value)); @@ -1015,7 +1162,7 @@ long numeric::to_long(void) const /** Converts numeric types to machine's double. You should check with is_real() * if the number is really not complex before calling this method. */ -double numeric::to_double(void) const +double numeric::to_double() const { GINAC_ASSERT(this->is_real()); return cln::double_approx(cln::realpart(cln::the(value))); @@ -1025,21 +1172,21 @@ double numeric::to_double(void) const /** Returns a new CLN object of type cl_N, representing the value of *this. * This method may be used when mixing GiNaC and CLN in one project. */ -cln::cl_N numeric::to_cl_N(void) const +cln::cl_N numeric::to_cl_N() const { return cln::cl_N(cln::the(value)); } /** Real part of a number. */ -const numeric numeric::real(void) const +const numeric numeric::real() const { return numeric(cln::realpart(cln::the(value))); } /** Imaginary part of a number. */ -const numeric numeric::imag(void) const +const numeric numeric::imag() const { return numeric(cln::imagpart(cln::the(value))); } @@ -1049,10 +1196,10 @@ const numeric numeric::imag(void) const * numerator of complex if real and imaginary part are both rational numbers * (i.e numer(4/3+5/6*I) == 8+5*I), the number carrying the sign in all other * cases. */ -const numeric numeric::numer(void) const +const numeric numeric::numer() const { - if (this->is_integer()) - return numeric(*this); + if (cln::instanceof(value, cln::cl_I_ring)) + return numeric(*this); // integer case else if (cln::instanceof(value, cln::cl_RA_ring)) return numeric(cln::numerator(cln::the(value))); @@ -1080,10 +1227,10 @@ const numeric numeric::numer(void) const /** Denominator. Computes the denominator of rational numbers, common integer * denominator of complex if real and imaginary part are both rational numbers * (i.e denom(4/3+5/6*I) == 6), one in all other cases. */ -const numeric numeric::denom(void) const +const numeric numeric::denom() const { - if (this->is_integer()) - return _num1; + if (cln::instanceof(value, cln::cl_I_ring)) + return _num1; // integer case if (cln::instanceof(value, cln::cl_RA_ring)) return numeric(cln::denominator(cln::the(value))); @@ -1111,9 +1258,9 @@ const numeric numeric::denom(void) const * * @return number of bits (excluding sign) needed to represent that number * in two's complement if it is an integer, 0 otherwise. */ -int numeric::int_length(void) const +int numeric::int_length() const { - if (this->is_integer()) + if (cln::instanceof(value, cln::cl_I_ring)) return cln::integer_length(cln::the(value)); else return 0; @@ -1140,14 +1287,14 @@ const numeric exp(const numeric &x) /** Natural logarithm. * - * @param z complex number + * @param x complex number * @return arbitrary precision numerical log(x). * @exception pole_error("log(): logarithmic pole",0) */ -const numeric log(const numeric &z) +const numeric log(const numeric &x) { - if (z.is_zero()) + if (x.is_zero()) throw pole_error("log(): logarithmic pole",0); - return cln::log(z.to_cl_N()); + return cln::log(x.to_cl_N()); } @@ -1198,8 +1345,8 @@ const numeric acos(const numeric &x) /** Arcustangent. * - * @param z complex number - * @return atan(z) + * @param x complex number + * @return atan(x) * @exception pole_error("atan(): logarithmic pole",0) */ const numeric atan(const numeric &x) { @@ -1537,14 +1684,13 @@ const numeric bernoulli(const numeric &nn) // algorithm not applicable to B(2), so just store it if (!next_r) { - results.push_back(); // results[0] is not used results.push_back(cln::recip(cln::cl_RA(6))); next_r = 4; } if (n(a.to_cl_N()), cln::the(b.to_cl_N())); @@ -1688,12 +1837,15 @@ const numeric irem(const numeric &a, const numeric &b) /** Numeric integer remainder. * Equivalent to Maple's irem(a,b,'q') it obeyes the relation * irem(a,b,q) == a - q*b. In general, mod(a,b) has the sign of b or is zero, - * and irem(a,b) has the sign of a or is zero. + * and irem(a,b) has the sign of a or is zero. * * @return remainder of a/b and quotient stored in q if both are integer, - * 0 otherwise. */ + * 0 otherwise. + * @exception overflow_error (division by zero) if b is zero. */ const numeric irem(const numeric &a, const numeric &b, numeric &q) { + if (b.is_zero()) + throw std::overflow_error("numeric::irem(): division by zero"); if (a.is_integer() && b.is_integer()) { const cln::cl_I_div_t rem_quo = cln::truncate2(cln::the(a.to_cl_N()), cln::the(b.to_cl_N())); @@ -1709,9 +1861,12 @@ const numeric irem(const numeric &a, const numeric &b, numeric &q) /** Numeric integer quotient. * Equivalent to Maple's iquo as far as sign conventions are concerned. * - * @return truncated quotient of a/b if both are integer, 0 otherwise. */ + * @return truncated quotient of a/b if both are integer, 0 otherwise. + * @exception overflow_error (division by zero) if b is zero. */ const numeric iquo(const numeric &a, const numeric &b) { + if (b.is_zero()) + throw std::overflow_error("numeric::iquo(): division by zero"); if (a.is_integer() && b.is_integer()) return cln::truncate1(cln::the(a.to_cl_N()), cln::the(b.to_cl_N())); @@ -1725,9 +1880,12 @@ const numeric iquo(const numeric &a, const numeric &b) * r == a - iquo(a,b,r)*b. * * @return truncated quotient of a/b and remainder stored in r if both are - * integer, 0 otherwise. */ + * integer, 0 otherwise. + * @exception overflow_error (division by zero) if b is zero. */ const numeric iquo(const numeric &a, const numeric &b, numeric &r) { + if (b.is_zero()) + throw std::overflow_error("numeric::iquo(): division by zero"); if (a.is_integer() && b.is_integer()) { const cln::cl_I_div_t rem_quo = cln::truncate2(cln::the(a.to_cl_N()), cln::the(b.to_cl_N())); @@ -1769,16 +1927,16 @@ const numeric lcm(const numeric &a, const numeric &b) /** Numeric square root. - * If possible, sqrt(z) should respect squares of exact numbers, i.e. sqrt(4) + * If possible, sqrt(x) should respect squares of exact numbers, i.e. sqrt(4) * should return integer 2. * - * @param z numeric argument - * @return square root of z. Branch cut along negative real axis, the negative - * real axis itself where imag(z)==0 and real(z)<0 belongs to the upper part - * where imag(z)>0. */ -const numeric sqrt(const numeric &z) + * @param x numeric argument + * @return square root of x. Branch cut along negative real axis, the negative + * real axis itself where imag(x)==0 and real(x)<0 belongs to the upper part + * where imag(x)>0. */ +const numeric sqrt(const numeric &x) { - return cln::sqrt(z.to_cl_N()); + return cln::sqrt(x.to_cl_N()); } @@ -1795,21 +1953,21 @@ const numeric isqrt(const numeric &x) /** Floating point evaluation of Archimedes' constant Pi. */ -ex PiEvalf(void) +ex PiEvalf() { return numeric(cln::pi(cln::default_float_format)); } /** Floating point evaluation of Euler's constant gamma. */ -ex EulerEvalf(void) +ex EulerEvalf() { return numeric(cln::eulerconst(cln::default_float_format)); } /** Floating point evaluation of Catalan's constant. */ -ex CatalanEvalf(void) +ex CatalanEvalf() { return numeric(cln::catalanconst(cln::default_float_format)); }