X-Git-Url: https://www.ginac.de/ginac.git//ginac.git?p=ginac.git;a=blobdiff_plain;f=check%2Fparanoia_check.cpp;h=b7552dcdf8508fd7707f5710670f5367cc77889b;hp=6504bd856b9c564deb1ba51797700bf0801a4bc8;hb=ff6822e9aa640a0ee6eeb653e891a236a19a1e64;hpb=c10054835b4c63a95b37703a952d663f280aa1ce

diff --git a/check/paranoia_check.cpp b/check/paranoia_check.cpp
index 6504bd85..b7552dcd 100644
--- a/check/paranoia_check.cpp
+++ b/check/paranoia_check.cpp
@@ -1,15 +1,37 @@
-// check/paranoia_check.cpp
-
-/* This set of tests checks for some of GiNaC's oopses which showed up during
- * development.  Things were evaluated wrongly and so.  It should not find such
- * a sick behaviour again.  But since we are paranoic and we want to exclude
- * that behaviour for good... */
-
-#include <GiNaC/ginac.h>
+/** @file paranoia_check.cpp
+ *
+ *  This set of tests checks for some of GiNaC's oopses which showed up during
+ *  development.  Things were evaluated wrongly and so.  Such a sick behaviour
+ *  shouldn't occur any more.  But we are paranoic and we want to exclude these
+ *  these oopses for good, so we run those stupid tests... */
+
+/*
+ *  GiNaC Copyright (C) 1999-2000 Johannes Gutenberg University Mainz, Germany
+ *
+ *  This program is free software; you can redistribute it and/or modify
+ *  it under the terms of the GNU General Public License as published by
+ *  the Free Software Foundation; either version 2 of the License, or
+ *  (at your option) any later version.
+ *
+ *  This program is distributed in the hope that it will be useful,
+ *  but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ *  GNU General Public License for more details.
+ *
+ *  You should have received a copy of the GNU General Public License
+ *  along with this program; if not, write to the Free Software
+ *  Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
+ */
+
+#include "ginac.h"
+
+#ifndef NO_NAMESPACE_GINAC
+using namespace GiNaC;
+#endif // ndef NO_NAMESPACE_GINAC
 
 // The very first pair of historic problems had its roots in power.cpp and was
-// finally resolved on April 27th. (Fixing the first on April 23rd actually
-// introduced the second.)
+// finally resolved on April 27th 1999. (Fixing the first on April 23rd
+// actually introduced the second.)
 static unsigned paranoia_check1(void)
 {
     unsigned result = 0;
@@ -21,7 +43,7 @@ static unsigned paranoia_check1(void)
     g = e / f;
 
     // In the first one expand did not do any job at all:
-    if ( !g.expand().is_equal(x) ) {
+    if (!g.expand().is_equal(x)) {
         clog << "e = x*y*z; f = y*z; expand(e/f) erroneously returned "
              << g.expand() << endl;
         ++result;
@@ -52,19 +74,19 @@ static unsigned paranoia_check2(void)
     g = f - e*y;
 
     // After .expand(), g should be zero:
-    if (!g.expand().is_equal(exZERO())) {
+    if (!g.expand().is_zero()) {
         clog << "e = (x + z*x); f = e*y; expand(f - e*y) erroneously returned "
              << g.expand() << endl;
         ++result;
     }
     // After .eval(), g should be zero:
-    if (!g.eval().is_equal(exZERO())) {
+    if (!g.eval().is_zero()) {
         clog << "e = (x + z*x); f = e*y; eval(f - e*y) erroneously returned "
              << g.eval() << endl;
         ++result;
     }
-    // This actually worked already back in April.  But we are very paranoic!
-    if (!g.expand().eval().is_equal(exZERO())) {
+    // This actually worked already back in April 1999.  But we are very paranoic!
+    if (!g.expand().eval().is_zero()) {
         clog << "e = (x + z*x); f = e*y; eval(expand(f - e*y)) erroneously returned "
              << g.expand().eval() << endl;
         ++result;
@@ -73,8 +95,9 @@ static unsigned paranoia_check2(void)
     return result;
 }
 
-// The third bug was introduced on May 18, discovered on May 19 and fixed that
-// same day.  It worked when x was substituted by 1 but not with other numbers:
+// The third bug was introduced on May 18th 1999, discovered on May 19 and
+// fixed that same day.  It worked when x was substituted by 1 but not with
+// other numbers:
 static unsigned paranoia_check3(void)
 {
     unsigned result = 0;
@@ -103,7 +126,7 @@ static unsigned paranoia_check3(void)
     return result;
 }
 
-// The fourth bug was also discovered on May 19 and fixed immediately:
+// The fourth bug was also discovered on May 19th 1999 and fixed immediately:
 static unsigned paranoia_check4(void)
 {
     unsigned result = 0;
@@ -114,12 +137,12 @@ static unsigned paranoia_check4(void)
     f = pow(x, 2) + x + 1;
     g = e - f;
 
-    if (!g.is_equal(exZERO())) {
+    if (!g.is_zero()) {
         clog << "e = pow(x,2) + x + 1; f = pow(x,2) + x + 1; g = e-f; g erroneously returned "
              << g << endl;
         ++result;
     }
-    if (!g.is_equal(exZERO())) {
+    if (!g.is_zero()) {
         clog << "e = pow(x,2) + x + 1; f = pow(x,2) + x + 1; g = e-f; g.eval() erroneously returned "
              << g.eval() << endl;
         ++result;
@@ -128,7 +151,7 @@ static unsigned paranoia_check4(void)
     return result;
 }
 
-// The fifth oops was discovered on May 20 and fixed a day later:
+// The fifth oops was discovered on May 20th 1999 and fixed a day later:
 static unsigned paranoia_check5(void)
 {
     unsigned result = 0;
@@ -138,7 +161,7 @@ static unsigned paranoia_check5(void)
     e = pow(x*y + 1, 2);
     f = pow(x, 2) * pow(y, 2) + 2*x*y + 1;
 
-    if (!(e-f).expand().is_equal(exZERO())) {
+    if (!(e-f).expand().is_zero()) {
         clog << "e = pow(x*y+1,2); f = pow(x,2)*pow(y,2) + 2*x*y + 1; (e-f).expand() erroneously returned "
              << (e-f).expand() << endl;
         ++result;
@@ -147,7 +170,7 @@ static unsigned paranoia_check5(void)
     return result;
 }
 
-// This one was discovered on Jun 1 and fixed the same day:
+// This one was discovered on Jun 1st 1999 and fixed the same day:
 static unsigned paranoia_check6(void)
 {
     unsigned result = 0;
@@ -164,8 +187,8 @@ static unsigned paranoia_check6(void)
     return result;
 }
 
-// This one was introduced on June 1 by some aggressive manual optimization.
-// Discovered and fixed on June 2.
+// This one was introduced on June 1st 1999 by some aggressive manual
+// optimization. Discovered and fixed on June 2nd.
 static unsigned paranoia_check7(void)
 {
     unsigned result = 0;
@@ -184,8 +207,8 @@ static unsigned paranoia_check7(void)
 }
 
 // This one was a result of the rewrite of mul::max_coefficient when we
-// introduced the overall_coefficient field in expairseq objects on Oct 1.
-// Fixed on Oct 4.
+// introduced the overall_coefficient field in expairseq objects on Oct 1st
+// 1999. Fixed on Oct 4th.
 static unsigned paranoia_check8(void)
 {
     unsigned result = 0;
@@ -203,6 +226,26 @@ static unsigned paranoia_check8(void)
     return result;
 }
 
+// This one was a result of a modification to frac_cancel() & Co. to avoid
+// expanding the numerator and denominator when bringing them from Q[X] to
+// Z[X]. multiply_lcm() forgot to multiply the x-linear term with the LCM of
+// the coefficient's denominators (2 in this case). Introduced on Jan 25th
+// 2000 and fixed on Jan 31th.
+static unsigned paranoia_check9(void)
+{
+    unsigned result = 0;
+    symbol x("x");
+
+    ex e = (exp(-x)-2*x*exp(-x)+pow(x,2)/2*exp(-x))/exp(-x);
+    ex f = e.normal();
+
+    if (!f.is_equal(1-2*x+pow(x,2)/2)) {
+        clog << "normal(" << e << ") returns " << f << " instead of 1-2*x+1/2*x^2\n";
+        ++result;
+    }
+    return result;
+}
+
 unsigned paranoia_check(void)
 {
     unsigned result = 0;
@@ -218,8 +261,9 @@ unsigned paranoia_check(void)
     result += paranoia_check6();
     result += paranoia_check7();
     result += paranoia_check8();
+    result += paranoia_check9();
 
-    if (! result) {
+    if (!result) {
         cout << " passed ";
         clog << "(no output)" << endl;
     } else {