X-Git-Url: https://www.ginac.de/ginac.git//ginac.git?p=ginac.git;a=blobdiff_plain;f=check%2Fparanoia_check.cpp;h=125fb7339ed904a66470fb121028243e7c713316;hp=2e0c40dfe1eba319eb85efe30e35da396b61c3c1;hb=5184d67c0ec1056ac039419e08558632793a4e2c;hpb=26741891dadf23162799009b6fd57b4984bd4ce5 diff --git a/check/paranoia_check.cpp b/check/paranoia_check.cpp index 2e0c40df..125fb733 100644 --- a/check/paranoia_check.cpp +++ b/check/paranoia_check.cpp @@ -6,7 +6,7 @@ * these oopses for good, so we run those stupid tests... */ /* - * GiNaC Copyright (C) 1999 Johannes Gutenberg University Mainz, Germany + * GiNaC Copyright (C) 1999-2000 Johannes Gutenberg University Mainz, Germany * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by @@ -23,15 +23,15 @@ * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA */ -#include +#include "ginac.h" -#ifndef NO_GINAC_NAMESPACE +#ifndef NO_NAMESPACE_GINAC using namespace GiNaC; -#endif // ndef NO_GINAC_NAMESPACE +#endif // ndef NO_NAMESPACE_GINAC // The very first pair of historic problems had its roots in power.cpp and was -// finally resolved on April 27th. (Fixing the first on April 23rd actually -// introduced the second.) +// finally resolved on April 27th 1999. (Fixing the first on April 23rd +// actually introduced the second.) static unsigned paranoia_check1(void) { unsigned result = 0; @@ -74,19 +74,20 @@ static unsigned paranoia_check2(void) g = f - e*y; // After .expand(), g should be zero: - if (!g.expand().is_equal(exZERO())) { + if (!g.expand().is_zero()) { clog << "e = (x + z*x); f = e*y; expand(f - e*y) erroneously returned " << g.expand() << endl; ++result; } // After .eval(), g should be zero: - if (!g.eval().is_equal(exZERO())) { + if (!g.eval().is_zero()) { clog << "e = (x + z*x); f = e*y; eval(f - e*y) erroneously returned " << g.eval() << endl; ++result; } - // This actually worked already back in April. But we are very paranoic! - if (!g.expand().eval().is_equal(exZERO())) { + // This actually worked already back in April 1999. + // But we are *very* paranoic! + if (!g.expand().eval().is_zero()) { clog << "e = (x + z*x); f = e*y; eval(expand(f - e*y)) erroneously returned " << g.expand().eval() << endl; ++result; @@ -95,8 +96,9 @@ static unsigned paranoia_check2(void) return result; } -// The third bug was introduced on May 18, discovered on May 19 and fixed that -// same day. It worked when x was substituted by 1 but not with other numbers: +// The third bug was introduced on May 18th 1999, discovered on May 19 and +// fixed that same day. It worked when x was substituted by 1 but not with +// other numbers: static unsigned paranoia_check3(void) { unsigned result = 0; @@ -125,7 +127,7 @@ static unsigned paranoia_check3(void) return result; } -// The fourth bug was also discovered on May 19 and fixed immediately: +// The fourth bug was also discovered on May 19th 1999 and fixed immediately: static unsigned paranoia_check4(void) { unsigned result = 0; @@ -136,12 +138,12 @@ static unsigned paranoia_check4(void) f = pow(x, 2) + x + 1; g = e - f; - if (!g.is_equal(exZERO())) { + if (!g.is_zero()) { clog << "e = pow(x,2) + x + 1; f = pow(x,2) + x + 1; g = e-f; g erroneously returned " << g << endl; ++result; } - if (!g.is_equal(exZERO())) { + if (!g.is_zero()) { clog << "e = pow(x,2) + x + 1; f = pow(x,2) + x + 1; g = e-f; g.eval() erroneously returned " << g.eval() << endl; ++result; @@ -150,7 +152,7 @@ static unsigned paranoia_check4(void) return result; } -// The fifth oops was discovered on May 20 and fixed a day later: +// The fifth oops was discovered on May 20th 1999 and fixed a day later: static unsigned paranoia_check5(void) { unsigned result = 0; @@ -160,7 +162,7 @@ static unsigned paranoia_check5(void) e = pow(x*y + 1, 2); f = pow(x, 2) * pow(y, 2) + 2*x*y + 1; - if (!(e-f).expand().is_equal(exZERO())) { + if (!(e-f).expand().is_zero()) { clog << "e = pow(x*y+1,2); f = pow(x,2)*pow(y,2) + 2*x*y + 1; (e-f).expand() erroneously returned " << (e-f).expand() << endl; ++result; @@ -169,7 +171,7 @@ static unsigned paranoia_check5(void) return result; } -// This one was discovered on Jun 1 and fixed the same day: +// This one was discovered on Jun 1st 1999 and fixed the same day: static unsigned paranoia_check6(void) { unsigned result = 0; @@ -186,8 +188,8 @@ static unsigned paranoia_check6(void) return result; } -// This one was introduced on June 1 by some aggressive manual optimization. -// Discovered and fixed on June 2. +// This one was introduced on June 1st 1999 by some aggressive manual +// optimization. Discovered and fixed on June 2nd. static unsigned paranoia_check7(void) { unsigned result = 0; @@ -206,25 +208,94 @@ static unsigned paranoia_check7(void) } // This one was a result of the rewrite of mul::max_coefficient when we -// introduced the overall_coefficient field in expairseq objects on Oct 1. -// Fixed on Oct 4. +// introduced the overall_coefficient field in expairseq objects on Oct 1st +// 1999. Fixed on Oct 4th. static unsigned paranoia_check8(void) { unsigned result = 0; symbol x("x"); ex e = -x / (x+1); + ex f; + + try { + f = e.normal(); + if (!f.is_equal(e)) { + clog << "normal(-x/(x+1)) returns " << f << " instead of -x/(x+1)\n"; + ++result; + } + } catch (const exception &e) { + clog << "normal(-x/(x+1) throws " << e.what() << endl; + ++result; + } + return result; +} + +// This one was a result of a modification to frac_cancel() & Co. to avoid +// expanding the numerator and denominator when bringing them from Q[X] to +// Z[X]. multiply_lcm() forgot to multiply the x-linear term with the LCM of +// the coefficient's denominators (2 in this case). Introduced on Jan 25th +// 2000 and fixed on Jan 31th. +static unsigned paranoia_check9(void) +{ + unsigned result = 0; + symbol x("x"); + + ex e = (exp(-x)-2*x*exp(-x)+pow(x,2)/2*exp(-x))/exp(-x); ex f = e.normal(); - // The bug caused a division by zero in normal(), so the following - // check is actually bogus... - if (!f.is_equal(e)) { - clog << "normal(-x/(x+1)) returns " << f << " instead of -x/(x+1)\n"; + if (!f.is_equal(1-2*x+pow(x,2)/2)) { + clog << "normal(" << e << ") returns " << f << " instead of 1-2*x+1/2*x^2\n"; ++result; } return result; } +// I have no idea when this broke. It has been working long ago, before 0.4.0 +// and on Feb 13th 2000 I found out that things like 2^(3/2) throw an exception +// "power::eval(): pow(0,0) is undefined" instead of simplifying to 2*2^(1/2). +// It was fixed that same day. +static unsigned paranoia_check10(void) +{ + unsigned result = 0; + + ex b = numeric(2); + ex e = numeric(3,2); + ex r; + + try { + r = pow(b,e).eval(); + if (!(r-2*sqrt(ex(2))).is_zero()) { + clog << "2^(3/2) erroneously returned " << r << " instead of 2*sqrt(2)" << endl; + ++result; + } + } catch (const exception &e) { + clog << "2^(3/2) throws " << e.what() << endl; + ++result; + } + return result; +} + +// After the rewriting of basic::normal() & Co. to return {num, den} lists, +// add::normal() forgot to multiply the denominator of the overall_coeff of +// its expanded and normalized children with the denominator of the expanded +// child (did you get this? Well, never mind...). Fixed on Feb 21th 2000. +static unsigned paranoia_check11(void) +{ + unsigned result = 0; + symbol x("x"); + + ex e = ((-5-2*x)-((2-5*x)/(-2+x))*(3+2*x))/(5-4*x); + ex f = e.normal(); + ex d = (4+10*x+8*pow(x,2))/(x-2)/(5-4*x); + + if (!(f - d).expand().is_zero()) { + clog << "normal(" << e << ") returns " << f << " instead of " << d << endl; + ++result; + } + return result; +} + unsigned paranoia_check(void) { unsigned result = 0; @@ -240,6 +311,9 @@ unsigned paranoia_check(void) result += paranoia_check6(); result += paranoia_check7(); result += paranoia_check8(); + result += paranoia_check9(); + result += paranoia_check10(); + result += paranoia_check11(); if (!result) { cout << " passed ";