X-Git-Url: https://www.ginac.de/ginac.git//ginac.git?p=ginac.git;a=blobdiff_plain;f=check%2Fexam_paranoia.cpp;h=51bd3a55ee1baaa61d54a0f166f876d47f61dab6;hp=f6bed67c929cc360594a84264803a39fd7e93c55;hb=56055db8e4780d223f6ddc680fb09ef994691c1d;hpb=7d870583a6bf21a2ffb7b6f051b702064623892e diff --git a/check/exam_paranoia.cpp b/check/exam_paranoia.cpp index f6bed67c..51bd3a55 100644 --- a/check/exam_paranoia.cpp +++ b/check/exam_paranoia.cpp @@ -6,7 +6,7 @@ * these oopses for good, so we run those stupid tests... */ /* - * GiNaC Copyright (C) 1999-2008 Johannes Gutenberg University Mainz, Germany + * GiNaC Copyright (C) 1999-2015 Johannes Gutenberg University Mainz, Germany * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by @@ -23,11 +23,12 @@ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA */ -#include #include "ginac.h" -using namespace std; using namespace GiNaC; +#include +using namespace std; + // The very first pair of historic problems had its roots in power.cpp and was // finally resolved on April 27th 1999. (Fixing the first on April 23rd // actually introduced the second.) @@ -466,6 +467,94 @@ static unsigned exam_paranoia17() return test_cycl.get_free_indices().size(); } +// Bug in add::eval() could result in numeric terms not being collected into +// the overall coefficient. Fixed on Sep 22, 2010 +static unsigned exam_paranoia18() +{ + ex sqrt2 = sqrt(ex(2)); + ex e = 1+2*(sqrt2+1)*(sqrt2-1); + if ( e.real_part() != 3 ) { + clog << "real_part(1+2*(sqrt(2)+1)*(sqrt(2)-1)) failed to evaluate to 3\n"; + return 1; + } + return 0; +} + +// Bug in mul::conjugate when factors are evaluated at branch cuts, reported as +// Sage bug #10964. +static unsigned exam_paranoia19() +{ + symbol a("a"); + ex e = conjugate(a*sqrt(ex(-2))*sqrt(ex(-3))); + ex c = a*conjugate(sqrt(ex(-2)))*conjugate(sqrt(ex(-3))); + if (!subs(e-c, a==42).is_zero()) { + clog << "subs(a*conjugate(sqrt(-2))*conjugate(sqrt(-3))-conjugate(a*sqrt(-2)*sqrt(-3)),a==42) failed to evaluate to 0\n"; + return 1; + } + return 0; +} + +// Bugs in is_polynomial (fixed 2011-05-20 and 2014-07-26). +static unsigned exam_paranoia20() +{ + unsigned result = 0; + symbol x("x"), y("y"); + ex e1 = sqrt(x*x+1)*sqrt(x+1); + if (e1.is_polynomial(x)) { + clog << "sqrt(x*x+1)*sqrt(x+1) is wrongly reported to be a polynomial in x\n"; + ++result; + } + ex e2 = sqrt(Pi)*x; + if (!e2.is_polynomial(x)) { + clog << "sqrt(Pi)*x is wrongly reported to be no polynomial in x\n"; + ++result; + } + ex e3 = sqrt(x); + if (!e3.is_polynomial(y)) { + clog << "sqrt(x) is wrongly reported to be no polynomial in y\n"; + ++result; + } + ex e4 = (1+y)/(2+x); + if (e4.is_polynomial(x)) { + clog << "(1+y)/(2+x) is wrongly reported to be a polynomial in x\n"; + ++result; + } + return result; +} + +static unsigned is_polynomial_false_positive() +{ + unsigned result = 0; + symbol x("x"), n("n"); + exvector nonpoly_exprs; + nonpoly_exprs.push_back(1/(1-x)); + nonpoly_exprs.push_back(1/(x+1)); + nonpoly_exprs.push_back(-1/(x-1)); + nonpoly_exprs.push_back(1/(1-x*x)); + nonpoly_exprs.push_back(1/(1-pow(x,n))); + nonpoly_exprs.push_back(x-1/(x-1)); + for (exvector::const_iterator ep = nonpoly_exprs.begin(); + ep != nonpoly_exprs.end(); ++ep) { + if (ep->is_polynomial(x)) { + clog << "(" << *ep << ").is_polynomial(" << x << ") " + "erroneously returned true" << endl; + ++result; + } + } + return result; +} + +// Bug in power::expand reported by Isuru Fernando (fixed 2015-05-07). +static unsigned exam_paranoia21() +{ + symbol x("x"); + ex e = pow(x + sqrt(ex(2))*x, 2).expand(); + if (e.nops() != 2) { + clog << "(x+sqrt(2)*x)^2 was wrongly expanded to " << e << "\n"; + return 1; + } + return 0; +} unsigned exam_paranoia() { @@ -490,6 +579,11 @@ unsigned exam_paranoia() result += exam_paranoia15(); cout << '.' << flush; result += exam_paranoia16(); cout << '.' << flush; result += exam_paranoia17(); cout << '.' << flush; + result += exam_paranoia18(); cout << '.' << flush; + result += exam_paranoia19(); cout << '.' << flush; + result += exam_paranoia20(); cout << '.' << flush; + result += is_polynomial_false_positive(); cout << '.' << flush; + result += exam_paranoia21(); cout << '.' << flush; return result; }