X-Git-Url: https://www.ginac.de/ginac.git//ginac.git?p=ginac.git;a=blobdiff_plain;f=check%2Fcheck_numeric.cpp;h=ec1eaf2814e7bfb20d7aeabe4d8cea46023d4c58;hp=3c569357f8c456210d52eee75ca6a8229ef56fad;hb=48a6c5094dd4ff641d0875b1303cfa8b2b489da1;hpb=591b85b0697370f2f5f25a29a1e94ff831a02c12

diff --git a/check/check_numeric.cpp b/check/check_numeric.cpp
index 3c569357..ec1eaf28 100644
--- a/check/check_numeric.cpp
+++ b/check/check_numeric.cpp
@@ -4,7 +4,7 @@
  *  tests on these numbers like is_integer() etc... */
 
 /*
- *  GiNaC Copyright (C) 1999-2001 Johannes Gutenberg University Mainz, Germany
+ *  GiNaC Copyright (C) 1999-2007 Johannes Gutenberg University Mainz, Germany
  *
  *  This program is free software; you can redistribute it and/or modify
  *  it under the terms of the GNU General Public License as published by
@@ -18,14 +18,14 @@
  *
  *  You should have received a copy of the GNU General Public License
  *  along with this program; if not, write to the Free Software
- *  Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
+ *  Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301  USA
  */
 
 #include "checks.h"
 
 /* Simple and maybe somewhat pointless consistency tests of assorted tests and
  * conversions. */
-static unsigned check_numeric1(void)
+static unsigned check_numeric1()
 {
 	unsigned result = 0;
 	bool errorflag = false;
@@ -53,35 +53,45 @@ static unsigned check_numeric1(void)
 	return result;
 }
 
-static unsigned check_numeric2(void)
+static unsigned check_numeric2()
 {
 	unsigned result = 0;
 	bool errorflag = false;
 	int i_num, i_den;
 	
 	// Check non-nested radicals (n/d)^(m/n) in ex wrapper class:
-	for (int i=0; i<200; ++i) {  // FIXME: run to ~200
+	for (int i=0; i<200; ++i) {
 		for (int j=2; j<13; ++j) {
 			// construct an exponent 1/j...
 			numeric nm(1,j);
 			nm += numeric(int(20.0*rand()/(RAND_MAX+1.0))-10);
 			// ...a numerator...
-			do { i_num = rand(); } while (i_num == 0);
+			do {
+				i_num = rand();
+			} while (i_num<=0);
 			numeric num(i_num);
 			// ...and a denominator.
-			do { i_den = (rand())/100; } while (i_den == 0);
+			do {
+				i_den = (rand())/100;
+			} while (i_den<=0);
 			numeric den(i_den);
 			// construct the radicals:
 			ex radical = pow(ex(num)/ex(den),ex(nm));
 			numeric floating = pow(num/den,nm);
 			// test the result:
 			if (is_a<numeric>(radical)) {
-				clog << "(" << num << "/" << den << ")^(" << nm
-				     << ") should have been a product, instead it's "
-				     << radical << endl;
-				errorflag = true;
+				// This is very improbable with decent random numbers but it
+				// still can happen, so we better check if it is correct:
+				if (pow(radical,inverse(nm))==num/den) {
+					// Aha! We drew some lucky numbers. Nothing to see here...
+				} else {
+					clog << "(" << num << "/" << den << ")^(" << nm
+						 << ") should have been a product, instead it's "
+						 << radical << endl;
+					errorflag = true;
+				}
 			}
-			numeric ratio = ex_to<numeric>(evalf(radical))/floating;
+			numeric ratio = abs(ex_to<numeric>(evalf(radical))/floating);
 			if (ratio>1.0001 && ratio<0.9999) {
 				clog << "(" << num << "/" << den << ")^(" << nm
 				     << ") erroneously evaluated to " << radical;
@@ -95,7 +105,7 @@ static unsigned check_numeric2(void)
 	return result;
 }
 
-unsigned check_numeric(void)
+unsigned check_numeric()
 {
 	unsigned result = 0;