X-Git-Url: https://www.ginac.de/ginac.git//ginac.git?p=ginac.git;a=blobdiff_plain;f=check%2Fcheck_lsolve.cpp;h=9f2a1ae562a518e9ce9559c0bd896cded38912dc;hp=4a84a13c13b54555fd359ec2b63ed6bd632c94e4;hb=4405b29465293f3b6ab37745ff601f519b0256e2;hpb=af922d5eb36ed70e4a9e3ffaf4c24492cf89a1a6

diff --git a/check/check_lsolve.cpp b/check/check_lsolve.cpp
index 4a84a13c..9f2a1ae5 100644
--- a/check/check_lsolve.cpp
+++ b/check/check_lsolve.cpp
@@ -1,10 +1,11 @@
 /** @file check_lsolve.cpp
  *
  *  These test routines do some simple checks on solving linear systems of
- *  symbolic equations. */
+ *  symbolic equations.  They are a well-tried resource for cross-checking
+ *  the underlying symbolic manipulations. */
 
 /*
- *  GiNaC Copyright (C) 1999-2000 Johannes Gutenberg University Mainz, Germany
+ *  GiNaC Copyright (C) 1999-2004 Johannes Gutenberg University Mainz, Germany
  *
  *  This program is free software; you can redistribute it and/or modify
  *  it under the terms of the GNU General Public License as published by
@@ -22,6 +23,7 @@
  */
 
 #include "checks.h"
+#include <sstream>
 
 static unsigned check_matrix_solve(unsigned m, unsigned n, unsigned p,
 								   unsigned degree)
@@ -49,9 +51,9 @@ static unsigned check_matrix_solve(unsigned m, unsigned n, unsigned p,
 	matrix X(n,p);
 	for (unsigned i=0; i<n; ++i) {
 		for (unsigned j=0; j<p; ++j) {
-			char buf[4];
-			ostrstream(buf,sizeof(buf)) << i << j << ends;
-			x.push_back(symbol(string("x")+buf));
+			ostringstream buf;
+			buf << "x" << i << j << ends;
+			x.push_back(symbol(buf.str()));
 			X.set(i,j,x[p*i+j]);
 		}
 	}
@@ -82,9 +84,9 @@ static unsigned check_matrix_solve(unsigned m, unsigned n, unsigned p,
 	}
 	if (errorflag) {
 		clog << "Our solve method claims that A*X==B, with matrices" << endl
-			 << "A == " << A << endl
-			 << "X == " << sol << endl
-			 << "B == " << B << endl;
+		     << "A == " << A << endl
+		     << "X == " << sol << endl
+		     << "B == " << B << endl;
 		return 1;
 	}
 	
@@ -95,16 +97,16 @@ static unsigned check_inifcns_lsolve(unsigned n)
 {
 	unsigned result = 0;
 	
-	for (int repetition=0; repetition<100; ++repetition) {
+	for (int repetition=0; repetition<200; ++repetition) {
 		// create two size n vectors of symbols, one for the coefficients
 		// a[0],..,a[n], one for indeterminates x[0]..x[n]:
 		vector<symbol> a;
 		vector<symbol> x;
 		for (unsigned i=0; i<n; ++i) {
-			char buf[3];
-			ostrstream(buf,sizeof(buf)) << i << ends;
-			a.push_back(symbol(string("a")+buf));
-			x.push_back(symbol(string("x")+buf));
+			ostringstream buf;
+			buf << i << ends;
+			a.push_back(symbol(string("a")+buf.str()));
+			x.push_back(symbol(string("x")+buf.str()));
 		}
 		lst eqns;  // equation list
 		lst vars;  // variable list
@@ -146,7 +148,7 @@ static unsigned check_inifcns_lsolve(unsigned n)
 			if (errorflag) {
 				++result;
 				clog << "solution of the system " << eqns << " for " << vars
-					 << " erroneously returned " << sol << endl;
+				     << " erroneously returned " << sol << endl;
 			}
 		}
 	}
@@ -154,7 +156,7 @@ static unsigned check_inifcns_lsolve(unsigned n)
 	return result;
 }
 
-unsigned check_lsolve(void)
+unsigned check_lsolve()
 {
 	unsigned result = 0;
 	
@@ -162,23 +164,23 @@ unsigned check_lsolve(void)
 	clog << "---------linear solve:" << endl;
 	
 	// solve some numeric linear systems
-	for (unsigned n=1; n<12; ++n)
+	for (unsigned n=1; n<14; ++n)
 		result += check_matrix_solve(n, n, 1, 0);
 	cout << '.' << flush;
 	// solve some underdetermined numeric systems
-	for (unsigned n=1; n<12; ++n)
+	for (unsigned n=1; n<14; ++n)
 		result += check_matrix_solve(n+1, n, 1, 0);
 	cout << '.' << flush;
 	// solve some overdetermined numeric systems
-	for (unsigned n=1; n<12; ++n)
+	for (unsigned n=1; n<14; ++n)
 		result += check_matrix_solve(n, n+1, 1, 0);
 	cout << '.' << flush;
 	// solve some multiple numeric systems
-	for (unsigned n=1; n<12; ++n)
+	for (unsigned n=1; n<14; ++n)
 		result += check_matrix_solve(n, n, n/3+1, 0);
 	cout << '.' << flush;
 	// solve some symbolic linear systems
-	for (unsigned n=1; n<7; ++n)
+	for (unsigned n=1; n<8; ++n)
 		result += check_matrix_solve(n, n, 1, 2);
 	cout << '.' << flush;