- gcd(): cofactor computation is faster in partially factorized case

[ginac.git] / ginac / normal.cpp

diff --git a/ginac/normal.cpp b/ginac/normal.cpp
index a7a37015efaf57737a7d91f26b139fbcec4ccd57..f57e4f0dbb60b31c3fc7bb053b905881ffee24f2 100644 (file)
--- a/ginac/normal.cpp
+++ b/ginac/normal.cpp
@@ -1112,10 +1112,8 @@ factored_a:
                }
                if (ca)
                        *ca = acc_ca;
                }
                if (ca)
                        *ca = acc_ca;

-               if (cb) {
-                       if (!divide(b, g, *cb))
-                throw(std::runtime_error("invalid expression in gcd(), division failed"));
-               }
+               if (cb)
+                       *cb = part_b;

                return g;
        } else if (is_ex_exactly_of_type(b, mul)) {
                if (is_ex_exactly_of_type(a, mul) && a.nops() > b.nops())
                return g;
        } else if (is_ex_exactly_of_type(b, mul)) {
                if (is_ex_exactly_of_type(a, mul) && a.nops() > b.nops())


@@ -1130,10 +1128,8 @@ factored_b:
                        acc_cb *= part_cb;
                        part_a = part_ca;
                }
                        acc_cb *= part_cb;
                        part_a = part_ca;
                }

-               if (ca) {
-                       if (!divide(a, g, *ca))
-                throw(std::runtime_error("invalid expression in gcd(), division failed"));
-               }
+               if (ca)
+                       *ca = part_a;

                if (cb)
                        *cb = acc_cb;
                return g;
                if (cb)
                        *cb = acc_cb;
                return g;