* Make zeta1_eval() more lightweight by copying less stuff.

[ginac.git] / ginac / inifcns_zeta.cpp

diff --git a/ginac/inifcns_zeta.cpp b/ginac/inifcns_zeta.cpp
index 0b3046e17977c687589a289bff4f11e8e119572d..a7b956ae71764ee870844b23a24e66e8cfe9df9e 100644 (file)
--- a/ginac/inifcns_zeta.cpp
+++ b/ginac/inifcns_zeta.cpp
@@ -38,35 +38,40 @@ namespace GiNaC {
 
 static ex zeta1_evalf(const ex & x)
 {
-       BEGIN_TYPECHECK
-               TYPECHECK(x,numeric)
-       END_TYPECHECK(zeta(x))
-               
-       return zeta(ex_to_numeric(x));
+       if (is_exactly_a<numeric>(x)) {
+               try {
+                       return zeta(ex_to<numeric>(x));
+               } catch (const dunno &e) { }
+       }
+       
+       return zeta(x).hold();
 }
 
 static ex zeta1_eval(const ex & x)
 {
        if (x.info(info_flags::numeric)) {
-               numeric y = ex_to_numeric(x);
+               const numeric &y = ex_to<numeric>(x);
                // trap integer arguments:
                if (y.is_integer()) {
                        if (y.is_zero())
-                               return -_ex1_2();
-                       if (x.is_equal(_ex1()))
+                               return _ex_1_2;
+                       if (y.is_equal(_num1))
                                throw(std::domain_error("zeta(1): infinity"));
-                       if (x.info(info_flags::posint)) {
-                               if (x.info(info_flags::odd))
+                       if (y.info(info_flags::posint)) {
+                               if (y.info(info_flags::odd))
                                        return zeta(x).hold();
                                else
-                                       return abs(bernoulli(y))*pow(Pi,x)*pow(_num2(),y-_num1())/factorial(y);
+                                       return abs(bernoulli(y))*pow(Pi,y)*pow(_num2,y-_num1)/factorial(y);
                        } else {
-                               if (x.info(info_flags::odd))
-                                       return -bernoulli(_num1()-y)/(_num1()-y);
+                               if (y.info(info_flags::odd))
+                                       return -bernoulli(_num1-y)/(_num1-y);
                                else
-                                       return _num0();
+                                       return _ex0;
                        }
                }
+               // zeta(float)
+               if (y.info(info_flags::numeric) && !y.info(info_flags::crational))
+                       return zeta1_evalf(x);
        }
        return zeta(x).hold();
 }
@@ -75,7 +80,7 @@ static ex zeta1_deriv(const ex & x, unsigned deriv_param)
 {
        GINAC_ASSERT(deriv_param==0);
        
-       return zeta(_ex1(), x);
+       return zeta(_ex1, x);
 }
 
 const unsigned function_index_zeta1 =
@@ -83,7 +88,7 @@ const unsigned function_index_zeta1 =
                               eval_func(zeta1_eval).
                               evalf_func(zeta1_evalf).
                               derivative_func(zeta1_deriv).
-                           latex_name("\\zeta").
+                              latex_name("\\zeta").
                               overloaded(2));
 
 //////////
@@ -117,6 +122,7 @@ const unsigned function_index_zeta2 =
        function::register_new(function_options("zeta").
                               eval_func(zeta2_eval).
                               derivative_func(zeta2_deriv).
+                              latex_name("\\zeta").
                               overloaded(2));
 
 } // namespace GiNaC