Fixed lots of bugs in factor_multivariate().

[ginac.git] / ginac / factor.cpp

diff --git a/ginac/factor.cpp b/ginac/factor.cpp
index 19549a25e41284bb016880e0e58fe9fec0a7af62..fb73897218db06ed31b40f32bf52aabca7e33acf 100644 (file)
--- a/ginac/factor.cpp
+++ b/ginac/factor.cpp
@@ -72,11 +72,29 @@ namespace {
 
 typedef vector<cl_MI> mvec;
 #ifdef DEBUGFACTOR
 
 typedef vector<cl_MI> mvec;
 #ifdef DEBUGFACTOR

+ostream& operator<<(ostream& o, const vector<int>& v)
+{
+       vector<int>::const_iterator i = v.begin(), end = v.end();
+       while ( i != end ) {
+               o << *i++ << " ";
+       }
+       return o;
+}
+ostream& operator<<(ostream& o, const vector<cl_I>& v)
+{
+       vector<cl_I>::const_iterator i = v.begin(), end = v.end();
+       while ( i != end ) {
+               o << *i << "[" << i-v.begin() << "]" << " ";
+               ++i;
+       }
+       return o;
+}

 ostream& operator<<(ostream& o, const vector<cl_MI>& v)
 {
        vector<cl_MI>::const_iterator i = v.begin(), end = v.end();
        while ( i != end ) {
 ostream& operator<<(ostream& o, const vector<cl_MI>& v)
 {
        vector<cl_MI>::const_iterator i = v.begin(), end = v.end();
        while ( i != end ) {

-               o << *i++ << " ";
+               o << *i << "[" << i-v.begin() << "]" << " ";
+               ++i;

        }
        return o;
 }
        }
        return o;
 }


@@ -84,7 +102,8 @@ ostream& operator<<(ostream& o, const vector< vector<cl_MI> >& v)
 {
        vector< vector<cl_MI> >::const_iterator i = v.begin(), end = v.end();
        while ( i != end ) {
 {
        vector< vector<cl_MI> >::const_iterator i = v.begin(), end = v.end();
        while ( i != end ) {

-               o << *i++ << endl;
+               o << i-v.begin() << ": " << *i << endl;
+               ++i;

        }
        return o;
 }
        }
        return o;
 }


@@ -93,9 +112,8 @@ ostream& operator<<(ostream& o, const vector< vector<cl_MI> >& v)
 ////////////////////////////////////////////////////////////////////////////////
 // modular univariate polynomial code
 
 ////////////////////////////////////////////////////////////////////////////////
 // modular univariate polynomial code
 

-//typedef cl_UP_MI umod;

 typedef std::vector<cln::cl_MI> umodpoly;
 typedef std::vector<cln::cl_MI> umodpoly;

-//typedef vector<umod> umodvec;
+typedef std::vector<cln::cl_I> upoly;

 typedef vector<umodpoly> upvec;
 
 // COPY FROM UPOLY.HPP
 typedef vector<umodpoly> upvec;
 
 // COPY FROM UPOLY.HPP


@@ -162,37 +180,25 @@ canonicalize(T& p, const typename T::size_type hint = std::numeric_limits<typena
 
 // END COPY FROM UPOLY.HPP
 
 
 // END COPY FROM UPOLY.HPP
 

-static void expt_pos(const umodpoly& a, unsigned int q, umodpoly& b)
-{
-       throw runtime_error("expt_pos: not implemented!");
-       // code below is not correct!
-//     b.clear();
-//     if ( a.empty() ) return;
-//     b.resize(degree(a)*q+1, a[0].ring()->zero());
-//     cl_MI norm = recip(a[0]);
-//     umodpoly an = a;
-//     for ( size_t i=0; i<an.size(); ++i ) {
-//             an[i] = an[i] * norm;
-//     }
-//     b[0] = a[0].ring()->one();
-//     for ( size_t i=1; i<b.size(); ++i ) {
-//             for ( size_t j=1; j<i; ++j ) {
-//                     b[i] = b[i] + ((i-j+1)*q-i-1) * a[i-j] * b[j-1];
-//             }
-//             b[i] = b[i] / i;
-//     }
-//     cl_MI corr = expt_pos(a[0], q);
-//     for ( size_t i=0; i<b.size(); ++i ) {
-//             b[i] = b[i] * corr;
-//     }
-}
-
-static umodpoly operator+(const umodpoly& a, const umodpoly& b)
+static void expt_pos(umodpoly& a, unsigned int q)
+{
+       if ( a.empty() ) return;
+       cl_MI zero = a[0].ring()->zero(); 
+       int deg = degree(a);
+       a.resize(degree(a)*q+1, zero);
+       for ( int i=deg; i>0; --i ) {
+               a[i*q] = a[i];
+               a[i] = zero;
+       }
+}
+
+template<typename T>
+static T operator+(const T& a, const T& b)

 {
        int sa = a.size();
        int sb = b.size();
        if ( sa >= sb ) {
 {
        int sa = a.size();
        int sb = b.size();
        if ( sa >= sb ) {

-               umodpoly r(sa);
+               T r(sa);

                int i = 0;
                for ( ; i<sb; ++i ) {
                        r[i] = a[i] + b[i];
                int i = 0;
                for ( ; i<sb; ++i ) {
                        r[i] = a[i] + b[i];


@@ -204,7 +210,7 @@ static umodpoly operator+(const umodpoly& a, const umodpoly& b)
                return r;
        }
        else {
                return r;
        }
        else {

-               umodpoly r(sb);
+               T r(sb);

                int i = 0;
                for ( ; i<sa; ++i ) {
                        r[i] = a[i] + b[i];
                int i = 0;
                for ( ; i<sa; ++i ) {
                        r[i] = a[i] + b[i];


@@ -217,12 +223,13 @@ static umodpoly operator+(const umodpoly& a, const umodpoly& b)
        }
 }
 
        }
 }
 

-static umodpoly operator-(const umodpoly& a, const umodpoly& b)
+template<typename T>
+static T operator-(const T& a, const T& b)

 {
        int sa = a.size();
        int sb = b.size();
        if ( sa >= sb ) {
 {
        int sa = a.size();
        int sb = b.size();
        if ( sa >= sb ) {

-               umodpoly r(sa);
+               T r(sa);

                int i = 0;
                for ( ; i<sb; ++i ) {
                        r[i] = a[i] - b[i];
                int i = 0;
                for ( ; i<sb; ++i ) {
                        r[i] = a[i] - b[i];


@@ -234,7 +241,7 @@ static umodpoly operator-(const umodpoly& a, const umodpoly& b)
                return r;
        }
        else {
                return r;
        }
        else {

-               umodpoly r(sb);
+               T r(sb);

                int i = 0;
                for ( ; i<sa; ++i ) {
                        r[i] = a[i] - b[i];
                int i = 0;
                for ( ; i<sa; ++i ) {
                        r[i] = a[i] - b[i];


@@ -247,6 +254,23 @@ static umodpoly operator-(const umodpoly& a, const umodpoly& b)
        }
 }
 
        }
 }
 

+static upoly operator*(const upoly& a, const upoly& b)
+{
+       upoly c;
+       if ( a.empty() || b.empty() ) return c;
+
+       int n = degree(a) + degree(b);
+       c.resize(n+1, 0);
+       for ( int i=0 ; i<=n; ++i ) {
+               for ( int j=0 ; j<=i; ++j ) {
+                       if ( j > degree(a) || (i-j) > degree(b) ) continue;
+                       c[i] = c[i] + a[j] * b[i-j];
+               }
+       }
+       canonicalize(c);
+       return c;
+}
+

 static umodpoly operator*(const umodpoly& a, const umodpoly& b)
 {
        umodpoly c;
 static umodpoly operator*(const umodpoly& a, const umodpoly& b)
 {
        umodpoly c;


@@ -256,7 +280,7 @@ static umodpoly operator*(const umodpoly& a, const umodpoly& b)
        c.resize(n+1, a[0].ring()->zero());
        for ( int i=0 ; i<=n; ++i ) {
                for ( int j=0 ; j<=i; ++j ) {
        c.resize(n+1, a[0].ring()->zero());
        for ( int i=0 ; i<=n; ++i ) {
                for ( int j=0 ; j<=i; ++j ) {

-                       if ( j > degree(a) || (i-j) > degree(b) ) continue; // TODO optimize!
+                       if ( j > degree(a) || (i-j) > degree(b) ) continue;

                        c[i] = c[i] + a[j] * b[i-j];
                }
        }
                        c[i] = c[i] + a[j] * b[i-j];
                }
        }


@@ -264,6 +288,32 @@ static umodpoly operator*(const umodpoly& a, const umodpoly& b)
        return c;
 }
 
        return c;
 }
 

+static upoly operator*(const upoly& a, const cl_I& x)
+{
+       if ( zerop(x) ) {
+               upoly r;
+               return r;
+       }
+       upoly r(a.size());
+       for ( size_t i=0; i<a.size(); ++i ) {
+               r[i] = a[i] * x;
+       }
+       return r;
+}
+
+static upoly operator/(const upoly& a, const cl_I& x)
+{
+       if ( zerop(x) ) {
+               upoly r;
+               return r;
+       }
+       upoly r(a.size());
+       for ( size_t i=0; i<a.size(); ++i ) {
+               r[i] = exquo(a[i],x);
+       }
+       return r;
+}
+

 static umodpoly operator*(const umodpoly& a, const cl_MI& x)
 {
        umodpoly r(a.size());
 static umodpoly operator*(const umodpoly& a, const cl_MI& x)
 {
        umodpoly r(a.size());


@@ -274,6 +324,31 @@ static umodpoly operator*(const umodpoly& a, const cl_MI& x)
        return r;
 }
 
        return r;
 }
 

+static void upoly_from_ex(upoly& up, const ex& e, const ex& x)
+{
+       // assert: e is in Z[x]
+       int deg = e.degree(x);
+       up.resize(deg+1);
+       int ldeg = e.ldegree(x);
+       for ( ; deg>=ldeg; --deg ) {
+               up[deg] = the<cl_I>(ex_to<numeric>(e.coeff(x, deg)).to_cl_N());
+       }
+       for ( ; deg>=0; --deg ) {
+               up[deg] = 0;
+       }
+       canonicalize(up);
+}
+
+static void umodpoly_from_upoly(umodpoly& ump, const upoly& e, const cl_modint_ring& R)
+{
+       int deg = degree(e);
+       ump.resize(deg+1);
+       for ( ; deg>=0; --deg ) {
+               ump[deg] = R->canonhom(e[deg]);
+       }
+       canonicalize(ump);
+}
+

 static void umodpoly_from_ex(umodpoly& ump, const ex& e, const ex& x, const cl_modint_ring& R)
 {
        // assert: e is in Z[x]
 static void umodpoly_from_ex(umodpoly& ump, const ex& e, const ex& x, const cl_modint_ring& R)
 {
        // assert: e is in Z[x]


@@ -290,12 +365,24 @@ static void umodpoly_from_ex(umodpoly& ump, const ex& e, const ex& x, const cl_m
        canonicalize(ump);
 }
 
        canonicalize(ump);
 }
 

+#ifdef DEBUGFACTOR

 static void umodpoly_from_ex(umodpoly& ump, const ex& e, const ex& x, const cl_I& modulus)
 {
        umodpoly_from_ex(ump, e, x, find_modint_ring(modulus));
 }
 static void umodpoly_from_ex(umodpoly& ump, const ex& e, const ex& x, const cl_I& modulus)
 {
        umodpoly_from_ex(ump, e, x, find_modint_ring(modulus));
 }

+#endif
+
+static ex upoly_to_ex(const upoly& a, const ex& x)
+{
+       if ( a.empty() ) return 0;
+       ex e;
+       for ( int i=degree(a); i>=0; --i ) {
+               e += numeric(a[i]) * pow(x, i);
+       }
+       return e;
+}

 
 

-static ex umod_to_ex(const umodpoly& a, const ex& x)
+static ex umodpoly_to_ex(const umodpoly& a, const ex& x)

 {
        if ( a.empty() ) return 0;
        cl_modint_ring R = a[0].ring();
 {
        if ( a.empty() ) return 0;
        cl_modint_ring R = a[0].ring();


@@ -313,6 +400,38 @@ static ex umod_to_ex(const umodpoly& a, const ex& x)
        return e;
 }
 
        return e;
 }
 

+static upoly umodpoly_to_upoly(const umodpoly& a)
+{
+       upoly e(a.size());
+       if ( a.empty() ) return e;
+       cl_modint_ring R = a[0].ring();
+       cl_I mod = R->modulus;
+       cl_I halfmod = (mod-1) >> 1;
+       for ( int i=degree(a); i>=0; --i ) {
+               cl_I n = R->retract(a[i]);
+               if ( n > halfmod ) {
+                       e[i] = n-mod;
+               } else {
+                       e[i] = n;
+               }
+       }
+       return e;
+}
+
+static umodpoly umodpoly_to_umodpoly(const umodpoly& a, const cl_modint_ring& R, unsigned int m)
+{
+       umodpoly e;
+       if ( a.empty() ) return e;
+       cl_modint_ring oldR = a[0].ring();
+       size_t sa = a.size();
+       e.resize(sa+m, R->zero());
+       for ( size_t i=0; i<sa; ++i ) {
+               e[i+m] = R->canonhom(oldR->retract(a[i]));
+       }
+       canonicalize(e);
+       return e;
+}
+

 /** Divides all coefficients of the polynomial a by the integer x.
  *  All coefficients are supposed to be divisible by x. If they are not, the
  *  the<cl_I> cast will raise an exception.
 /** Divides all coefficients of the polynomial a by the integer x.
  *  All coefficients are supposed to be divisible by x. If they are not, the
  *  the<cl_I> cast will raise an exception.


@@ -489,7 +608,7 @@ static bool squarefree(const umodpoly& a)
        umodpoly b;
        deriv(a, b);
        if ( b.empty() ) {
        umodpoly b;
        deriv(a, b);
        if ( b.empty() ) {

-               return true;
+               return false;

        }
        umodpoly c;
        gcd(a, b, c);
        }
        umodpoly c;
        gcd(a, b, c);


@@ -631,15 +750,19 @@ modular_matrix operator*(const modular_matrix& m1, const modular_matrix& m2)
 
 ostream& operator<<(ostream& o, const modular_matrix& m)
 {
 
 ostream& operator<<(ostream& o, const modular_matrix& m)
 {

-       vector<cl_MI>::const_iterator i = m.m.begin(), end = m.m.end();
-       size_t wrap = 1;
-       for ( ; i != end; ++i ) {
-               o << *i << " ";
-               if ( !(wrap++ % m.c) ) {
-                       o << endl;
+       cl_modint_ring R = m(0,0).ring();
+       o << "{";
+       for ( size_t i=0; i<m.rowsize(); ++i ) {
+               o << "{";
+               for ( size_t j=0; j<m.colsize()-1; ++j ) {
+                       o << R->retract(m(i,j)) << ",";
+               }
+               o << R->retract(m(i,m.colsize()-1)) << "}";
+               if ( i != m.rowsize()-1 ) {
+                       o << ",";

                }
        }
                }
        }

-       o << endl;
+       o << "}";

        return o;
 }
 #endif // def DEBUGFACTOR
        return o;
 }
 #endif // def DEBUGFACTOR


@@ -647,38 +770,26 @@ ostream& operator<<(ostream& o, const modular_matrix& m)
 // END modular matrix
 ////////////////////////////////////////////////////////////////////////////////
 
 // END modular matrix
 ////////////////////////////////////////////////////////////////////////////////
 

-static void q_matrix(const umodpoly& a, modular_matrix& Q)
+static void q_matrix(const umodpoly& a_, modular_matrix& Q)

 {
 {

+       umodpoly a = a_;
+       normalize_in_field(a);
+

        int n = degree(a);
        unsigned int q = cl_I_to_uint(a[0].ring()->modulus);
        int n = degree(a);
        unsigned int q = cl_I_to_uint(a[0].ring()->modulus);

-// fast and buggy
-//     vector<cl_MI> r(n, a.R->zero());
-//     r[0] = a.R->one();
-//     Q.set_row(0, r);
-//     unsigned int max = (n-1) * q;
-//     for ( size_t m=1; m<=max; ++m ) {
-//             cl_MI rn_1 = r.back();
-//             for ( size_t i=n-1; i>0; --i ) {
-//                     r[i] = r[i-1] - rn_1 * a[i];
-//             }
-//             r[0] = -rn_1 * a[0];
-//             if ( (m % q) == 0 ) {
-//                     Q.set_row(m/q, r);
-//             }
-//     }
-// slow and (hopefully) correct
-       cl_MI one = a[0].ring()->one();
-       cl_MI zero = a[0].ring()->zero();
-       for ( int i=0; i<n; ++i ) {
-               umodpoly qk(i*q+1, zero);
-               qk[i*q] = one;
-               umodpoly r;
-               rem(qk, a, r);
-               mvec rvec(n, zero);
-               for ( int j=0; j<=degree(r); ++j ) {
-                       rvec[j] = r[j];
-               }
-               Q.set_row(i, rvec);
+       umodpoly r(n, a[0].ring()->zero());
+       r[0] = a[0].ring()->one();
+       Q.set_row(0, r);
+       unsigned int max = (n-1) * q;
+       for ( size_t m=1; m<=max; ++m ) {
+               cl_MI rn_1 = r.back();
+               for ( size_t i=n-1; i>0; --i ) {
+                       r[i] = r[i-1] - (rn_1 * a[i]);
+               }
+               r[0] = -rn_1 * a[0];
+               if ( (m % q) == 0 ) {
+                       Q.set_row(m/q, r);
+               }

        }
 }
 
        }
 }
 


@@ -735,6 +846,7 @@ static void berlekamp(const umodpoly& a, upvec& upv)
        q_matrix(a, Q);
        vector<mvec> nu;
        nullspace(Q, nu);
        q_matrix(a, Q);
        vector<mvec> nu;
        nullspace(Q, nu);

+

        const unsigned int k = nu.size();
        if ( k == 1 ) {
                return;
        const unsigned int k = nu.size();
        if ( k == 1 ) {
                return;


@@ -787,299 +899,290 @@ static void berlekamp(const umodpoly& a, upvec& upv)
        }
 }
 
        }
 }
 

-static void rem_xq(int q, const umodpoly& b, umodpoly& c)
+static void expt_1_over_p(const umodpoly& a, unsigned int prime, umodpoly& ap)

 {
 {

-       cl_modint_ring R = b[0].ring();
-
-       int n = degree(b);
-       if ( n > q ) {
-               c.resize(q+1, R->zero());
-               c[q] = R->one();
-               return;
+       size_t newdeg = degree(a)/prime;
+       ap.resize(newdeg+1);
+       ap[0] = a[0];
+       for ( size_t i=1; i<=newdeg; ++i ) {
+               ap[i] = a[i*prime];

        }
        }

+}

 
 

-       c.clear();
-       c.resize(n+1, R->zero());
-       int k = q-n;
-       c[n] = R->one();
-
-       int ofs = 0;
-       do {
-               cl_MI qk = div(c[n-ofs], b[n]);
-               if ( !zerop(qk) ) {
-                       for ( int i=1; i<=n; ++i ) {
-                               c[n-i+ofs] = c[n-i] - qk * b[n-i];
+static void modsqrfree(const umodpoly& a, upvec& factors, vector<int>& mult)
+{
+       const unsigned int prime = cl_I_to_uint(a[0].ring()->modulus);
+       int i = 1;
+       umodpoly b;
+       deriv(a, b);
+       if ( b.size() ) {
+               umodpoly c;
+               gcd(a, b, c);
+               umodpoly w;
+               div(a, c, w);
+               while ( unequal_one(w) ) {
+                       umodpoly y;
+                       gcd(w, c, y);
+                       umodpoly z;
+                       div(w, y, z);
+                       factors.push_back(z);
+                       mult.push_back(i);
+                       ++i;
+                       w = y;
+                       umodpoly buf;
+                       div(c, y, buf);
+                       c = buf;
+               }
+               if ( unequal_one(c) ) {
+                       umodpoly cp;
+                       expt_1_over_p(c, prime, cp);
+                       size_t previ = mult.size();
+                       modsqrfree(cp, factors, mult);
+                       for ( size_t i=previ; i<mult.size(); ++i ) {
+                               mult[i] *= prime;

                        }
                        }

-                       ofs = ofs ? 0 : 1;

                }
                }

-       } while ( k-- );
-
-       if ( ofs ) {
-               c.pop_back();

        }
        else {
        }
        else {

-               c.erase(c.begin());
+               umodpoly ap;
+               expt_1_over_p(a, prime, ap);
+               size_t previ = mult.size();
+               modsqrfree(ap, factors, mult);
+               for ( size_t i=previ; i<mult.size(); ++i ) {
+                       mult[i] *= prime;
+               }

        }
        }

-       canonicalize(c);

 }
 
 }
 

-static void distinct_degree_factor(const umodpoly& a_, upvec& result)
+static void distinct_degree_factor(const umodpoly& a_, vector<int>& degrees, upvec& ddfactors)

 {
        umodpoly a = a_;
 
        cl_modint_ring R = a[0].ring();
        int q = cl_I_to_int(R->modulus);
 {
        umodpoly a = a_;
 
        cl_modint_ring R = a[0].ring();
        int q = cl_I_to_int(R->modulus);

-       int n = degree(a);
-       size_t nhalf = n/2;
+       int nhalf = degree(a)/2;

 
 

-       size_t i = 1;
-       umodpoly w(1, R->one());
+       int i = 1;
+       umodpoly w(2);
+       w[0] = R->zero();
+       w[1] = R->one();

        umodpoly x = w;
 
        umodpoly x = w;
 

-       upvec ai;
-

        while ( i <= nhalf ) {
        while ( i <= nhalf ) {

-               expt_pos(w, q, w);
-               rem(w, a, w);
-
+               expt_pos(w, q);

                umodpoly buf;
                umodpoly buf;

-               gcd(a, w-x, buf);
-               ai.push_back(buf);
-
-               if ( unequal_one(ai.back()) ) {
-                       div(a, ai.back(), a);
-                       rem(w, a, w);
+               rem(w, a, buf);
+               w = buf;
+               umodpoly wx = w - x;
+               gcd(a, wx, buf);
+               if ( unequal_one(buf) ) {
+                       degrees.push_back(i);
+                       ddfactors.push_back(buf);
+               }
+               if ( unequal_one(buf) ) {
+                       umodpoly buf2;
+                       div(a, buf, buf2);
+                       a = buf2;
+                       nhalf = degree(a)/2;
+                       rem(w, a, buf);
+                       w = buf;

                }
                }

-

                ++i;
        }
                ++i;
        }

-
-       result = ai;
-}
-
-static void same_degree_factor(const umodpoly& a, upvec& result)
-{
-       cl_modint_ring R = a[0].ring();
-       int deg = degree(a);
-
-       upvec buf;
-       distinct_degree_factor(a, buf);
-       int degsum = 0;
-
-       for ( size_t i=0; i<buf.size(); ++i ) {
-               if ( unequal_one(buf[i]) ) {
-                       degsum += degree(buf[i]);
-                       upvec upv;
-                       berlekamp(buf[i], upv);
-                       for ( size_t j=0; j<upv.size(); ++j ) {
-                               result.push_back(upv[j]);
-                       }
-               }
-       }
-
-       if ( degsum < deg ) {
-               result.push_back(a);
+       if ( unequal_one(a) ) {
+               degrees.push_back(degree(a));
+               ddfactors.push_back(a);

        }
 }
 
        }
 }
 

-static void distinct_degree_factor_BSGS(const umodpoly& a, upvec& result)
+static void same_degree_factor(const umodpoly& a, upvec& upv)

 {
        cl_modint_ring R = a[0].ring();
 {
        cl_modint_ring R = a[0].ring();

-       int q = cl_I_to_int(R->modulus);
-       int n = degree(a);

 
 

-       cl_N pm = 0.3;
-       int l = cl_I_to_int(ceiling1(the<cl_F>(expt(n, pm))));
-       upvec h(l+1);
-       umodpoly qk(1, R->one());
-       h[0] = qk;
-       for ( int i=1; i<=l; ++i ) {
-               expt_pos(h[i-1], q, qk);
-               rem(qk, a, h[i]);
-       }
+       vector<int> degrees;
+       upvec ddfactors;
+       distinct_degree_factor(a, degrees, ddfactors);

 
 

-       int m = std::ceil(((double)n)/2/l);
-       upvec H(m);
-       int ql = std::pow(q, l);
-       H[0] = h[l];
-       for ( int i=1; i<m; ++i ) {
-               expt_pos(H[i-1], ql, qk);
-               rem(qk, a, H[i]);
-       }
-
-       upvec I(m);
-       umodpoly one(1, R->one());
-       for ( int i=0; i<m; ++i ) {
-               I[i] = one;
-               for ( int j=0; j<l; ++j ) {
-                       I[i] = I[i] * (H[i] - h[j]);
+       for ( size_t i=0; i<degrees.size(); ++i ) {
+               if ( degrees[i] == degree(ddfactors[i]) ) {
+                       upv.push_back(ddfactors[i]);

                }
                }

-               rem(I[i], a, I[i]);
-       }
-
-       upvec F(m, one);
-       umodpoly f = a;
-       for ( int i=0; i<m; ++i ) {
-               umodpoly g;
-               gcd(f, I[i], g); 
-               if ( g == one ) continue;
-               F[i] = g;
-               div(f, g, f);
-       }
-
-       result.resize(n, one);
-       if ( unequal_one(f) ) {
-               result[n] = f;
-       }
-       for ( int i=0; i<m; ++i ) {
-               umodpoly f = F[i];
-               for ( int j=l-1; j>=0; --j ) {
-                       umodpoly g;
-                       gcd(f, H[i]-h[j], g);
-                       result[l*(i+1)-j-1] = g;
-                       div(f, g, f);
+               else {
+                       berlekamp(ddfactors[i], upv);

                }
        }
 }
 
                }
        }
 }
 

-static void cantor_zassenhaus(const umodpoly& a, upvec& result)
-{
-}
+#define USE_SAME_DEGREE_FACTOR

 
 static void factor_modular(const umodpoly& p, upvec& upv)
 {
 
 static void factor_modular(const umodpoly& p, upvec& upv)
 {

-       //same_degree_factor(p, upv);
+#ifdef USE_SAME_DEGREE_FACTOR
+       same_degree_factor(p, upv);
+#else

        berlekamp(p, upv);
        berlekamp(p, upv);

-       return;
+#endif

 }
 
 }
 

-static void exteuclid(const umodpoly& a, const umodpoly& b, umodpoly& g, umodpoly& s, umodpoly& t)
+/** Calculates polynomials s and t such that a*s+b*t==1.
+ *  Assertion: a and b are relatively prime and not zero.
+ *
+ *  @param[in]  a  polynomial
+ *  @param[in]  b  polynomial
+ *  @param[out] s  polynomial
+ *  @param[out] t  polynomial
+ */
+static void exteuclid(const umodpoly& a, const umodpoly& b, umodpoly& s, umodpoly& t)

 {
        if ( degree(a) < degree(b) ) {
 {
        if ( degree(a) < degree(b) ) {

-               exteuclid(b, a, g, t, s);
+               exteuclid(b, a, t, s);

                return;
        }
                return;
        }

+

        umodpoly one(1, a[0].ring()->one());
        umodpoly c = a; normalize_in_field(c);
        umodpoly d = b; normalize_in_field(d);
        umodpoly one(1, a[0].ring()->one());
        umodpoly c = a; normalize_in_field(c);
        umodpoly d = b; normalize_in_field(d);

-       umodpoly c1 = one;
-       umodpoly c2;
+       s = one;
+       t.clear();

        umodpoly d1;
        umodpoly d2 = one;
        umodpoly d1;
        umodpoly d2 = one;

-       while ( !d.empty() ) {
-               umodpoly q;
+       umodpoly q;
+       while ( true ) {

                div(c, d, q);
                umodpoly r = c - q * d;
                div(c, d, q);
                umodpoly r = c - q * d;

-               umodpoly r1 = c1 - q * d1;
-               umodpoly r2 = c2 - q * d2;
+               umodpoly r1 = s - q * d1;
+               umodpoly r2 = t - q * d2;

                c = d;
                c = d;

-               c1 = d1;
-               c2 = d2;
+               s = d1;
+               t = d2;
+               if ( r.empty() ) break;

                d = r;
                d1 = r1;
                d2 = r2;
        }
                d = r;
                d1 = r1;
                d2 = r2;
        }

-       g = c; normalize_in_field(g);
-       s = c1;
-       for ( int i=0; i<=degree(s); ++i ) {
-               s[i] = s[i] * recip(a[degree(a)] * c[degree(c)]);
+       cl_MI fac = recip(lcoeff(a) * lcoeff(c));
+       umodpoly::iterator i = s.begin(), end = s.end();
+       for ( ; i!=end; ++i ) {
+               *i = *i * fac;

        }
        canonicalize(s);
        }
        canonicalize(s);

-       s = s * g;
-       t = c2;
-       for ( int i=0; i<=degree(t); ++i ) {
-               t[i] = t[i] * recip(b[degree(b)] * c[degree(c)]);
+       fac = recip(lcoeff(b) * lcoeff(c));
+       i = t.begin(), end = t.end();
+       for ( ; i!=end; ++i ) {
+               *i = *i * fac;

        }
        canonicalize(t);
        }
        canonicalize(t);

-       t = t * g;

 }
 
 }
 

-static ex replace_lc(const ex& poly, const ex& x, const ex& lc)
+static upoly replace_lc(const upoly& poly, const cl_I& lc)

 {
 {

-       ex r = expand(poly + (lc - poly.lcoeff(x)) * pow(x, poly.degree(x)));
+       if ( poly.empty() ) return poly;
+       upoly r = poly;
+       r.back() = lc;

        return r;
 }
 
        return r;
 }
 

-static ex hensel_univar(const ex& a_, const ex& x, unsigned int p, const umodpoly& u1_, const umodpoly& w1_, const ex& gamma_ = 0)
+static inline cl_I calc_bound(const ex& a, const ex& x, int maxdeg)
+{
+       cl_I maxcoeff = 0;
+       cl_R coeff = 0;
+       for ( int i=a.degree(x); i>=a.ldegree(x); --i ) {
+               cl_I aa = abs(the<cl_I>(ex_to<numeric>(a.coeff(x, i)).to_cl_N()));
+               if ( aa > maxcoeff ) maxcoeff = aa;
+               coeff = coeff + square(aa);
+       }
+       cl_I coeffnorm = ceiling1(the<cl_R>(cln::sqrt(coeff)));
+       cl_I B = coeffnorm * expt_pos(cl_I(2), cl_I(maxdeg));
+       return ( B > maxcoeff ) ? B : maxcoeff;
+}
+
+static inline cl_I calc_bound(const upoly& a, int maxdeg)
+{
+       cl_I maxcoeff = 0;
+       cl_R coeff = 0;
+       for ( int i=degree(a); i>=0; --i ) {
+               cl_I aa = abs(a[i]);
+               if ( aa > maxcoeff ) maxcoeff = aa;
+               coeff = coeff + square(aa);
+       }
+       cl_I coeffnorm = ceiling1(the<cl_R>(cln::sqrt(coeff)));
+       cl_I B = coeffnorm * expt_pos(cl_I(2), cl_I(maxdeg));
+       return ( B > maxcoeff ) ? B : maxcoeff;
+}
+
+static void hensel_univar(const upoly& a_, unsigned int p, const umodpoly& u1_, const umodpoly& w1_, upoly& u, upoly& w)

 {
 {

-       ex a = a_;
+       upoly a = a_;

        const cl_modint_ring& R = u1_[0].ring();
 
        // calc bound B
        const cl_modint_ring& R = u1_[0].ring();
 
        // calc bound B

-       ex maxcoeff;
-       for ( int i=a.degree(x); i>=a.ldegree(x); --i ) {
-               maxcoeff += pow(abs(a.coeff(x, i)),2);
-       }
-       cl_I normmc = ceiling1(the<cl_R>(cln::sqrt(ex_to<numeric>(maxcoeff).to_cl_N())));
-       cl_I maxdegree = (degree(u1_) > degree(w1_)) ? degree(u1_) : degree(w1_);
-       cl_I B = normmc * expt_pos(cl_I(2), maxdegree);
+       int maxdeg = (degree(u1_) > degree(w1_)) ? degree(u1_) : degree(w1_);
+       cl_I maxmodulus = 2*calc_bound(a, maxdeg);

 
        // step 1
 
        // step 1

-       ex alpha = a.lcoeff(x);
-       ex gamma = gamma_;
-       if ( gamma == 0 ) {
-               gamma = alpha;
-       }
-       numeric gamma_ui = ex_to<numeric>(abs(gamma));
-       a = a * gamma;
+       cl_I alpha = lcoeff(a);
+       a = a * alpha;

        umodpoly nu1 = u1_;
        normalize_in_field(nu1);
        umodpoly nw1 = w1_;
        normalize_in_field(nw1);
        umodpoly nu1 = u1_;
        normalize_in_field(nu1);
        umodpoly nw1 = w1_;
        normalize_in_field(nw1);

-       ex phi;
-       phi = gamma * umod_to_ex(nu1, x);
+       upoly phi;
+       phi = umodpoly_to_upoly(nu1) * alpha;

        umodpoly u1;
        umodpoly u1;

-       umodpoly_from_ex(u1, phi, x, R);
-       phi = alpha * umod_to_ex(nw1, x);
+       umodpoly_from_upoly(u1, phi, R);
+       phi = umodpoly_to_upoly(nw1) * alpha;

        umodpoly w1;
        umodpoly w1;

-       umodpoly_from_ex(w1, phi, x, R);
+       umodpoly_from_upoly(w1, phi, R);

 
        // step 2
 
        // step 2

-       umodpoly g;

        umodpoly s;
        umodpoly t;
        umodpoly s;
        umodpoly t;

-       exteuclid(u1, w1, g, s, t);
-       if ( unequal_one(g) ) {
-               throw logic_error("gcd(u1,w1) != 1");
-       }
+       exteuclid(u1, w1, s, t);

 
        // step 3
 
        // step 3

-       ex u = replace_lc(umod_to_ex(u1, x), x, gamma);
-       ex w = replace_lc(umod_to_ex(w1, x), x, alpha);
-       ex e = expand(a - u * w);
-       numeric modulus = p;
-       const numeric maxmodulus = 2*numeric(B)*gamma_ui;
+       u = replace_lc(umodpoly_to_upoly(u1), alpha);
+       w = replace_lc(umodpoly_to_upoly(w1), alpha);
+       upoly e = a - u * w;
+       cl_I modulus = p;

 
        // step 4
 
        // step 4

-       while ( !e.is_zero() && modulus < maxmodulus ) {
-               ex c = e / modulus;
-               phi = expand(umod_to_ex(s, x) * c);
+       while ( !e.empty() && modulus < maxmodulus ) {
+               upoly c = e / modulus;
+               phi = umodpoly_to_upoly(s) * c;

                umodpoly sigmatilde;
                umodpoly sigmatilde;

-               umodpoly_from_ex(sigmatilde, phi, x, R);
-               phi = expand(umod_to_ex(t, x) * c);
+               umodpoly_from_upoly(sigmatilde, phi, R);
+               phi = umodpoly_to_upoly(t) * c;

                umodpoly tautilde;
                umodpoly tautilde;

-               umodpoly_from_ex(tautilde, phi, x, R);
+               umodpoly_from_upoly(tautilde, phi, R);

                umodpoly r, q;
                remdiv(sigmatilde, w1, r, q);
                umodpoly sigma = r;
                umodpoly r, q;
                remdiv(sigmatilde, w1, r, q);
                umodpoly sigma = r;

-               phi = expand(umod_to_ex(tautilde, x) + umod_to_ex(q, x) * umod_to_ex(u1, x));
+               phi = umodpoly_to_upoly(tautilde) + umodpoly_to_upoly(q) * umodpoly_to_upoly(u1);

                umodpoly tau;
                umodpoly tau;

-               umodpoly_from_ex(tau, phi, x, R);
-               u = expand(u + umod_to_ex(tau, x) * modulus);
-               w = expand(w + umod_to_ex(sigma, x) * modulus);
-               e = expand(a - u * w);
+               umodpoly_from_upoly(tau, phi, R);
+               u = u + umodpoly_to_upoly(tau) * modulus;
+               w = w + umodpoly_to_upoly(sigma) * modulus;
+               e = a - u * w;

                modulus = modulus * p;
        }
 
        // step 5
                modulus = modulus * p;
        }
 
        // step 5

-       if ( e.is_zero() ) {
-               ex delta = u.content(x);
-               u = u / delta;
-               w = w / gamma * delta;
-               return lst(u, w);
+       if ( e.empty() ) {
+               cl_I g = u[0];
+               for ( size_t i=1; i<u.size(); ++i ) {
+                       g = gcd(g, u[i]);
+                       if ( g == 1 ) break;
+               }
+               if ( g != 1 ) {
+                       u = u / g;
+                       w = w * g;
+               }
+               if ( alpha != 1 ) {
+                       w = w / alpha;
+               }

        }
        else {
        }
        else {

-               return lst();
+               u.clear();

        }
 }
 
        }
 }
 


@@ -1113,93 +1216,156 @@ static unsigned int next_prime(unsigned int p)
        throw logic_error("next_prime: should not reach this point!");
 }
 
        throw logic_error("next_prime: should not reach this point!");
 }
 

-class Partition
+class factor_partition

 {
 public:
 {
 public:

-       Partition(size_t n_) : n(n_)
+       factor_partition(const upvec& factors_) : factors(factors_)

        {
        {

-               k.resize(n, 1);
-               k[0] = 0;
-               sum = n-1;
+               n = factors.size();
+               k.resize(n, 0);
+               k[0] = 1;
+               cache.resize(n-1);
+               one.resize(1, factors.front()[0].ring()->one());
+               len = 1;
+               last = 0;
+               split();

        }
        int operator[](size_t i) const { return k[i]; }
        size_t size() const { return n; }
        }
        int operator[](size_t i) const { return k[i]; }
        size_t size() const { return n; }

-       size_t size_first() const { return n-sum; }
-       size_t size_second() const { return sum; }
+       size_t size_left() const { return n-len; }
+       size_t size_right() const { return len; }

 #ifdef DEBUGFACTOR
 #ifdef DEBUGFACTOR

-       void get() const
-       {
-               for ( size_t i=0; i<k.size(); ++i ) {
-                       cout << k[i] << " ";
-               }
-               cout << endl;
-       }
+       void get() const { DCOUTVAR(k); }

 #endif
        bool next()
        {
 #endif
        bool next()
        {

-               for ( size_t i=n-1; i>=1; --i ) {
-                       if ( k[i] ) {
-                               --k[i];
-                               --sum;
-                               return sum > 0;
+               if ( last == n-1 ) {
+                       int rem = len - 1;
+                       int p = last - 1;
+                       while ( rem ) {
+                               if ( k[p] ) {
+                                       --rem;
+                                       --p;
+                                       continue;
+                               }
+                               last = p - 1;
+                               while ( k[last] == 0 ) { --last; }
+                               if ( last == 0 && n == 2*len ) return false;
+                               k[last++] = 0;
+                               for ( size_t i=0; i<=len-rem; ++i ) {
+                                       k[last] = 1;
+                                       ++last;
+                               }
+                               fill(k.begin()+last, k.end(), 0);
+                               --last;
+                               split();
+                               return true;

                        }
                        }

-                       ++k[i];
-                       ++sum;
+                       last = len;
+                       ++len;
+                       if ( len > n/2 ) return false;
+                       fill(k.begin(), k.begin()+len, 1);
+                       fill(k.begin()+len+1, k.end(), 0);

                }
                }

-               return false;
+               else {
+                       k[last++] = 0;
+                       k[last] = 1;
+               }
+               split();
+               return true;

        }
        }

+       umodpoly& left() { return lr[0]; }
+       umodpoly& right() { return lr[1]; }

 private:
 private:

-       size_t n, sum;
-       vector<int> k;
-};
-
-static void split(const upvec& factors, const Partition& part, umodpoly& a, umodpoly& b)
-{
-       umodpoly one(1, factors.front()[0].ring()->one());
-       a = one;
-       b = one;
-       for ( size_t i=0; i<part.size(); ++i ) {
-               if ( part[i] ) {
-                       b = b * factors[i];
+       void split_cached()
+       {
+               size_t i = 0;
+               do {
+                       size_t pos = i;
+                       int group = k[i++];
+                       size_t d = 0;
+                       while ( i < n && k[i] == group ) { ++d; ++i; }
+                       if ( d ) {
+                               if ( cache[pos].size() >= d ) {
+                                       lr[group] = lr[group] * cache[pos][d-1];
+                               }
+                               else {
+                                       if ( cache[pos].size() == 0 ) {
+                                               cache[pos].push_back(factors[pos] * factors[pos+1]);
+                                       }
+                                       size_t j = pos + cache[pos].size() + 1;
+                                       d -= cache[pos].size();
+                                       while ( d ) {
+                                               umodpoly buf = cache[pos].back() * factors[j];
+                                               cache[pos].push_back(buf);
+                                               --d;
+                                               ++j;
+                                       }
+                                       lr[group] = lr[group] * cache[pos].back();
+                               }
+                       }
+                       else {
+                               lr[group] = lr[group] * factors[pos];
+                       }
+               } while ( i < n );
+       }
+       void split()
+       {
+               lr[0] = one;
+               lr[1] = one;
+               if ( n > 6 ) {
+                       split_cached();

                }
                else {
                }
                else {

-                       a = a * factors[i];
+                       for ( size_t i=0; i<n; ++i ) {
+                               lr[k[i]] = lr[k[i]] * factors[i];
+                       }

                }
        }
                }
        }

-}
+private:
+       umodpoly lr[2];
+       vector< vector<umodpoly> > cache;
+       upvec factors;
+       umodpoly one;
+       size_t n;
+       size_t len;
+       size_t last;
+       vector<int> k;
+};

 
 struct ModFactors
 {
 
 struct ModFactors
 {

-       ex poly;
+       upoly poly;

        upvec factors;
 };
 
        upvec factors;
 };
 

-static ex factor_univariate(const ex& poly, const ex& x)
+static ex factor_univariate(const ex& poly, const ex& x, unsigned int& prime)

 {
 {

-       ex unit, cont, prim;
-       poly.unitcontprim(x, unit, cont, prim);
+       ex unit, cont, prim_ex;
+       poly.unitcontprim(x, unit, cont, prim_ex);
+       upoly prim;
+       upoly_from_ex(prim, prim_ex, x);

 
        // determine proper prime and minimize number of modular factors
 
        // determine proper prime and minimize number of modular factors

-       unsigned int p = 3, lastp = 3;
+       prime = 3;
+       unsigned int lastp = prime;

        cl_modint_ring R;
        unsigned int trials = 0;
        unsigned int minfactors = 0;
        cl_modint_ring R;
        unsigned int trials = 0;
        unsigned int minfactors = 0;

-       numeric lcoeff = ex_to<numeric>(prim.lcoeff(x));
+       cl_I lc = lcoeff(prim) * the<cl_I>(ex_to<numeric>(cont).to_cl_N());

        upvec factors;
        while ( trials < 2 ) {
        upvec factors;
        while ( trials < 2 ) {

+               umodpoly modpoly;

                while ( true ) {
                while ( true ) {

-                       p = next_prime(p);
-                       if ( irem(lcoeff, p) != 0 ) {
-                               R = find_modint_ring(p);
-                               umodpoly modpoly;
-                               umodpoly_from_ex(modpoly, prim, x, R);
+                       prime = next_prime(prime);
+                       if ( !zerop(rem(lc, prime)) ) {
+                               R = find_modint_ring(prime);
+                               umodpoly_from_upoly(modpoly, prim, R);

                                if ( squarefree(modpoly) ) break;
                        }
                }
 
                // do modular factorization
                                if ( squarefree(modpoly) ) break;
                        }
                }
 
                // do modular factorization

-               umodpoly modpoly;
-               umodpoly_from_ex(modpoly, prim, x, R);

                upvec trialfactors;
                factor_modular(modpoly, trialfactors);
                if ( trialfactors.size() <= 1 ) {
                upvec trialfactors;
                factor_modular(modpoly, trialfactors);
                if ( trialfactors.size() <= 1 ) {


@@ -1209,17 +1375,16 @@ static ex factor_univariate(const ex& poly, const ex& x)
 
                if ( minfactors == 0 || trialfactors.size() < minfactors ) {
                        factors = trialfactors;
 
                if ( minfactors == 0 || trialfactors.size() < minfactors ) {
                        factors = trialfactors;

-                       minfactors = factors.size();
-                       lastp = p;
+                       minfactors = trialfactors.size();
+                       lastp = prime;

                        trials = 1;
                }
                else {
                        ++trials;
                }
        }
                        trials = 1;
                }
                else {
                        ++trials;
                }
        }

-       p = lastp;
-       R = find_modint_ring(p);
-       cl_univpoly_modint_ring UPR = find_univpoly_ring(R);
+       prime = lastp;
+       R = find_modint_ring(prime);

 
        // lift all factor combinations
        stack<ModFactors> tocheck;
 
        // lift all factor combinations
        stack<ModFactors> tocheck;


@@ -1227,24 +1392,22 @@ static ex factor_univariate(const ex& poly, const ex& x)
        mf.poly = prim;
        mf.factors = factors;
        tocheck.push(mf);
        mf.poly = prim;
        mf.factors = factors;
        tocheck.push(mf);

+       upoly f1, f2;

        ex result = 1;
        while ( tocheck.size() ) {
                const size_t n = tocheck.top().factors.size();
        ex result = 1;
        while ( tocheck.size() ) {
                const size_t n = tocheck.top().factors.size();

-               Partition part(n);
+               factor_partition part(tocheck.top().factors);

                while ( true ) {
                while ( true ) {

-                       umodpoly a, b;
-                       split(tocheck.top().factors, part, a, b);
-
-                       ex answer = hensel_univar(tocheck.top().poly, x, p, a, b);
-                       if ( answer != lst() ) {
-                               if ( part.size_first() == 1 ) {
-                                       if ( part.size_second() == 1 ) {
-                                               result *= answer.op(0) * answer.op(1);
+                       hensel_univar(tocheck.top().poly, prime, part.left(), part.right(), f1, f2);
+                       if ( !f1.empty() ) {
+                               if ( part.size_left() == 1 ) {
+                                       if ( part.size_right() == 1 ) {
+                                               result *= upoly_to_ex(f1, x) * upoly_to_ex(f2, x);

                                                tocheck.pop();
                                                break;
                                        }
                                                tocheck.pop();
                                                break;
                                        }

-                                       result *= answer.op(0);
-                                       tocheck.top().poly = answer.op(1);
+                                       result *= upoly_to_ex(f1, x);
+                                       tocheck.top().poly = f2;

                                        for ( size_t i=0; i<n; ++i ) {
                                                if ( part[i] == 0 ) {
                                                        tocheck.top().factors.erase(tocheck.top().factors.begin()+i);
                                        for ( size_t i=0; i<n; ++i ) {
                                                if ( part[i] == 0 ) {
                                                        tocheck.top().factors.erase(tocheck.top().factors.begin()+i);


@@ -1253,14 +1416,14 @@ static ex factor_univariate(const ex& poly, const ex& x)
                                        }
                                        break;
                                }
                                        }
                                        break;
                                }

-                               else if ( part.size_second() == 1 ) {
-                                       if ( part.size_first() == 1 ) {
-                                               result *= answer.op(0) * answer.op(1);
+                               else if ( part.size_right() == 1 ) {
+                                       if ( part.size_left() == 1 ) {
+                                               result *= upoly_to_ex(f1, x) * upoly_to_ex(f2, x);

                                                tocheck.pop();
                                                break;
                                        }
                                                tocheck.pop();
                                                break;
                                        }

-                                       result *= answer.op(1);
-                                       tocheck.top().poly = answer.op(0);
+                                       result *= upoly_to_ex(f2, x);
+                                       tocheck.top().poly = f1;

                                        for ( size_t i=0; i<n; ++i ) {
                                                if ( part[i] == 1 ) {
                                                        tocheck.top().factors.erase(tocheck.top().factors.begin()+i);
                                        for ( size_t i=0; i<n; ++i ) {
                                                if ( part[i] == 1 ) {
                                                        tocheck.top().factors.erase(tocheck.top().factors.begin()+i);


@@ -1270,7 +1433,7 @@ static ex factor_univariate(const ex& poly, const ex& x)
                                        break;
                                }
                                else {
                                        break;
                                }
                                else {

-                                       upvec newfactors1(part.size_first()), newfactors2(part.size_second());
+                                       upvec newfactors1(part.size_left()), newfactors2(part.size_right());

                                        upvec::iterator i1 = newfactors1.begin(), i2 = newfactors2.begin();
                                        for ( size_t i=0; i<n; ++i ) {
                                                if ( part[i] ) {
                                        upvec::iterator i1 = newfactors1.begin(), i2 = newfactors2.begin();
                                        for ( size_t i=0; i<n; ++i ) {
                                                if ( part[i] ) {


@@ -1281,17 +1444,17 @@ static ex factor_univariate(const ex& poly, const ex& x)
                                                }
                                        }
                                        tocheck.top().factors = newfactors1;
                                                }
                                        }
                                        tocheck.top().factors = newfactors1;

-                                       tocheck.top().poly = answer.op(0);
+                                       tocheck.top().poly = f1;

                                        ModFactors mf;
                                        mf.factors = newfactors2;
                                        ModFactors mf;
                                        mf.factors = newfactors2;

-                                       mf.poly = answer.op(1);
+                                       mf.poly = f2;

                                        tocheck.push(mf);
                                        break;
                                }
                        }
                        else {
                                if ( !part.next() ) {
                                        tocheck.push(mf);
                                        break;
                                }
                        }
                        else {
                                if ( !part.next() ) {

-                                       result *= tocheck.top().poly;
+                                       result *= upoly_to_ex(tocheck.top().poly, x);

                                        tocheck.pop();
                                        break;
                                }
                                        tocheck.pop();
                                        break;
                                }


@@ -1302,6 +1465,12 @@ static ex factor_univariate(const ex& poly, const ex& x)
        return unit * cont * result;
 }
 
        return unit * cont * result;
 }
 

+static inline ex factor_univariate(const ex& poly, const ex& x)
+{
+       unsigned int prime;
+       return factor_univariate(poly, x, prime);
+}
+

 struct EvalPoint
 {
        ex x;
 struct EvalPoint
 {
        ex x;


@@ -1309,9 +1478,9 @@ struct EvalPoint
 };
 
 // forward declaration
 };
 
 // forward declaration

-vector<ex> multivar_diophant(const vector<ex>& a_, const ex& x, const ex& c, const vector<EvalPoint>& I, unsigned int d, unsigned int p, unsigned int k);
+static vector<ex> multivar_diophant(const vector<ex>& a_, const ex& x, const ex& c, const vector<EvalPoint>& I, unsigned int d, unsigned int p, unsigned int k);

 
 

-upvec multiterm_eea_lift(const upvec& a, const ex& x, unsigned int p, unsigned int k)
+static upvec multiterm_eea_lift(const upvec& a, const ex& x, unsigned int p, unsigned int k)

 {
        const size_t r = a.size();
        cl_modint_ring R = find_modint_ring(expt_pos(cl_I(p),k));
 {
        const size_t r = a.size();
        cl_modint_ring R = find_modint_ring(expt_pos(cl_I(p),k));


@@ -1324,10 +1493,10 @@ upvec multiterm_eea_lift(const upvec& a, const ex& x, unsigned int p, unsigned i
        upvec s;
        for ( size_t j=1; j<r; ++j ) {
                vector<ex> mdarg(2);
        upvec s;
        for ( size_t j=1; j<r; ++j ) {
                vector<ex> mdarg(2);

-               mdarg[0] = umod_to_ex(q[j-1], x);
-               mdarg[1] = umod_to_ex(a[j-1], x);
+               mdarg[0] = umodpoly_to_ex(q[j-1], x);
+               mdarg[1] = umodpoly_to_ex(a[j-1], x);

                vector<EvalPoint> empty;
                vector<EvalPoint> empty;

-               vector<ex> exsigma = multivar_diophant(mdarg, x, umod_to_ex(beta, x), empty, 0, p, k);
+               vector<ex> exsigma = multivar_diophant(mdarg, x, umodpoly_to_ex(beta, x), empty, 0, p, k);

                umodpoly sigma1;
                umodpoly_from_ex(sigma1, exsigma[0], x, R);
                umodpoly sigma2;
                umodpoly sigma1;
                umodpoly_from_ex(sigma1, exsigma[0], x, R);
                umodpoly sigma2;


@@ -1342,7 +1511,7 @@ upvec multiterm_eea_lift(const upvec& a, const ex& x, unsigned int p, unsigned i
 /**
  *  Assert: a not empty.
  */
 /**
  *  Assert: a not empty.
  */

-void change_modulus(const cl_modint_ring& R, umodpoly& a)
+static void change_modulus(const cl_modint_ring& R, umodpoly& a)

 {
        if ( a.empty() ) return;
        cl_modint_ring oldR = a[0].ring();
 {
        if ( a.empty() ) return;
        cl_modint_ring oldR = a[0].ring();


@@ -1353,7 +1522,7 @@ void change_modulus(const cl_modint_ring& R, umodpoly& a)
        canonicalize(a);
 }
 
        canonicalize(a);
 }
 

-void eea_lift(const umodpoly& a, const umodpoly& b, const ex& x, unsigned int p, unsigned int k, umodpoly& s_, umodpoly& t_)
+static void eea_lift(const umodpoly& a, const umodpoly& b, const ex& x, unsigned int p, unsigned int k, umodpoly& s_, umodpoly& t_)

 {
        cl_modint_ring R = find_modint_ring(p);
        umodpoly amod = a;
 {
        cl_modint_ring R = find_modint_ring(p);
        umodpoly amod = a;


@@ -1361,13 +1530,9 @@ void eea_lift(const umodpoly& a, const umodpoly& b, const ex& x, unsigned int p,
        umodpoly bmod = b;
        change_modulus(R, bmod);
 
        umodpoly bmod = b;
        change_modulus(R, bmod);
 

-       umodpoly g;

        umodpoly smod;
        umodpoly tmod;
        umodpoly smod;
        umodpoly tmod;

-       exteuclid(amod, bmod, g, smod, tmod);
-       if ( unequal_one(g) ) {
-               throw logic_error("gcd(amod,bmod) != 1");
-       }
+       exteuclid(amod, bmod, smod, tmod);

 
        cl_modint_ring Rpk = find_modint_ring(expt_pos(cl_I(p),k));
        umodpoly s = smod;
 
        cl_modint_ring Rpk = find_modint_ring(expt_pos(cl_I(p),k));
        umodpoly s = smod;


@@ -1400,7 +1565,7 @@ void eea_lift(const umodpoly& a, const umodpoly& b, const ex& x, unsigned int p,
        s_ = s; t_ = t;
 }
 
        s_ = s; t_ = t;
 }
 

-upvec univar_diophant(const upvec& a, const ex& x, unsigned int m, unsigned int p, unsigned int k)
+static upvec univar_diophant(const upvec& a, const ex& x, unsigned int m, unsigned int p, unsigned int k)

 {
        cl_modint_ring R = find_modint_ring(expt_pos(cl_I(p),k));
 
 {
        cl_modint_ring R = find_modint_ring(expt_pos(cl_I(p),k));
 


@@ -1409,29 +1574,22 @@ upvec univar_diophant(const upvec& a, const ex& x, unsigned int m, unsigned int
        if ( r > 2 ) {
                upvec s = multiterm_eea_lift(a, x, p, k);
                for ( size_t j=0; j<r; ++j ) {
        if ( r > 2 ) {
                upvec s = multiterm_eea_lift(a, x, p, k);
                for ( size_t j=0; j<r; ++j ) {

-                       ex phi = expand(pow(x,m) * umod_to_ex(s[j], x));
-                       umodpoly bmod;
-                       umodpoly_from_ex(bmod, phi, x, R);
+                       umodpoly bmod = umodpoly_to_umodpoly(s[j], R, m);

                        umodpoly buf;
                        rem(bmod, a[j], buf);
                        result.push_back(buf);
                }
        }
        else {
                        umodpoly buf;
                        rem(bmod, a[j], buf);
                        result.push_back(buf);
                }
        }
        else {

-               umodpoly s;
-               umodpoly t;
+               umodpoly s, t;

                eea_lift(a[1], a[0], x, p, k, s, t);
                eea_lift(a[1], a[0], x, p, k, s, t);

-               ex phi = expand(pow(x,m) * umod_to_ex(s, x));
-               umodpoly bmod;
-               umodpoly_from_ex(bmod, phi, x, R);
+               umodpoly bmod = umodpoly_to_umodpoly(s, R, m);

                umodpoly buf, q;
                remdiv(bmod, a[0], buf, q);
                result.push_back(buf);
                umodpoly buf, q;
                remdiv(bmod, a[0], buf, q);
                result.push_back(buf);

-               phi = expand(pow(x,m) * umod_to_ex(t, x));
-               umodpoly t1mod;
-               umodpoly_from_ex(t1mod, phi, x, R);
-               umodpoly buf2 = t1mod + q * a[1];
-               result.push_back(buf2);
+               umodpoly t1mod = umodpoly_to_umodpoly(t, R, m);
+               buf = t1mod + q * a[1];
+               result.push_back(buf);

        }
 
        return result;
        }
 
        return result;


@@ -1467,7 +1625,8 @@ static ex make_modular(const ex& e, const cl_modint_ring& R)
        return map(e.expand());
 }
 
        return map(e.expand());
 }
 

-vector<ex> multivar_diophant(const vector<ex>& a_, const ex& x, const ex& c, const vector<EvalPoint>& I, unsigned int d, unsigned int p, unsigned int k)
+static vector<ex> multivar_diophant(const vector<ex>& a_, const ex& x, const ex& c, const vector<EvalPoint>& I,
+                                    unsigned int d, unsigned int p, unsigned int k)

 {
        vector<ex> a = a_;
 
 {
        vector<ex> a = a_;
 


@@ -1505,22 +1664,20 @@ vector<ex> multivar_diophant(const vector<ex>& a_, const ex& x, const ex& c, con
                ex e = make_modular(buf, R);
 
                ex monomial = 1;
                ex e = make_modular(buf, R);
 
                ex monomial = 1;

-               for ( size_t m=1; m<=d; ++m ) {
-                       while ( !e.is_zero() && e.has(xnu) ) {
-                               monomial *= (xnu - alphanu);
-                               monomial = expand(monomial);
-                               ex cm = e.diff(ex_to<symbol>(xnu), m).subs(xnu==alphanu) / factorial(m);
-                               cm = make_modular(cm, R);
-                               if ( !cm.is_zero() ) {
-                                       vector<ex> delta_s = multivar_diophant(anew, x, cm, Inew, d, p, k);
-                                       ex buf = e;
-                                       for ( size_t j=0; j<delta_s.size(); ++j ) {
-                                               delta_s[j] *= monomial;
-                                               sigma[j] += delta_s[j];
-                                               buf -= delta_s[j] * b[j];
-                                       }
-                                       e = make_modular(buf, R);
+               for ( size_t m=1; !e.is_zero() && e.has(xnu) && m<=d; ++m ) {
+                       monomial *= (xnu - alphanu);
+                       monomial = expand(monomial);
+                       ex cm = e.diff(ex_to<symbol>(xnu), m).subs(xnu==alphanu) / factorial(m);
+                       cm = make_modular(cm, R);
+                       if ( !cm.is_zero() ) {
+                               vector<ex> delta_s = multivar_diophant(anew, x, cm, Inew, d, p, k);
+                               ex buf = e;
+                               for ( size_t j=0; j<delta_s.size(); ++j ) {
+                                       delta_s[j] *= monomial;
+                                       sigma[j] += delta_s[j];
+                                       buf -= delta_s[j] * b[j];

                                }
                                }

+                               e = make_modular(buf, R);

                        }
                }
        }
                        }
                }
        }


@@ -1555,7 +1712,7 @@ vector<ex> multivar_diophant(const vector<ex>& a_, const ex& x, const ex& c, con
                        modcm = cl_MI(R, poscm);
                        for ( size_t j=0; j<delta_s.size(); ++j ) {
                                delta_s[j] = delta_s[j] * modcm;
                        modcm = cl_MI(R, poscm);
                        for ( size_t j=0; j<delta_s.size(); ++j ) {
                                delta_s[j] = delta_s[j] * modcm;

-                               sigma[j] = sigma[j] + umod_to_ex(delta_s[j], x);
+                               sigma[j] = sigma[j] + umodpoly_to_ex(delta_s[j], x);

                        }
                        if ( nterms > 1 ) {
                                z = c.op(i+1);
                        }
                        if ( nterms > 1 ) {
                                z = c.op(i+1);


@@ -1580,7 +1737,7 @@ ostream& operator<<(ostream& o, const vector<EvalPoint>& v)
 }
 #endif // def DEBUGFACTOR
 
 }
 #endif // def DEBUGFACTOR
 

-ex hensel_multivar(const ex& a, const ex& x, const vector<EvalPoint>& I, unsigned int p, const cl_I& l, const upvec& u, const vector<ex>& lcU)
+static ex hensel_multivar(const ex& a, const ex& x, const vector<EvalPoint>& I, unsigned int p, const cl_I& l, const upvec& u, const vector<ex>& lcU)

 {
        const size_t nu = I.size() + 1;
        const cl_modint_ring R = find_modint_ring(expt_pos(cl_I(p),l));
 {
        const size_t nu = I.size() + 1;
        const cl_modint_ring R = find_modint_ring(expt_pos(cl_I(p),l));


@@ -1604,7 +1761,7 @@ ex hensel_multivar(const ex& a, const ex& x, const vector<EvalPoint>& I, unsigne
        const size_t n = u.size();
        vector<ex> U(n);
        for ( size_t i=0; i<n; ++i ) {
        const size_t n = u.size();
        vector<ex> U(n);
        for ( size_t i=0; i<n; ++i ) {

-               U[i] = umod_to_ex(u[i], x);
+               U[i] = umodpoly_to_ex(u[i], x);

        }
 
        for ( size_t j=2; j<=nu; ++j ) {
        }
 
        for ( size_t j=2; j<=nu; ++j ) {


@@ -1687,13 +1844,11 @@ static ex put_factors_into_lst(const ex& e)
        if ( is_a<power>(e) ) {
                result.append(1);
                result.append(e.op(0));
        if ( is_a<power>(e) ) {
                result.append(1);
                result.append(e.op(0));

-               result.append(e.op(1));

                return result;
        }
        if ( is_a<symbol>(e) || is_a<add>(e) ) {
                result.append(1);
                result.append(e);
                return result;
        }
        if ( is_a<symbol>(e) || is_a<add>(e) ) {
                result.append(1);
                result.append(e);

-               result.append(1);

                return result;
        }
        if ( is_a<mul>(e) ) {
                return result;
        }
        if ( is_a<mul>(e) ) {


@@ -1705,11 +1860,9 @@ static ex put_factors_into_lst(const ex& e)
                        }
                        if ( is_a<power>(op) ) {
                                result.append(op.op(0));
                        }
                        if ( is_a<power>(op) ) {
                                result.append(op.op(0));

-                               result.append(op.op(1));

                        }
                        if ( is_a<symbol>(op) || is_a<add>(op) ) {
                                result.append(op);
                        }
                        if ( is_a<symbol>(op) || is_a<add>(op) ) {
                                result.append(op);

-                               result.append(1);

                        }
                }
                result.prepend(nfac);
                        }
                }
                result.prepend(nfac);


@@ -1728,15 +1881,18 @@ ostream& operator<<(ostream& o, const vector<numeric>& v)
 }
 #endif // def DEBUGFACTOR
 
 }
 #endif // def DEBUGFACTOR
 

-static bool checkdivisors(const lst& f, vector<numeric>& d)
+/** Checks whether in a set of numbers each has a unique prime factor.
+ *
+ *  @param[in]  f  list of numbers to check
+ *  @return        true: if number set is bad, false: otherwise
+ */
+static bool checkdivisors(const lst& f)

 {
 {

-       const int k = f.nops()-2;
+       const int k = f.nops();

        numeric q, r;
        numeric q, r;

-       d[0] = ex_to<numeric>(f.op(0) * f.op(f.nops()-1));
-       if ( d[0] == 1 && k == 1 && abs(f.op(1)) != 1 ) {
-               return false;
-       }
-       for ( int i=1; i<=k; ++i ) {
+       vector<numeric> d(k);
+       d[0] = ex_to<numeric>(abs(f.op(0)));
+       for ( int i=1; i<k; ++i ) {

                q = ex_to<numeric>(abs(f.op(i)));
                for ( int j=i-1; j>=0; --j ) {
                        r = d[j];
                q = ex_to<numeric>(abs(f.op(i)));
                for ( int j=i-1; j>=0; --j ) {
                        r = d[j];


@@ -1753,13 +1909,30 @@ static bool checkdivisors(const lst& f, vector<numeric>& d)
        return false;
 }
 
        return false;
 }
 

-static bool generate_set(const ex& u, const ex& vn, const exset& syms, const ex& f, const numeric& modulus, vector<numeric>& a, vector<numeric>& d)
+/** Generates a set of evaluation points for a multivariate polynomial.
+ *  The set fulfills the following conditions:
+ *  1. lcoeff(evaluated_polynomial) does not vanish
+ *  2. factors of lcoeff(evaluated_polynomial) have each a unique prime factor
+ *  3. evaluated_polynomial is square free
+ *  See [W1] for more details.
+ *
+ *  @param[in]     u        multivariate polynomial to be factored
+ *  @param[in]     vn       leading coefficient of u in x (x==first symbol in syms)
+ *  @param[in]     syms     set of symbols that appear in u
+ *  @param[in]     f        lst containing the factors of the leading coefficient vn
+ *  @param[in,out] modulus  integer modulus for random number generation (i.e. |a_i| < modulus)
+ *  @param[out]    u0       returns the evaluated (univariate) polynomial
+ *  @param[out]    a        returns the valid evaluation points. must have initial size equal
+ *                          number of symbols-1 before calling generate_set
+ */
+static void generate_set(const ex& u, const ex& vn, const exset& syms, const lst& f,
+                         numeric& modulus, ex& u0, vector<numeric>& a)

 {
 {

-       // computation of d is actually not necessary

        const ex& x = *syms.begin();
        const ex& x = *syms.begin();

-       bool trying = true;
-       do {
-               ex u0 = u;
+       while ( true ) {
+               ++modulus;
+               /* generate a set of integers ... */
+               u0 = u;

                ex vna = vn;
                ex vnatry;
                exset::const_iterator s = syms.begin();
                ex vna = vn;
                ex vnatry;
                exset::const_iterator s = syms.begin();


@@ -1768,71 +1941,64 @@ static bool generate_set(const ex& u, const ex& vn, const exset& syms, const ex&
                        do {
                                a[i] = mod(numeric(rand()), 2*modulus) - modulus;
                                vnatry = vna.subs(*s == a[i]);
                        do {
                                a[i] = mod(numeric(rand()), 2*modulus) - modulus;
                                vnatry = vna.subs(*s == a[i]);

+                               /* ... for which the leading coefficient doesn't vanish ... */

                        } while ( vnatry == 0 );
                        vna = vnatry;
                        u0 = u0.subs(*s == a[i]);
                        ++s;
                }
                        } while ( vnatry == 0 );
                        vna = vnatry;
                        u0 = u0.subs(*s == a[i]);
                        ++s;
                }

-               if ( gcd(u0,u0.diff(ex_to<symbol>(x))) != 1 ) {
+               /* ... for which u0 is square free ... */
+               ex g = gcd(u0, u0.diff(ex_to<symbol>(x)));
+               if ( !is_a<numeric>(g) ) {

                        continue;
                }
                        continue;
                }

-               if ( is_a<numeric>(vn) ) {
-                       trying = false;
-               }
-               else {
-                       lst fnum;
-                       lst::const_iterator i = ex_to<lst>(f).begin();
-                       fnum.append(*i++);
-                       bool problem = false;
-                       while ( i!=ex_to<lst>(f).end() ) {
-                               ex fs = *i;
-                               if ( !is_a<numeric>(fs) ) {
+               if ( !is_a<numeric>(vn) ) {
+                       /* ... and for which the evaluated factors have each an unique prime factor */
+                       lst fnum = f;
+                       fnum.let_op(0) = fnum.op(0) * u0.content(x);
+                       for ( size_t i=1; i<fnum.nops(); ++i ) {
+                               if ( !is_a<numeric>(fnum.op(i)) ) {

                                        s = syms.begin();
                                        ++s;
                                        s = syms.begin();
                                        ++s;

-                                       for ( size_t j=0; j<a.size(); ++j ) {
-                                               fs = fs.subs(*s == a[j]);
-                                               ++s;
-                                       }
-                                       if ( abs(fs) == 1 ) {
-                                               problem = true;
-                                               break;
+                                       for ( size_t j=0; j<a.size(); ++j, ++s ) {
+                                               fnum.let_op(i) = fnum.op(i).subs(*s == a[j]);

                                        }
                                }
                                        }
                                }

-                               fnum.append(fs);
-                               ++i; ++i;

                        }
                        }

-                       if ( problem ) {
-                               return true;
+                       if ( checkdivisors(fnum) ) {
+                               continue;

                        }
                        }

-                       ex con = u0.content(x);
-                       fnum.append(con);
-                       trying = checkdivisors(fnum, d);

                }
                }

-       } while ( trying );
-       return false;
+               /* ok, we have a valid set now */
+               return;
+       }

 }
 
 }
 

+// forward declaration
+static ex factor_sqrfree(const ex& poly);
+
+/**
+ *  ASSERT: poly is expanded
+ */

 static ex factor_multivariate(const ex& poly, const exset& syms)
 {
        exset::const_iterator s;
        const ex& x = *syms.begin();
 
        /* make polynomial primitive */
 static ex factor_multivariate(const ex& poly, const exset& syms)
 {
        exset::const_iterator s;
        const ex& x = *syms.begin();
 
        /* make polynomial primitive */

-       ex p = poly.expand().collect(x);
+       ex p = poly.collect(x);

        ex cont = p.lcoeff(x);
        ex cont = p.lcoeff(x);

-       for ( numeric i=p.degree(x)-1; i>=p.ldegree(x); --i ) {
-               cont = gcd(cont, p.coeff(x,ex_to<numeric>(i).to_int()));
+       for ( int i=p.degree(x)-1; i>=p.ldegree(x); --i ) {
+               cont = gcd(cont, p.coeff(x,i));

                if ( cont == 1 ) break;
        }
        ex pp = expand(normal(p / cont));
        if ( !is_a<numeric>(cont) ) {
                if ( cont == 1 ) break;
        }
        ex pp = expand(normal(p / cont));
        if ( !is_a<numeric>(cont) ) {

-               return factor(cont) * factor(pp);
+               return factor_sqrfree(cont) * factor_sqrfree(pp);

        }
 
        /* factor leading coefficient */
        }
 
        /* factor leading coefficient */

-       pp = pp.collect(x);
-       ex vn = pp.lcoeff(x);
-       pp = pp.expand();
+       ex vn = pp.collect(x).lcoeff(x);

        ex vnlst;
        if ( is_a<numeric>(vn) ) {
                vnlst = lst(vn);
        ex vnlst;
        if ( is_a<numeric>(vn) ) {
                vnlst = lst(vn);


@@ -1842,200 +2008,131 @@ static ex factor_multivariate(const ex& poly, const exset& syms)
                vnlst = put_factors_into_lst(vnfactors);
        }
 
                vnlst = put_factors_into_lst(vnfactors);
        }
 

-       const numeric maxtrials = 3;
-       numeric modulus = (vnlst.nops()-1 > 3) ? vnlst.nops()-1 : 3;
-       numeric minimalr = -1;
+       const unsigned int maxtrials = 3;
+       numeric modulus = (vnlst.nops() > 3) ? vnlst.nops() : 3;

        vector<numeric> a(syms.size()-1, 0);
        vector<numeric> a(syms.size()-1, 0);

-       vector<numeric> d((vnlst.nops()-1)/2+1, 0);

 
 

+       /* try now to factorize until we are successful */

        while ( true ) {
        while ( true ) {

-               numeric trialcount = 0;
+
+               unsigned int trialcount = 0;
+               unsigned int prime;
+               int factor_count = 0;
+               int min_factor_count = -1;

                ex u, delta;
                ex u, delta;

-               unsigned int prime = 3;
-               size_t factor_count = 0;
-               ex ufac;
-               ex ufaclst;
+               ex ufac, ufaclst;
+
+               /* try several evaluation points to reduce the number of modular factors */

                while ( trialcount < maxtrials ) {
                while ( trialcount < maxtrials ) {

-                       bool problem = generate_set(pp, vn, syms, vnlst, modulus, a, d);
-                       if ( problem ) {
-                               ++modulus;
-                               continue;
-                       }
-                       u = pp;
-                       s = syms.begin();
-                       ++s;
-                       for ( size_t i=0; i<a.size(); ++i ) {
-                               u = u.subs(*s == a[i]);
-                               ++s;
-                       }
-                       delta = u.content(x);
-
-                       // determine proper prime
-                       prime = 3;
-                       cl_modint_ring R = find_modint_ring(prime);
-                       while ( true ) {
-                               if ( irem(ex_to<numeric>(u.lcoeff(x)), prime) != 0 ) {
-                                       umodpoly modpoly;
-                                       umodpoly_from_ex(modpoly, u, x, R);
-                                       if ( squarefree(modpoly) ) break;
-                               }
-                               prime = next_prime(prime);
-                               R = find_modint_ring(prime);
-                       }

 
 

-                       ufac = factor(u);
+                       /* generate a set of valid evaluation points */
+                       generate_set(pp, vn, syms, ex_to<lst>(vnlst), modulus, u, a);
+
+                       ufac = factor_univariate(u, x, prime);

                        ufaclst = put_factors_into_lst(ufac);
                        ufaclst = put_factors_into_lst(ufac);

-                       factor_count = (ufaclst.nops()-1)/2;
-
-                       // veto factorization for which gcd(u_i, u_j) != 1 for all i,j
-                       upvec tryu;
-                       for ( size_t i=0; i<(ufaclst.nops()-1)/2; ++i ) {
-                               umodpoly newu;
-                               umodpoly_from_ex(newu, ufaclst.op(i*2+1), x, R);
-                               tryu.push_back(newu);
-                       }
-                       bool veto = false;
-                       for ( size_t i=0; i<tryu.size()-1; ++i ) {
-                               for ( size_t j=i+1; j<tryu.size(); ++j ) {
-                                       umodpoly tryg;
-                                       gcd(tryu[i], tryu[j], tryg);
-                                       if ( unequal_one(tryg) ) {
-                                               veto = true;
-                                               goto escape_quickly;
-                                       }
-                               }
-                       }
-                       escape_quickly: ;
-                       if ( veto ) {
-                               continue;
-                       }
+                       factor_count = ufaclst.nops()-1;
+                       delta = ufaclst.op(0);

 
                        if ( factor_count <= 1 ) {
 
                        if ( factor_count <= 1 ) {

+                               /* irreducible */

                                return poly;
                        }
                                return poly;
                        }

-
-                       if ( minimalr < 0 ) {
-                               minimalr = factor_count;
+                       if ( min_factor_count < 0 ) {
+                               /* first time here */
+                               min_factor_count = factor_count;

                        }
                        }

-                       else if ( minimalr == factor_count ) {
+                       else if ( min_factor_count == factor_count ) {
+                               /* one less to try */

                                ++trialcount;
                                ++trialcount;

-                               ++modulus;

                        }
                        }

-                       else if ( minimalr > factor_count ) {
-                               minimalr = factor_count;
+                       else if ( min_factor_count > factor_count ) {
+                               /* new minimum, reset trial counter */
+                               min_factor_count = factor_count;

                                trialcount = 0;
                        }
                                trialcount = 0;
                        }

-                       if ( minimalr <= 1 ) {
-                               return poly;
-                       }

                }
 
                }
 

-               vector<numeric> ftilde((vnlst.nops()-1)/2+1);
-               ftilde[0] = ex_to<numeric>(vnlst.op(0));
-               for ( size_t i=1; i<ftilde.size(); ++i ) {
-                       ex ft = vnlst.op((i-1)*2+1);
-                       s = syms.begin();
-                       ++s;
-                       for ( size_t j=0; j<a.size(); ++j ) {
-                               ft = ft.subs(*s == a[j]);
-                               ++s;
+               // determine true leading coefficients for the Hensel lifting
+               vector<ex> C(factor_count);
+               if ( is_a<numeric>(vn) ) {
+                       for ( size_t i=1; i<ufaclst.nops(); ++i ) {
+                               C[i-1] = ufaclst.op(i).lcoeff(x);

                        }
                        }

-                       ftilde[i] = ex_to<numeric>(ft);

                }
                }

+               else {
+                       vector<numeric> ftilde(vnlst.nops()-1);
+                       for ( size_t i=0; i<ftilde.size(); ++i ) {
+                               ex ft = vnlst.op(i+1);
+                               s = syms.begin();
+                               ++s;
+                               for ( size_t j=0; j<a.size(); ++j ) {
+                                       ft = ft.subs(*s == a[j]);
+                                       ++s;
+                               }
+                               ftilde[i] = ex_to<numeric>(ft);
+                       }

 
 

-               vector<bool> used_flag((vnlst.nops()-1)/2+1, false);
-               vector<ex> D(factor_count, 1);
-               for ( size_t i=0; i<=factor_count; ++i ) {
-                       numeric prefac;
-                       if ( i == 0 ) {
-                               prefac = ex_to<numeric>(ufaclst.op(0));
-                               ftilde[0] = ftilde[0] / prefac;
-                               vnlst.let_op(0) = vnlst.op(0) / prefac;
-                               continue;
+                       vector<bool> used_flag(ftilde.size(), false);
+                       vector<ex> D(factor_count, 1);
+                       if ( delta == 1 ) {
+                               for ( int i=0; i<factor_count; ++i ) {
+                                       numeric prefac = ex_to<numeric>(ufaclst.op(i+1).lcoeff(x));
+                                       for ( int j=ftilde.size()-1; j>=0; --j ) {
+                                               int count = 0;
+                                               while ( irem(prefac, ftilde[j]) == 0 ) {
+                                                       prefac = iquo(prefac, ftilde[j]);
+                                                       ++count;
+                                               }
+                                               if ( count ) {
+                                                       used_flag[j] = true;
+                                                       D[i] = D[i] * pow(vnlst.op(j+1), count);
+                                               }
+                                       }
+                                       C[i] = D[i] * prefac;
+                               }

                        }
                        else {
                        }
                        else {

-                               prefac = ex_to<numeric>(ufaclst.op(2*(i-1)+1).lcoeff(x));
-                       }
-                       for ( size_t j=(vnlst.nops()-1)/2+1; j>0; --j ) {
-                               if ( abs(ftilde[j-1]) == 1 ) {
-                                       used_flag[j-1] = true;
-                                       continue;
-                               }
-                               numeric g = gcd(prefac, ftilde[j-1]);
-                               if ( g != 1 ) {
-                                       prefac = prefac / g;
-                                       numeric count = abs(iquo(g, ftilde[j-1]));
-                                       used_flag[j-1] = true;
-                                       if ( i > 0 ) {
-                                               if ( j == 1 ) {
-                                                       D[i-1] = D[i-1] * pow(vnlst.op(0), count);
+                               for ( int i=0; i<factor_count; ++i ) {
+                                       numeric prefac = ex_to<numeric>(ufaclst.op(i+1).lcoeff(x));
+                                       for ( int j=ftilde.size()-1; j>=0; --j ) {
+                                               int count = 0;
+                                               while ( irem(prefac, ftilde[j]) == 0 ) {
+                                                       prefac = iquo(prefac, ftilde[j]);
+                                                       ++count;

                                                }
                                                }

-                                               else {
-                                                       D[i-1] = D[i-1] * pow(vnlst.op(2*(j-2)+1), count);
+                                               while ( irem(ex_to<numeric>(delta)*prefac, ftilde[j]) == 0 ) {
+                                                       numeric g = gcd(prefac, ex_to<numeric>(ftilde[j]));
+                                                       prefac = iquo(prefac, g);
+                                                       delta = delta / (ftilde[j]/g);
+                                                       ufaclst.let_op(i+1) = ufaclst.op(i+1) * (ftilde[j]/g);
+                                                       ++count;
+                                               }
+                                               if ( count ) {
+                                                       used_flag[j] = true;
+                                                       D[i] = D[i] * pow(vnlst.op(j+1), count);

                                                }
                                        }
                                                }
                                        }

-                                       else {
-                                               ftilde[j-1] = ftilde[j-1] / prefac;
-                                               break;
-                                       }
-                                       ++j;
+                                       C[i] = D[i] * prefac;

                                }
                        }
                                }
                        }

-               }
-
-               bool some_factor_unused = false;
-               for ( size_t i=0; i<used_flag.size(); ++i ) {
-                       if ( !used_flag[i] ) {
-                               some_factor_unused = true;
-                               break;
-                       }
-               }
-               if ( some_factor_unused ) {
-                       continue;
-               }

 
 

-               vector<ex> C(factor_count);
-               if ( delta == 1 ) {
-                       for ( size_t i=0; i<D.size(); ++i ) {
-                               ex Dtilde = D[i];
-                               s = syms.begin();
-                               ++s;
-                               for ( size_t j=0; j<a.size(); ++j ) {
-                                       Dtilde = Dtilde.subs(*s == a[j]);
-                                       ++s;
+                       bool some_factor_unused = false;
+                       for ( size_t i=0; i<used_flag.size(); ++i ) {
+                               if ( !used_flag[i] ) {
+                                       some_factor_unused = true;
+                                       break;

                                }
                                }

-                               C[i] = D[i] * (ufaclst.op(2*i+1).lcoeff(x) / Dtilde);

                        }
                        }

-               }
-               else {
-                       for ( size_t i=0; i<D.size(); ++i ) {
-                               ex Dtilde = D[i];
-                               s = syms.begin();
-                               ++s;
-                               for ( size_t j=0; j<a.size(); ++j ) {
-                                       Dtilde = Dtilde.subs(*s == a[j]);
-                                       ++s;
-                               }
-                               ex ui;
-                               if ( i == 0 ) {
-                                       ui = ufaclst.op(0);
-                               }
-                               else {
-                                       ui = ufaclst.op(2*(i-1)+1);
-                               }
-                               while ( true ) {
-                                       ex d = gcd(ui.lcoeff(x), Dtilde);
-                                       C[i] = D[i] * ( ui.lcoeff(x) / d );
-                                       ui = ui * ( Dtilde[i] / d );
-                                       delta = delta / ( Dtilde[i] / d );
-                                       if ( delta == 1 ) break;
-                                       ui = delta * ui;
-                                       C[i] = delta * C[i];
-                                       pp = pp * pow(delta, D.size()-1);
-                               }
+                       if ( some_factor_unused ) {
+                               continue;

                        }
                }
 
                        }
                }
 

+               if ( delta != 1 ) {
+                       C[0] = C[0] * delta;
+                       ufaclst.let_op(1) = ufaclst.op(1) * delta;
+               }
+

                EvalPoint ep;
                vector<EvalPoint> epv;
                s = syms.begin();
                EvalPoint ep;
                vector<EvalPoint> epv;
                s = syms.begin();


@@ -2046,37 +2143,29 @@ static ex factor_multivariate(const ex& poly, const exset& syms)
                        epv.push_back(ep);
                }
 
                        epv.push_back(ep);
                }
 

-               // calc bound B
-               ex maxcoeff;
-               for ( int i=u.degree(x); i>=u.ldegree(x); --i ) {
-                       maxcoeff += pow(abs(u.coeff(x, i)),2);
-               }
-               cl_I normmc = ceiling1(the<cl_R>(cln::sqrt(ex_to<numeric>(maxcoeff).to_cl_N())));
-               unsigned int maxdegree = 0;
-               for ( size_t i=0; i<factor_count; ++i ) {
-                       if ( ufaclst[2*i+1].degree(x) > (int)maxdegree ) {
-                               maxdegree = ufaclst[2*i+1].degree(x);
+               // calc bound p^l
+               int maxdeg = 0;
+               for ( int i=1; i<=factor_count; ++i ) {
+                       if ( ufaclst.op(i).degree(x) > maxdeg ) {
+                               maxdeg = ufaclst[i].degree(x);

                        }
                }
                        }
                }

-               cl_I B = normmc * expt_pos(cl_I(2), maxdegree);
+               cl_I B = 2*calc_bound(u, x, maxdeg);

                cl_I l = 1;
                cl_I pl = prime;
                while ( pl < B ) {
                        l = l + 1;
                        pl = pl * prime;
                }
                cl_I l = 1;
                cl_I pl = prime;
                while ( pl < B ) {
                        l = l + 1;
                        pl = pl * prime;
                }

-
-               upvec uvec;

                cl_modint_ring R = find_modint_ring(expt_pos(cl_I(prime),l));
                cl_modint_ring R = find_modint_ring(expt_pos(cl_I(prime),l));

-               for ( size_t i=0; i<(ufaclst.nops()-1)/2; ++i ) {
-                       umodpoly newu;
-                       umodpoly_from_ex(newu, ufaclst.op(i*2+1), x, R);
-                       uvec.push_back(newu);
+               upvec modfactors(ufaclst.nops()-1);
+               for ( size_t i=1; i<ufaclst.nops(); ++i ) {
+                       umodpoly_from_ex(modfactors[i-1], ufaclst.op(i), x, R);

                }
 
                }
 

-               ex res = hensel_multivar(ufaclst.op(0)*pp, x, epv, prime, l, uvec, C);
+               ex res = hensel_multivar(pp, x, epv, prime, l, modfactors, C);

                if ( res != lst() ) {
                if ( res != lst() ) {

-                       ex result = cont * ufaclst.op(0);
+                       ex result = cont;

                        for ( size_t i=0; i<res.nops(); ++i ) {
                                result *= res.op(i).content(x) * res.op(i).unit(x);
                                result *= res.op(i).primpart(x);
                        for ( size_t i=0; i<res.nops(); ++i ) {
                                result *= res.op(i).content(x) * res.op(i).unit(x);
                                result *= res.op(i).primpart(x);


@@ -2179,7 +2268,7 @@ ex factor(const ex& poly, unsigned options)
        }
 
        // make poly square free
        }
 
        // make poly square free

-       ex sfpoly = sqrfree(poly, syms);
+       ex sfpoly = sqrfree(poly.expand(), syms);

 
        // factorize the square free components
        if ( is_a<power>(sfpoly) ) {
 
        // factorize the square free components
        if ( is_a<power>(sfpoly) ) {