* these oopses for good, so we run those stupid tests... */
/*
- * GiNaC Copyright (C) 1999-2000 Johannes Gutenberg University Mainz, Germany
+ * GiNaC Copyright (C) 1999-2003 Johannes Gutenberg University Mainz, Germany
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
// The very first pair of historic problems had its roots in power.cpp and was
// finally resolved on April 27th 1999. (Fixing the first on April 23rd
// actually introduced the second.)
-static unsigned exam_paranoia1(void)
+static unsigned exam_paranoia1()
{
unsigned result = 0;
symbol x("x"), y("y"), z("z");
// In the first one expand did not do any job at all:
if (!g.expand().is_equal(x)) {
clog << "e = x*y*z; f = y*z; expand(e/f) erroneously returned "
- << g.expand() << endl;
+ << g.expand() << endl;
++result;
}
e = pow(x + 1, -1);
if (!e.expand().is_equal(e)) {
clog << "expand(pow(x + 1, -1)) erroneously returned "
- << e.expand() << endl;
+ << e.expand() << endl;
++result;
}
// And here the second oops which showed up until May 17th 1999. It had to do
// with lexicographic canonicalization and thus showed up only if the variables
// had the names as given here:
-static unsigned exam_paranoia2(void)
+static unsigned exam_paranoia2()
{
unsigned result = 0;
symbol x("x"), y("y"), z("z");
// After .expand(), g should be zero:
if (!g.expand().is_zero()) {
clog << "e = (x + z*x); f = e*y; expand(f - e*y) erroneously returned "
- << g.expand() << endl;
+ << g.expand() << endl;
++result;
}
// After .eval(), g should be zero:
if (!g.eval().is_zero()) {
clog << "e = (x + z*x); f = e*y; eval(f - e*y) erroneously returned "
- << g.eval() << endl;
+ << g.eval() << endl;
++result;
}
// This actually worked already back in April 1999.
// But we are *very* paranoic!
if (!g.expand().eval().is_zero()) {
clog << "e = (x + z*x); f = e*y; eval(expand(f - e*y)) erroneously returned "
- << g.expand().eval() << endl;
+ << g.expand().eval() << endl;
++result;
}
// The third bug was introduced on May 18th 1999, discovered on May 19 and
// fixed that same day. It worked when x was substituted by 1 but not with
// other numbers:
-static unsigned exam_paranoia3(void)
+static unsigned exam_paranoia3()
{
unsigned result = 0;
symbol x("x"), y("y");
if (!f.is_equal(y)) {
clog << "e = x*y - y; f = e.subs(x == 2) erroneously returned "
- << f << endl;
+ << f << endl;
++result;
}
if (!f.eval().is_equal(y)) {
clog << "e = x*y - y; eval(e.subs(x == 2)) erroneously returned "
- << f.eval() << endl;
+ << f.eval() << endl;
++result;
}
if (!f.expand().is_equal(y)) {
clog << "e = x*y - y; expand(e.subs(x == 2)) erroneously returned "
- << f.expand() << endl;
+ << f.expand() << endl;
++result;
}
}
// The fourth bug was also discovered on May 19th 1999 and fixed immediately:
-static unsigned exam_paranoia4(void)
+static unsigned exam_paranoia4()
{
unsigned result = 0;
symbol x("x");
if (!g.is_zero()) {
clog << "e = pow(x,2) + x + 1; f = pow(x,2) + x + 1; g = e-f; g erroneously returned "
- << g << endl;
+ << g << endl;
++result;
}
if (!g.is_zero()) {
clog << "e = pow(x,2) + x + 1; f = pow(x,2) + x + 1; g = e-f; g.eval() erroneously returned "
- << g.eval() << endl;
+ << g.eval() << endl;
++result;
}
}
// The fifth oops was discovered on May 20th 1999 and fixed a day later:
-static unsigned exam_paranoia5(void)
+static unsigned exam_paranoia5()
{
unsigned result = 0;
symbol x("x"), y("y");
if (!(e-f).expand().is_zero()) {
clog << "e = pow(x*y+1,2); f = pow(x,2)*pow(y,2) + 2*x*y + 1; (e-f).expand() erroneously returned "
- << (e-f).expand() << endl;
+ << (e-f).expand() << endl;
++result;
}
}
// This one was discovered on Jun 1st 1999 and fixed the same day:
-static unsigned exam_paranoia6(void)
+static unsigned exam_paranoia6()
{
unsigned result = 0;
symbol x("x");
// This one was introduced on June 1st 1999 by some aggressive manual
// optimization. Discovered and fixed on June 2nd.
-static unsigned exam_paranoia7(void)
+static unsigned exam_paranoia7()
{
unsigned result = 0;
symbol x("x"), y("y");
if (f.nops() > 3) {
clog << "e=y+y*x+2; f=expand(pow(e,2)-(e*y*(x+1))) has "
- << f.nops() << " arguments instead of 3 ( f=="
- << f << " )" << endl;
+ << f.nops() << " arguments instead of 3 ( f=="
+ << f << " )" << endl;
++result;
}
return result;
// This one was a result of the rewrite of mul::max_coefficient when we
// introduced the overall_coefficient field in expairseq objects on Oct 1st
// 1999. Fixed on Oct 4th.
-static unsigned exam_paranoia8(void)
+static unsigned exam_paranoia8()
{
unsigned result = 0;
symbol x("x");
// Z[X]. multiply_lcm() forgot to multiply the x-linear term with the LCM of
// the coefficient's denominators (2 in this case). Introduced on Jan 25th
// 2000 and fixed on Jan 31th.
-static unsigned exam_paranoia9(void)
+static unsigned exam_paranoia9()
{
unsigned result = 0;
symbol x("x");
// and on Feb 13th 2000 I found out that things like 2^(3/2) throw an exception
// "power::eval(): pow(0,0) is undefined" instead of simplifying to 2*2^(1/2).
// It was fixed that same day.
-static unsigned exam_paranoia10(void)
+static unsigned exam_paranoia10()
{
unsigned result = 0;
// add::normal() forgot to multiply the denominator of the overall_coeff of
// its expanded and normalized children with the denominator of the expanded
// child (did you get this? Well, never mind...). Fixed on Feb 21th 2000.
-static unsigned exam_paranoia11(void)
+static unsigned exam_paranoia11()
{
unsigned result = 0;
symbol x("x");
// This one returned 0 because add::normal() incorrectly assumed that if the
// common denominator is 1, all the denominators would be 1 (they can in fact
// be +/-1). Fixed on Aug 2nd 2000.
-static unsigned exam_paranoia12(void)
+static unsigned exam_paranoia12()
{
unsigned result = 0;
symbol x("x");
if (!(f - d).expand().is_zero()) {
clog << "normal(" << e << ") returns " << f
- << " instead of " << d << endl;
+ << " instead of " << d << endl;
++result;
}
return result;
// This one caused a division by 0 because heur_gcd() didn't check its
// input polynomials against 0. Fixed on Aug 4th 2000.
-static unsigned exam_paranoia13(void)
+static unsigned exam_paranoia13()
{
unsigned result = 0;
symbol a("a"), b("b"), c("c");
ex f = e.normal();
if (!(f - d).expand().is_zero()) {
clog << "normal(" << e << ") returns " << f
- << " instead of " << d << endl;
+ << " instead of " << d << endl;
++result;
}
} catch (const exception &err) {
return result;
}
-unsigned exam_paranoia(void)
+// A bug introduced on July 19, 2001. quo() and rem() would sometimes call
+// vector::reserve() with a negative argument. Fixed on Dec 20, 2001.
+static unsigned exam_paranoia14()
+{
+ unsigned result = 0;
+ symbol x("x");
+
+ ex q = quo(1, pow(x, 3), x);
+ if (!q.is_zero()) {
+ clog << "quo(1,x^3,x) erroneously returned " << q << " instead of 0\n";
+ ++result;
+ }
+
+ return result;
+}
+
+// Under certain conditions, power::expand_add_2() could produce non-canonical
+// numeric expairs. Fixed on Oct 24, 2002.
+static unsigned exam_paranoia15()
+{
+ unsigned result = 0;
+
+ ex q = (pow(pow(2, numeric(1, 2))*2+1, 2)).expand();
+ // this used to produce "1+4*sqrt(2)+4*2" which would never evaluate
+ // to "9+4*sqrt(2)"
+
+ if (!(q-9-4*pow(2, numeric(1, 2))).is_zero()) {
+ clog << "expand((sqrt(2)*2+1)^2) erroneously returned " << q << " instead of 9-4*sqrt(2)\n";
+ ++result;
+ }
+
+ return result;
+}
+
+// Expanding products containing powers of sums could return results that
+// were not fully expanded. Fixed on Dec 10, 2003.
+static unsigned exam_paranoia16()
+{
+ unsigned result = 0;
+ symbol a("a"), b("b"), c("c"), d("d"), e("e");
+ ex e1, e2, e3;
+
+ e1 = pow(1+a*sqrt(b+c), 2);
+ e2 = e1.expand();
+
+ if (e2.has(pow(a, 2)*(b+c))) {
+ clog << "expand(" << e1 << ") didn't fully expand\n";
+ ++result;
+ }
+
+ e1 = (d*sqrt(a+b)+a*sqrt(c+d))*(b*sqrt(a+b)+a*sqrt(c+d));
+ e2 = e1.expand();
+
+ if (e2.has(pow(a, 2)*(c+d))) {
+ clog << "expand(" << e1 << ") didn't fully expand\n";
+ ++result;
+ }
+
+ e1 = (a+sqrt(b+c))*sqrt(b+c)*(d+sqrt(b+c));
+ e2 = e1.expand();
+
+ if (e2.has(a*(b+c))) {
+ clog << "expand(" << e1 << ") didn't fully expand\n";
+ ++result;
+ }
+
+ e1 = pow(sqrt(a+b)+sqrt(c+d), 3);
+ e2 = e1.expand();
+
+ if (e2.has(3*(a+b)*sqrt(c+d)) || e2.has(3*(c+d)*sqrt(a+b))) {
+ clog << "expand(" << e1 << ") didn't fully expand\n";
+ ++result;
+ }
+
+ e1 = a*(b+c*(d+e));
+ e2 = e1.expand();
+
+ if (e2.has(c*(d+e))) {
+ clog << "expand(" << e1 << ") didn't fully expand\n";
+ ++result;
+ }
+
+ e1 = 2*pow(1+a, 2)/a;
+ e2 = e1.expand();
+
+ if (e2.has(pow(a, 2))) {
+ clog << "expand(" << e1 << ") didn't fully expand\n";
+ ++result;
+ }
+
+ e1 = a*(a+b);
+ e2 = pow(pow(e1, -1), -1);
+
+ if (e2.has(a*b)) {
+ clog << "double reciprocal expanded where it should not\n";
+ ++result;
+ }
+
+ return result;
+}
+
+unsigned exam_paranoia()
{
unsigned result = 0;
result += exam_paranoia11(); cout << '.' << flush;
result += exam_paranoia12(); cout << '.' << flush;
result += exam_paranoia13(); cout << '.' << flush;
+ result += exam_paranoia14(); cout << '.' << flush;
+ result += exam_paranoia15(); cout << '.' << flush;
+ result += exam_paranoia16(); cout << '.' << flush;
if (!result) {
cout << " passed " << endl;
git://www.ginac.de / ginac.git / blobdiff