Make sure add::eval() collects all numeric terms.

[ginac.git] / check / exam_paranoia.cpp

diff --git a/check/exam_paranoia.cpp b/check/exam_paranoia.cpp
index 21d40c9aba562e42f11c1df0de304cebff0d2f45..9e6fb015f6b84e05be483d9dde9155e6df62a8e2 100644 (file)
--- a/check/exam_paranoia.cpp
+++ b/check/exam_paranoia.cpp
@@ -6,7 +6,7 @@
  *  these oopses for good, so we run those stupid tests... */
 
 /*
- *  GiNaC Copyright (C) 1999-2003 Johannes Gutenberg University Mainz, Germany
+ *  GiNaC Copyright (C) 1999-2010 Johannes Gutenberg University Mainz, Germany
  *
  *  This program is free software; you can redistribute it and/or modify
  *  it under the terms of the GNU General Public License as published by
@@ -20,10 +20,14 @@
  *
  *  You should have received a copy of the GNU General Public License
  *  along with this program; if not, write to the Free Software
- *  Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
+ *  Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301  USA
  */
 
-#include "exams.h"
+#include "ginac.h"
+using namespace GiNaC;
+
+#include <iostream>
+using namespace std;
 
 // The very first pair of historic problems had its roots in power.cpp and was
 // finally resolved on April 27th 1999. (Fixing the first on April 23rd
@@ -283,7 +287,7 @@ static unsigned exam_paranoia11()
 
        ex e = ((-5-2*x)-((2-5*x)/(-2+x))*(3+2*x))/(5-4*x);
        ex f = e.normal();
-       ex d = (4+10*x+8*pow(x,2))/(x-2)/(5-4*x);
+       ex d = normal((4+10*x+8*pow(x,2))/(x-2)/(5-4*x));
 
        if (!(f - d).expand().is_zero()) {
                clog << "normal(" << e << ") returns " << f << " instead of " << d << endl;
@@ -426,15 +430,61 @@ static unsigned exam_paranoia16()
                ++result;
        }
 
+       e1 = a*(a+b);
+       e2 = pow(pow(e1, -1), -1);
+
+       if (e2.has(a*b)) {
+               clog << "double reciprocal expanded where it should not\n";
+               ++result;
+       }
+
        return result;
 }
 
+// Bug in reposition_dummy_indices() could result in correct expression
+// turned into one with inconsistent indices. Fixed on Aug 29, 2006
+static unsigned exam_paranoia17()
+{
+       varidx mu1(symbol("mu1"), 4);
+       varidx mu2(symbol("mu2"), 4);
+       varidx mu3(symbol("mu3"), 4);
+       varidx mu4(symbol("mu4"), 4);
+       varidx mu5(symbol("mu5"), 4);
+       varidx mu6(symbol("mu6"), 4);
+
+       exvector ev2;
+       ev2.push_back(mu3.toggle_variance());
+       ev2.push_back(mu6);
+       ev2.push_back(mu5.toggle_variance());
+       ev2.push_back(mu6.toggle_variance());
+       ev2.push_back(mu5);
+       ev2.push_back(mu3); 
+       // notice: all indices are contracted ...
+
+       ex test_cycl = indexed(symbol("A"), sy_cycl(), ev2);
+       test_cycl = test_cycl.simplify_indexed();
+       // ... so there should be zero free indices in the end.
+       return test_cycl.get_free_indices().size();
+}
+
+// Bug in add::eval() could result in numeric terms not being collected into
+// the overall coefficient. Fixed on Sep 22, 2010
+static unsigned exam_paranoia18()
+{
+       ex sqrt2 = sqrt(ex(2));
+       ex e = 1+2*(sqrt2+1)*(sqrt2-1);
+       if ( e.real_part() != 3 ) {
+               clog << "real_part(1+2*(sqrt(2)+1)*(sqrt(2)-1)) failed to evaluate to 3\n";
+               return 1;
+       }
+       return 0;
+}
+
 unsigned exam_paranoia()
 {
        unsigned result = 0;
        
        cout << "examining several historic failures just out of paranoia" << flush;
-       clog << "----------several historic failures:" << endl;
        
        result += exam_paranoia1();  cout << '.' << flush;
        result += exam_paranoia2();  cout << '.' << flush;
@@ -452,13 +502,13 @@ unsigned exam_paranoia()
        result += exam_paranoia14();  cout << '.' << flush;
        result += exam_paranoia15();  cout << '.' << flush;
        result += exam_paranoia16();  cout << '.' << flush;
-       
-       if (!result) {
-               cout << " passed " << endl;
-               clog << "(no output)" << endl;
-       } else {
-               cout << " failed " << endl;
-       }
+       result += exam_paranoia17();  cout << '.' << flush;
+       result += exam_paranoia18();  cout << '.' << flush;
        
        return result;
 }
+
+int main(int argc, char** argv)
+{
+       return exam_paranoia();
+}