/** @file parser_bugs.cpp * * Check for some silly bugs in the parser. */ /* * GiNaC Copyright (C) 1999-2024 Johannes Gutenberg University Mainz, Germany * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2 of the License, or * (at your option) any later version. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA */ #include "ginac.h" using namespace GiNaC; #include #include #include #include using namespace std; // - a - b was misparsed as -a + b due to a bug in parser::parse_unary_expr() static int check1(ostream& err_str) { const string srep("-a-b"); parser reader; ex e = reader(srep); ex a = reader.get_syms()["a"]; ex b = reader.get_syms()["b"]; ex g = - a - b; ex d = (e - g).expand(); if (!d.is_zero()) { err_str << "\"" << srep << "\" was misparsed as \"" << e << "\"" << endl; return 1; } return 0; } /// Parser was rejecting the valid expression '5 - (3*x)/10'. static int check2(ostream& err_str) { const string srep("5-(3*x)/10"); parser reader; ex e = reader(srep); ex x = reader.get_syms()["x"]; ex g = 5 - (3*x)/10; ex d = (e - g).expand(); if (!d.is_zero()) { err_str << "\"" << srep << "\" was misparsed as \"" << e << "\"" << endl; return 1; } return 0; } /// parse_literal_expr forget to consume the token, so parser get /// very confused. static int check3(ostream& err_str) { const string srep("5-(2*I)/3"); parser reader; ex e = reader(srep); ex g = numeric(5) - (numeric(2)*I)/3; ex d = (e - g).expand(); if (!d.is_zero()) { err_str << "\"" << srep << "\" was misparsed as \"" << e << "\"" << endl; return 1; } return 0; } /// parser happily accepted various junk like 'x^2()+1' static int check4(ostream& err_str) { const string junk("x^2()+1"); parser reader; ex e; try { e = reader(junk); err_str << "parser accepts junk: \"" << junk << "\"" << endl; return 1; } catch (parse_error& err) { // Ok, parser rejects the nonsense. return 0; } } // Check that two strings parse to equal expressions. static int check_eq(ostream &err_str, parser &reader, const char *expr1, const char *expr2) { const string srep1(expr1); const string srep2(expr2); ex e1, e2; try{ e1 = reader(srep1); } catch (const exception &e) { err_str << "\"" << srep1 << "\" failed to parse: " << e.what() << endl; return 1; } try{ e2 = reader(srep2); } catch (const exception &e) { err_str << "\"" << srep2 << "\" failed to parse: " << e.what() << endl; return 1; } if (!(e1-e2).expand().is_zero()) { err_str << "\"" << srep1 << "\" was misparsed as \"" << e1 << "\"" << endl; return 1; } return 0; } // Tests for the interaction of the '^' operator with // the unary '+' and the unary '-' operators static int check5(ostream& err_str) { parser reader; return +check_eq(err_str, reader, "3^2+1", "10") +check_eq(err_str, reader, "3^+2-1", "8") +check_eq(err_str, reader, "3^-2+1", "10/9") +check_eq(err_str, reader, "3^-2/5", "1/45") +check_eq(err_str, reader, "3^-2*5", "5/9") +check_eq(err_str, reader, "3^-2-5", "-44/9") +check_eq(err_str, reader, "3^(-2)+1", "10/9") +check_eq(err_str, reader, "(3)^(-2)+1", "10/9") +check_eq(err_str, reader, "+3^2+1", "10") +check_eq(err_str, reader, "+3^+2+1", "10") +check_eq(err_str, reader, "+3^-2+1", "10/9") +check_eq(err_str, reader, "+3^-2/5", "1/45") +check_eq(err_str, reader, "+3^-2*5", "5/9") +check_eq(err_str, reader, "+3^-2-5", "-44/9") +check_eq(err_str, reader, "-3^2+1", "-8") +check_eq(err_str, reader, "-3^+2+1", "-8") +check_eq(err_str, reader, "-3^-2+1", "8/9") +check_eq(err_str, reader, "-3^-2/3", "-1/27") +check_eq(err_str, reader, "1+2^3^4", "1+(2^81)") +check_eq(err_str, reader, "2^3^4+1", "1+(2^81)") +check_eq(err_str, reader, "2^+3^4+1", "1+(2^81)") +check_eq(err_str, reader, "2^3^+4+1", "1+(2^81)"); } // Tests for the interaction of the '*' operator with // the unary '+' and the unary '-' operators static int check6(ostream& err_str) { parser reader; return +check_eq(err_str, reader, "3*+2-1", "5") +check_eq(err_str, reader, "3*2+1", "7") +check_eq(err_str, reader, "3*+2+1", "7") +check_eq(err_str, reader, "3*-2+1", "-5") +check_eq(err_str, reader, "3*-2/5", "-6/5") +check_eq(err_str, reader, "3*-2*5", "-30") +check_eq(err_str, reader, "3*-2-5", "-11") +check_eq(err_str, reader, "3*(-2)+1", "-5") +check_eq(err_str, reader, "(3)*(-2)+1", "-5") +check_eq(err_str, reader, "+3*2+1", "7") +check_eq(err_str, reader, "+3*+2+1", "7") +check_eq(err_str, reader, "+3*-2+1", "-5") +check_eq(err_str, reader, "+3*-2/5", "-6/5") +check_eq(err_str, reader, "+3*-2*5", "-30") +check_eq(err_str, reader, "+3*-2-5", "-11") +check_eq(err_str, reader, "-3*2+1", "-5") +check_eq(err_str, reader, "-3*+2+1", "-5") +check_eq(err_str, reader, "-3*-2+1", "7") +check_eq(err_str, reader, "-3*-2/3", "2") +check_eq(err_str, reader, "1+2*3*4", "25") +check_eq(err_str, reader, "2*3*4+1", "25") +check_eq(err_str, reader, "2*+3*4+1", "25") +check_eq(err_str, reader, "2*3*+4+1", "25"); } // Tests for nested unary + and unary - static int check7(ostream& err_str) { parser reader; return +check_eq(err_str, reader, "+1", "1") +check_eq(err_str, reader, "++1", "1") +check_eq(err_str, reader, "+-+1", "-1") +check_eq(err_str, reader, "+-+-1", "1") +check_eq(err_str, reader, "+-+-+1", "1") +check_eq(err_str, reader, "100++--+1+10", "111"); } int main(int argc, char** argv) { cout << "examining old parser bugs" << flush; ostringstream err_str; int errors = 0; errors += check1(err_str); cout << '.' << flush; errors += check2(err_str); cout << '.' << flush; errors += check3(err_str); cout << '.' << flush; errors += check4(err_str); cout << '.' << flush; errors += check5(err_str); cout << '.' << flush; errors += check6(err_str); cout << '.' << flush; errors += check7(err_str); cout << '.' << flush; if (errors) { cout << "Yes, unfortunately:" << endl; cout << err_str.str(); } else { cout << "Not found. "; } return errors; }