3 * Polynomial factorization (implementation).
5 * The interface function factor() at the end of this file is defined in the
6 * GiNaC namespace. All other utility functions and classes are defined in an
7 * additional anonymous namespace.
9 * Factorization starts by doing a square free factorization and making the
10 * coefficients integer. Then, depending on the number of free variables it
11 * proceeds either in dedicated univariate or multivariate factorization code.
13 * Univariate factorization does a modular factorization via Berlekamp's
14 * algorithm and distinct degree factorization. Hensel lifting is used at the
17 * Multivariate factorization uses the univariate factorization (applying a
18 * evaluation homomorphism first) and Hensel lifting raises the answer to the
19 * multivariate domain. The Hensel lifting code is completely distinct from the
20 * code used by the univariate factorization.
22 * Algorithms used can be found in
23 * [Wan] An Improved Multivariate Polynomial Factoring Algorithm,
25 * Mathematics of Computation, Vol. 32, No. 144 (1978) 1215--1231.
26 * [GCL] Algorithms for Computer Algebra,
27 * K.O.Geddes, S.R.Czapor, G.Labahn,
28 * Springer Verlag, 1992.
29 * [Mig] Some Useful Bounds,
31 * In "Computer Algebra, Symbolic and Algebraic Computation" (B.Buchberger et al., eds.),
32 * pp. 259-263, Springer-Verlag, New York, 1982.
36 * GiNaC Copyright (C) 1999-2015 Johannes Gutenberg University Mainz, Germany
38 * This program is free software; you can redistribute it and/or modify
39 * it under the terms of the GNU General Public License as published by
40 * the Free Software Foundation; either version 2 of the License, or
41 * (at your option) any later version.
43 * This program is distributed in the hope that it will be useful,
44 * but WITHOUT ANY WARRANTY; without even the implied warranty of
45 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
46 * GNU General Public License for more details.
48 * You should have received a copy of the GNU General Public License
49 * along with this program; if not, write to the Free Software
50 * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
59 #include "operators.h"
62 #include "relational.h"
84 #define DCOUT(str) cout << #str << endl
85 #define DCOUTVAR(var) cout << #var << ": " << var << endl
86 #define DCOUT2(str,var) cout << #str << ": " << var << endl
87 ostream& operator<<(ostream& o, const vector<int>& v)
89 auto i = v.begin(), end = v.end();
96 static ostream& operator<<(ostream& o, const vector<cl_I>& v)
98 auto i = v.begin(), end = v.end();
100 o << *i << "[" << i-v.begin() << "]" << " ";
105 static ostream& operator<<(ostream& o, const vector<cl_MI>& v)
107 auto i = v.begin(), end = v.end();
109 o << *i << "[" << i-v.begin() << "]" << " ";
114 ostream& operator<<(ostream& o, const vector<numeric>& v)
116 for ( size_t i=0; i<v.size(); ++i ) {
121 ostream& operator<<(ostream& o, const vector<vector<cl_MI>>& v)
123 auto i = v.begin(), end = v.end();
125 o << i-v.begin() << ": " << *i << endl;
132 #define DCOUTVAR(var)
133 #define DCOUT2(str,var)
134 #endif // def DEBUGFACTOR
136 // anonymous namespace to hide all utility functions
139 ////////////////////////////////////////////////////////////////////////////////
140 // modular univariate polynomial code
142 typedef std::vector<cln::cl_MI> umodpoly;
143 typedef std::vector<cln::cl_I> upoly;
144 typedef vector<umodpoly> upvec;
146 // COPY FROM UPOLY.HPP
148 // CHANGED size_t -> int !!!
149 template<typename T> static int degree(const T& p)
154 template<typename T> static typename T::value_type lcoeff(const T& p)
156 return p[p.size() - 1];
159 static bool normalize_in_field(umodpoly& a)
163 if ( lcoeff(a) == a[0].ring()->one() ) {
167 const cln::cl_MI lc_1 = recip(lcoeff(a));
168 for (std::size_t k = a.size(); k-- != 0; )
173 template<typename T> static void
174 canonicalize(T& p, const typename T::size_type hint = std::numeric_limits<typename T::size_type>::max())
179 std::size_t i = p.size() - 1;
180 // Be fast if the polynomial is already canonicalized
187 bool is_zero = false;
205 p.erase(p.begin() + i, p.end());
208 // END COPY FROM UPOLY.HPP
210 static void expt_pos(umodpoly& a, unsigned int q)
212 if ( a.empty() ) return;
213 cl_MI zero = a[0].ring()->zero();
215 a.resize(degree(a)*q+1, zero);
216 for ( int i=deg; i>0; --i ) {
222 template<bool COND, typename T = void> struct enable_if
227 template<typename T> struct enable_if<false, T> { /* empty */ };
229 template<typename T> struct uvar_poly_p
231 static const bool value = false;
234 template<> struct uvar_poly_p<upoly>
236 static const bool value = true;
239 template<> struct uvar_poly_p<umodpoly>
241 static const bool value = true;
245 // Don't define this for anything but univariate polynomials.
246 static typename enable_if<uvar_poly_p<T>::value, T>::type
247 operator+(const T& a, const T& b)
254 for ( ; i<sb; ++i ) {
257 for ( ; i<sa; ++i ) {
266 for ( ; i<sa; ++i ) {
269 for ( ; i<sb; ++i ) {
278 // Don't define this for anything but univariate polynomials. Otherwise
279 // overload resolution might fail (this actually happens when compiling
280 // GiNaC with g++ 3.4).
281 static typename enable_if<uvar_poly_p<T>::value, T>::type
282 operator-(const T& a, const T& b)
289 for ( ; i<sb; ++i ) {
292 for ( ; i<sa; ++i ) {
301 for ( ; i<sa; ++i ) {
304 for ( ; i<sb; ++i ) {
312 static upoly operator*(const upoly& a, const upoly& b)
315 if ( a.empty() || b.empty() ) return c;
317 int n = degree(a) + degree(b);
319 for ( int i=0 ; i<=n; ++i ) {
320 for ( int j=0 ; j<=i; ++j ) {
321 if ( j > degree(a) || (i-j) > degree(b) ) continue;
322 c[i] = c[i] + a[j] * b[i-j];
329 static umodpoly operator*(const umodpoly& a, const umodpoly& b)
332 if ( a.empty() || b.empty() ) return c;
334 int n = degree(a) + degree(b);
335 c.resize(n+1, a[0].ring()->zero());
336 for ( int i=0 ; i<=n; ++i ) {
337 for ( int j=0 ; j<=i; ++j ) {
338 if ( j > degree(a) || (i-j) > degree(b) ) continue;
339 c[i] = c[i] + a[j] * b[i-j];
346 static upoly operator*(const upoly& a, const cl_I& x)
353 for ( size_t i=0; i<a.size(); ++i ) {
359 static upoly operator/(const upoly& a, const cl_I& x)
366 for ( size_t i=0; i<a.size(); ++i ) {
367 r[i] = exquo(a[i],x);
372 static umodpoly operator*(const umodpoly& a, const cl_MI& x)
374 umodpoly r(a.size());
375 for ( size_t i=0; i<a.size(); ++i ) {
382 static void upoly_from_ex(upoly& up, const ex& e, const ex& x)
384 // assert: e is in Z[x]
385 int deg = e.degree(x);
387 int ldeg = e.ldegree(x);
388 for ( ; deg>=ldeg; --deg ) {
389 up[deg] = the<cl_I>(ex_to<numeric>(e.coeff(x, deg)).to_cl_N());
391 for ( ; deg>=0; --deg ) {
397 static void umodpoly_from_upoly(umodpoly& ump, const upoly& e, const cl_modint_ring& R)
401 for ( ; deg>=0; --deg ) {
402 ump[deg] = R->canonhom(e[deg]);
407 static void umodpoly_from_ex(umodpoly& ump, const ex& e, const ex& x, const cl_modint_ring& R)
409 // assert: e is in Z[x]
410 int deg = e.degree(x);
412 int ldeg = e.ldegree(x);
413 for ( ; deg>=ldeg; --deg ) {
414 cl_I coeff = the<cl_I>(ex_to<numeric>(e.coeff(x, deg)).to_cl_N());
415 ump[deg] = R->canonhom(coeff);
417 for ( ; deg>=0; --deg ) {
418 ump[deg] = R->zero();
424 static void umodpoly_from_ex(umodpoly& ump, const ex& e, const ex& x, const cl_I& modulus)
426 umodpoly_from_ex(ump, e, x, find_modint_ring(modulus));
430 static ex upoly_to_ex(const upoly& a, const ex& x)
432 if ( a.empty() ) return 0;
434 for ( int i=degree(a); i>=0; --i ) {
435 e += numeric(a[i]) * pow(x, i);
440 static ex umodpoly_to_ex(const umodpoly& a, const ex& x)
442 if ( a.empty() ) return 0;
443 cl_modint_ring R = a[0].ring();
444 cl_I mod = R->modulus;
445 cl_I halfmod = (mod-1) >> 1;
447 for ( int i=degree(a); i>=0; --i ) {
448 cl_I n = R->retract(a[i]);
450 e += numeric(n-mod) * pow(x, i);
452 e += numeric(n) * pow(x, i);
458 static upoly umodpoly_to_upoly(const umodpoly& a)
461 if ( a.empty() ) return e;
462 cl_modint_ring R = a[0].ring();
463 cl_I mod = R->modulus;
464 cl_I halfmod = (mod-1) >> 1;
465 for ( int i=degree(a); i>=0; --i ) {
466 cl_I n = R->retract(a[i]);
476 static umodpoly umodpoly_to_umodpoly(const umodpoly& a, const cl_modint_ring& R, unsigned int m)
479 if ( a.empty() ) return e;
480 cl_modint_ring oldR = a[0].ring();
481 size_t sa = a.size();
482 e.resize(sa+m, R->zero());
483 for ( size_t i=0; i<sa; ++i ) {
484 e[i+m] = R->canonhom(oldR->retract(a[i]));
490 /** Divides all coefficients of the polynomial a by the integer x.
491 * All coefficients are supposed to be divisible by x. If they are not, the
492 * the<cl_I> cast will raise an exception.
494 * @param[in,out] a polynomial of which the coefficients will be reduced by x
495 * @param[in] x integer that divides the coefficients
497 static void reduce_coeff(umodpoly& a, const cl_I& x)
499 if ( a.empty() ) return;
501 cl_modint_ring R = a[0].ring();
503 // cln cannot perform this division in the modular field
504 cl_I c = R->retract(i);
505 i = cl_MI(R, the<cl_I>(c / x));
509 /** Calculates remainder of a/b.
510 * Assertion: a and b not empty.
512 * @param[in] a polynomial dividend
513 * @param[in] b polynomial divisor
514 * @param[out] r polynomial remainder
516 static void rem(const umodpoly& a, const umodpoly& b, umodpoly& r)
525 cl_MI qk = div(r[n+k], b[n]);
527 for ( int i=0; i<n; ++i ) {
528 unsigned int j = n + k - 1 - i;
529 r[j] = r[j] - qk * b[j-k];
534 fill(r.begin()+n, r.end(), a[0].ring()->zero());
538 /** Calculates quotient of a/b.
539 * Assertion: a and b not empty.
541 * @param[in] a polynomial dividend
542 * @param[in] b polynomial divisor
543 * @param[out] q polynomial quotient
545 static void div(const umodpoly& a, const umodpoly& b, umodpoly& q)
554 q.resize(k+1, a[0].ring()->zero());
556 cl_MI qk = div(r[n+k], b[n]);
559 for ( int i=0; i<n; ++i ) {
560 unsigned int j = n + k - 1 - i;
561 r[j] = r[j] - qk * b[j-k];
569 /** Calculates quotient and remainder of a/b.
570 * Assertion: a and b not empty.
572 * @param[in] a polynomial dividend
573 * @param[in] b polynomial divisor
574 * @param[out] r polynomial remainder
575 * @param[out] q polynomial quotient
577 static void remdiv(const umodpoly& a, const umodpoly& b, umodpoly& r, umodpoly& q)
586 q.resize(k+1, a[0].ring()->zero());
588 cl_MI qk = div(r[n+k], b[n]);
591 for ( int i=0; i<n; ++i ) {
592 unsigned int j = n + k - 1 - i;
593 r[j] = r[j] - qk * b[j-k];
598 fill(r.begin()+n, r.end(), a[0].ring()->zero());
603 /** Calculates the GCD of polynomial a and b.
605 * @param[in] a polynomial
606 * @param[in] b polynomial
609 static void gcd(const umodpoly& a, const umodpoly& b, umodpoly& c)
611 if ( degree(a) < degree(b) ) return gcd(b, a, c);
614 normalize_in_field(c);
616 normalize_in_field(d);
618 while ( !d.empty() ) {
623 normalize_in_field(c);
626 /** Calculates the derivative of the polynomial a.
628 * @param[in] a polynomial of which to take the derivative
629 * @param[out] d result/derivative
631 static void deriv(const umodpoly& a, umodpoly& d)
634 if ( a.size() <= 1 ) return;
636 d.insert(d.begin(), a.begin()+1, a.end());
638 for ( int i=1; i<max; ++i ) {
644 static bool unequal_one(const umodpoly& a)
646 if ( a.empty() ) return true;
647 return ( a.size() != 1 || a[0] != a[0].ring()->one() );
650 static bool equal_one(const umodpoly& a)
652 return ( a.size() == 1 && a[0] == a[0].ring()->one() );
655 /** Returns true if polynomial a is square free.
657 * @param[in] a polynomial to check
658 * @return true if polynomial is square free, false otherwise
660 static bool squarefree(const umodpoly& a)
672 // END modular univariate polynomial code
673 ////////////////////////////////////////////////////////////////////////////////
675 ////////////////////////////////////////////////////////////////////////////////
678 typedef vector<cl_MI> mvec;
682 friend ostream& operator<<(ostream& o, const modular_matrix& m);
684 modular_matrix(size_t r_, size_t c_, const cl_MI& init) : r(r_), c(c_)
688 size_t rowsize() const { return r; }
689 size_t colsize() const { return c; }
690 cl_MI& operator()(size_t row, size_t col) { return m[row*c + col]; }
691 cl_MI operator()(size_t row, size_t col) const { return m[row*c + col]; }
692 void mul_col(size_t col, const cl_MI x)
694 for ( size_t rc=0; rc<r; ++rc ) {
695 std::size_t i = c*rc + col;
699 void sub_col(size_t col1, size_t col2, const cl_MI fac)
701 for ( size_t rc=0; rc<r; ++rc ) {
702 std::size_t i1 = col1 + c*rc;
703 std::size_t i2 = col2 + c*rc;
704 m[i1] = m[i1] - m[i2]*fac;
707 void switch_col(size_t col1, size_t col2)
709 for ( size_t rc=0; rc<r; ++rc ) {
710 std::size_t i1 = col1 + rc*c;
711 std::size_t i2 = col2 + rc*c;
712 std::swap(m[i1], m[i2]);
715 void mul_row(size_t row, const cl_MI x)
717 for ( size_t cc=0; cc<c; ++cc ) {
718 std::size_t i = row*c + cc;
722 void sub_row(size_t row1, size_t row2, const cl_MI fac)
724 for ( size_t cc=0; cc<c; ++cc ) {
725 std::size_t i1 = row1*c + cc;
726 std::size_t i2 = row2*c + cc;
727 m[i1] = m[i1] - m[i2]*fac;
730 void switch_row(size_t row1, size_t row2)
732 for ( size_t cc=0; cc<c; ++cc ) {
733 std::size_t i1 = row1*c + cc;
734 std::size_t i2 = row2*c + cc;
735 std::swap(m[i1], m[i2]);
738 bool is_col_zero(size_t col) const
740 for ( size_t rr=0; rr<r; ++rr ) {
741 std::size_t i = col + rr*c;
742 if ( !zerop(m[i]) ) {
748 bool is_row_zero(size_t row) const
750 for ( size_t cc=0; cc<c; ++cc ) {
751 std::size_t i = row*c + cc;
752 if ( !zerop(m[i]) ) {
758 void set_row(size_t row, const vector<cl_MI>& newrow)
760 for (std::size_t i2 = 0; i2 < newrow.size(); ++i2) {
761 std::size_t i1 = row*c + i2;
765 mvec::const_iterator row_begin(size_t row) const { return m.begin()+row*c; }
766 mvec::const_iterator row_end(size_t row) const { return m.begin()+row*c+r; }
773 modular_matrix operator*(const modular_matrix& m1, const modular_matrix& m2)
775 const unsigned int r = m1.rowsize();
776 const unsigned int c = m2.colsize();
777 modular_matrix o(r,c,m1(0,0));
779 for ( size_t i=0; i<r; ++i ) {
780 for ( size_t j=0; j<c; ++j ) {
782 buf = m1(i,0) * m2(0,j);
783 for ( size_t k=1; k<c; ++k ) {
784 buf = buf + m1(i,k)*m2(k,j);
792 ostream& operator<<(ostream& o, const modular_matrix& m)
794 cl_modint_ring R = m(0,0).ring();
796 for ( size_t i=0; i<m.rowsize(); ++i ) {
798 for ( size_t j=0; j<m.colsize()-1; ++j ) {
799 o << R->retract(m(i,j)) << ",";
801 o << R->retract(m(i,m.colsize()-1)) << "}";
802 if ( i != m.rowsize()-1 ) {
809 #endif // def DEBUGFACTOR
811 // END modular matrix
812 ////////////////////////////////////////////////////////////////////////////////
814 /** Calculates the Q matrix for a polynomial. Used by Berlekamp's algorithm.
816 * @param[in] a_ modular polynomial
817 * @param[out] Q Q matrix
819 static void q_matrix(const umodpoly& a_, modular_matrix& Q)
822 normalize_in_field(a);
825 unsigned int q = cl_I_to_uint(a[0].ring()->modulus);
826 umodpoly r(n, a[0].ring()->zero());
827 r[0] = a[0].ring()->one();
829 unsigned int max = (n-1) * q;
830 for ( size_t m=1; m<=max; ++m ) {
831 cl_MI rn_1 = r.back();
832 for ( size_t i=n-1; i>0; --i ) {
833 r[i] = r[i-1] - (rn_1 * a[i]);
836 if ( (m % q) == 0 ) {
842 /** Determine the nullspace of a matrix M-1.
844 * @param[in,out] M matrix, will be modified
845 * @param[out] basis calculated nullspace of M-1
847 static void nullspace(modular_matrix& M, vector<mvec>& basis)
849 const size_t n = M.rowsize();
850 const cl_MI one = M(0,0).ring()->one();
851 for ( size_t i=0; i<n; ++i ) {
852 M(i,i) = M(i,i) - one;
854 for ( size_t r=0; r<n; ++r ) {
856 for ( ; cc<n; ++cc ) {
857 if ( !zerop(M(r,cc)) ) {
859 if ( !zerop(M(cc,cc)) ) {
871 M.mul_col(r, recip(M(r,r)));
872 for ( cc=0; cc<n; ++cc ) {
874 M.sub_col(cc, r, M(r,cc));
880 for ( size_t i=0; i<n; ++i ) {
881 M(i,i) = M(i,i) - one;
883 for ( size_t i=0; i<n; ++i ) {
884 if ( !M.is_row_zero(i) ) {
885 mvec nu(M.row_begin(i), M.row_end(i));
891 /** Berlekamp's modular factorization.
893 * The implementation follows the algorithm in chapter 8 of [GCL].
895 * @param[in] a modular polynomial
896 * @param[out] upv vector containing modular factors. if upv was not empty the
897 * new elements are added at the end
899 static void berlekamp(const umodpoly& a, upvec& upv)
901 cl_modint_ring R = a[0].ring();
902 umodpoly one(1, R->one());
904 // find nullspace of Q matrix
905 modular_matrix Q(degree(a), degree(a), R->zero());
910 const unsigned int k = nu.size();
916 list<umodpoly> factors;
917 factors.push_back(a);
918 unsigned int size = 1;
920 unsigned int q = cl_I_to_uint(R->modulus);
922 list<umodpoly>::iterator u = factors.begin();
924 // calculate all gcd's
926 for ( unsigned int s=0; s<q; ++s ) {
927 umodpoly nur = nu[r];
928 nur[0] = nur[0] - cl_MI(R, s);
932 if ( unequal_one(g) && g != *u ) {
935 if ( equal_one(uo) ) {
936 throw logic_error("berlekamp: unexpected divisor.");
941 factors.push_back(g);
943 for (auto & i : factors) {
948 for (auto & i : factors) {
962 // modular square free factorization is not used at the moment so we deactivate
966 /** Calculates a^(1/prime).
968 * @param[in] a polynomial
969 * @param[in] prime prime number -> exponent 1/prime
970 * @param[in] ap resulting polynomial
972 static void expt_1_over_p(const umodpoly& a, unsigned int prime, umodpoly& ap)
974 size_t newdeg = degree(a)/prime;
977 for ( size_t i=1; i<=newdeg; ++i ) {
982 /** Modular square free factorization.
984 * @param[in] a polynomial
985 * @param[out] factors modular factors
986 * @param[out] mult corresponding multiplicities (exponents)
988 static void modsqrfree(const umodpoly& a, upvec& factors, vector<int>& mult)
990 const unsigned int prime = cl_I_to_uint(a[0].ring()->modulus);
999 while ( unequal_one(w) ) {
1004 factors.push_back(z);
1012 if ( unequal_one(c) ) {
1014 expt_1_over_p(c, prime, cp);
1015 size_t previ = mult.size();
1016 modsqrfree(cp, factors, mult);
1017 for ( size_t i=previ; i<mult.size(); ++i ) {
1024 expt_1_over_p(a, prime, ap);
1025 size_t previ = mult.size();
1026 modsqrfree(ap, factors, mult);
1027 for ( size_t i=previ; i<mult.size(); ++i ) {
1033 #endif // deactivation of square free factorization
1035 /** Distinct degree factorization (DDF).
1037 * The implementation follows the algorithm in chapter 8 of [GCL].
1039 * @param[in] a_ modular polynomial
1040 * @param[out] degrees vector containing the degrees of the factors of the
1041 * corresponding polynomials in ddfactors.
1042 * @param[out] ddfactors vector containing polynomials which factors have the
1043 * degree given in degrees.
1045 static void distinct_degree_factor(const umodpoly& a_, vector<int>& degrees, upvec& ddfactors)
1049 cl_modint_ring R = a[0].ring();
1050 int q = cl_I_to_int(R->modulus);
1051 int nhalf = degree(a)/2;
1059 while ( i <= nhalf ) {
1064 umodpoly wx = w - x;
1066 if ( unequal_one(buf) ) {
1067 degrees.push_back(i);
1068 ddfactors.push_back(buf);
1070 if ( unequal_one(buf) ) {
1074 nhalf = degree(a)/2;
1080 if ( unequal_one(a) ) {
1081 degrees.push_back(degree(a));
1082 ddfactors.push_back(a);
1086 /** Modular same degree factorization.
1087 * Same degree factorization is a kind of misnomer. It performs distinct degree
1088 * factorization, but instead of using the Cantor-Zassenhaus algorithm it
1089 * (sub-optimally) uses Berlekamp's algorithm for the factors of the same
1092 * @param[in] a modular polynomial
1093 * @param[out] upv vector containing modular factors. if upv was not empty the
1094 * new elements are added at the end
1096 static void same_degree_factor(const umodpoly& a, upvec& upv)
1098 cl_modint_ring R = a[0].ring();
1100 vector<int> degrees;
1102 distinct_degree_factor(a, degrees, ddfactors);
1104 for ( size_t i=0; i<degrees.size(); ++i ) {
1105 if ( degrees[i] == degree(ddfactors[i]) ) {
1106 upv.push_back(ddfactors[i]);
1109 berlekamp(ddfactors[i], upv);
1114 // Yes, we can (choose).
1115 #define USE_SAME_DEGREE_FACTOR
1117 /** Modular univariate factorization.
1119 * In principle, we have two algorithms at our disposal: Berlekamp's algorithm
1120 * and same degree factorization (SDF). SDF seems to be slightly faster in
1121 * almost all cases so it is activated as default.
1123 * @param[in] p modular polynomial
1124 * @param[out] upv vector containing modular factors. if upv was not empty the
1125 * new elements are added at the end
1127 static void factor_modular(const umodpoly& p, upvec& upv)
1129 #ifdef USE_SAME_DEGREE_FACTOR
1130 same_degree_factor(p, upv);
1136 /** Calculates modular polynomials s and t such that a*s+b*t==1.
1137 * Assertion: a and b are relatively prime and not zero.
1139 * @param[in] a polynomial
1140 * @param[in] b polynomial
1141 * @param[out] s polynomial
1142 * @param[out] t polynomial
1144 static void exteuclid(const umodpoly& a, const umodpoly& b, umodpoly& s, umodpoly& t)
1146 if ( degree(a) < degree(b) ) {
1147 exteuclid(b, a, t, s);
1151 umodpoly one(1, a[0].ring()->one());
1152 umodpoly c = a; normalize_in_field(c);
1153 umodpoly d = b; normalize_in_field(d);
1161 umodpoly r = c - q * d;
1162 umodpoly r1 = s - q * d1;
1163 umodpoly r2 = t - q * d2;
1167 if ( r.empty() ) break;
1172 cl_MI fac = recip(lcoeff(a) * lcoeff(c));
1173 for (auto & i : s) {
1177 fac = recip(lcoeff(b) * lcoeff(c));
1178 for (auto & i : t) {
1184 /** Replaces the leading coefficient in a polynomial by a given number.
1186 * @param[in] poly polynomial to change
1187 * @param[in] lc new leading coefficient
1188 * @return changed polynomial
1190 static upoly replace_lc(const upoly& poly, const cl_I& lc)
1192 if ( poly.empty() ) return poly;
1198 /** Calculates the bound for the modulus.
1201 static inline cl_I calc_bound(const ex& a, const ex& x, int maxdeg)
1205 for ( int i=a.degree(x); i>=a.ldegree(x); --i ) {
1206 cl_I aa = abs(the<cl_I>(ex_to<numeric>(a.coeff(x, i)).to_cl_N()));
1207 if ( aa > maxcoeff ) maxcoeff = aa;
1208 coeff = coeff + square(aa);
1210 cl_I coeffnorm = ceiling1(the<cl_R>(cln::sqrt(coeff)));
1211 cl_I B = coeffnorm * expt_pos(cl_I(2), cl_I(maxdeg));
1212 return ( B > maxcoeff ) ? B : maxcoeff;
1215 /** Calculates the bound for the modulus.
1218 static inline cl_I calc_bound(const upoly& a, int maxdeg)
1222 for ( int i=degree(a); i>=0; --i ) {
1223 cl_I aa = abs(a[i]);
1224 if ( aa > maxcoeff ) maxcoeff = aa;
1225 coeff = coeff + square(aa);
1227 cl_I coeffnorm = ceiling1(the<cl_R>(cln::sqrt(coeff)));
1228 cl_I B = coeffnorm * expt_pos(cl_I(2), cl_I(maxdeg));
1229 return ( B > maxcoeff ) ? B : maxcoeff;
1232 /** Hensel lifting as used by factor_univariate().
1234 * The implementation follows the algorithm in chapter 6 of [GCL].
1236 * @param[in] a_ primitive univariate polynomials
1237 * @param[in] p prime number that does not divide lcoeff(a)
1238 * @param[in] u1_ modular factor of a (mod p)
1239 * @param[in] w1_ modular factor of a (mod p), relatively prime to u1_,
1240 * fulfilling u1_*w1_ == a mod p
1241 * @param[out] u lifted factor
1242 * @param[out] w lifted factor, u*w = a
1244 static void hensel_univar(const upoly& a_, unsigned int p, const umodpoly& u1_, const umodpoly& w1_, upoly& u, upoly& w)
1247 const cl_modint_ring& R = u1_[0].ring();
1250 int maxdeg = (degree(u1_) > degree(w1_)) ? degree(u1_) : degree(w1_);
1251 cl_I maxmodulus = 2*calc_bound(a, maxdeg);
1254 cl_I alpha = lcoeff(a);
1257 normalize_in_field(nu1);
1259 normalize_in_field(nw1);
1261 phi = umodpoly_to_upoly(nu1) * alpha;
1263 umodpoly_from_upoly(u1, phi, R);
1264 phi = umodpoly_to_upoly(nw1) * alpha;
1266 umodpoly_from_upoly(w1, phi, R);
1271 exteuclid(u1, w1, s, t);
1274 u = replace_lc(umodpoly_to_upoly(u1), alpha);
1275 w = replace_lc(umodpoly_to_upoly(w1), alpha);
1276 upoly e = a - u * w;
1280 while ( !e.empty() && modulus < maxmodulus ) {
1281 upoly c = e / modulus;
1282 phi = umodpoly_to_upoly(s) * c;
1283 umodpoly sigmatilde;
1284 umodpoly_from_upoly(sigmatilde, phi, R);
1285 phi = umodpoly_to_upoly(t) * c;
1287 umodpoly_from_upoly(tautilde, phi, R);
1289 remdiv(sigmatilde, w1, r, q);
1291 phi = umodpoly_to_upoly(tautilde) + umodpoly_to_upoly(q) * umodpoly_to_upoly(u1);
1293 umodpoly_from_upoly(tau, phi, R);
1294 u = u + umodpoly_to_upoly(tau) * modulus;
1295 w = w + umodpoly_to_upoly(sigma) * modulus;
1297 modulus = modulus * p;
1303 for ( size_t i=1; i<u.size(); ++i ) {
1305 if ( g == 1 ) break;
1320 /** Returns a new prime number.
1322 * @param[in] p prime number
1323 * @return next prime number after p
1325 static unsigned int next_prime(unsigned int p)
1327 static vector<unsigned int> primes;
1328 if ( primes.size() == 0 ) {
1329 primes.push_back(3); primes.push_back(5); primes.push_back(7);
1331 if ( p >= primes.back() ) {
1332 unsigned int candidate = primes.back() + 2;
1334 size_t n = primes.size()/2;
1335 for ( size_t i=0; i<n; ++i ) {
1336 if ( candidate % primes[i] ) continue;
1340 primes.push_back(candidate);
1341 if ( candidate > p ) break;
1345 for (auto & it : primes) {
1350 throw logic_error("next_prime: should not reach this point!");
1353 /** Manages the splitting a vector of of modular factors into two partitions.
1355 class factor_partition
1358 /** Takes the vector of modular factors and initializes the first partition */
1359 factor_partition(const upvec& factors_) : factors(factors_)
1365 one.resize(1, factors.front()[0].ring()->one());
1370 int operator[](size_t i) const { return k[i]; }
1371 size_t size() const { return n; }
1372 size_t size_left() const { return n-len; }
1373 size_t size_right() const { return len; }
1374 /** Initializes the next partition.
1375 Returns true, if there is one, false otherwise. */
1378 if ( last == n-1 ) {
1388 while ( k[last] == 0 ) { --last; }
1389 if ( last == 0 && n == 2*len ) return false;
1391 for ( size_t i=0; i<=len-rem; ++i ) {
1395 fill(k.begin()+last, k.end(), 0);
1402 if ( len > n/2 ) return false;
1403 fill(k.begin(), k.begin()+len, 1);
1404 fill(k.begin()+len+1, k.end(), 0);
1413 /** Get first partition */
1414 umodpoly& left() { return lr[0]; }
1415 /** Get second partition */
1416 umodpoly& right() { return lr[1]; }
1425 while ( i < n && k[i] == group ) { ++d; ++i; }
1427 if ( cache[pos].size() >= d ) {
1428 lr[group] = lr[group] * cache[pos][d-1];
1431 if ( cache[pos].size() == 0 ) {
1432 cache[pos].push_back(factors[pos] * factors[pos+1]);
1434 size_t j = pos + cache[pos].size() + 1;
1435 d -= cache[pos].size();
1437 umodpoly buf = cache[pos].back() * factors[j];
1438 cache[pos].push_back(buf);
1442 lr[group] = lr[group] * cache[pos].back();
1446 lr[group] = lr[group] * factors[pos];
1458 for ( size_t i=0; i<n; ++i ) {
1459 lr[k[i]] = lr[k[i]] * factors[i];
1465 vector<vector<umodpoly>> cache;
1474 /** Contains a pair of univariate polynomial and its modular factors.
1475 * Used by factor_univariate().
1483 /** Univariate polynomial factorization.
1485 * Modular factorization is tried for several primes to minimize the number of
1486 * modular factors. Then, Hensel lifting is performed.
1488 * @param[in] poly expanded square free univariate polynomial
1489 * @param[in] x symbol
1490 * @param[in,out] prime prime number to start trying modular factorization with,
1491 * output value is the prime number actually used
1493 static ex factor_univariate(const ex& poly, const ex& x, unsigned int& prime)
1495 ex unit, cont, prim_ex;
1496 poly.unitcontprim(x, unit, cont, prim_ex);
1498 upoly_from_ex(prim, prim_ex, x);
1500 // determine proper prime and minimize number of modular factors
1502 unsigned int lastp = prime;
1504 unsigned int trials = 0;
1505 unsigned int minfactors = 0;
1507 const numeric& cont_n = ex_to<numeric>(cont);
1509 if (cont_n.is_integer()) {
1510 i_cont = the<cl_I>(cont_n.to_cl_N());
1512 // poly \in Q[x] => poly = q ipoly, ipoly \in Z[x], q \in Q
1513 // factor(poly) \equiv q factor(ipoly)
1516 cl_I lc = lcoeff(prim)*i_cont;
1518 while ( trials < 2 ) {
1521 prime = next_prime(prime);
1522 if ( !zerop(rem(lc, prime)) ) {
1523 R = find_modint_ring(prime);
1524 umodpoly_from_upoly(modpoly, prim, R);
1525 if ( squarefree(modpoly) ) break;
1529 // do modular factorization
1531 factor_modular(modpoly, trialfactors);
1532 if ( trialfactors.size() <= 1 ) {
1533 // irreducible for sure
1537 if ( minfactors == 0 || trialfactors.size() < minfactors ) {
1538 factors = trialfactors;
1539 minfactors = trialfactors.size();
1548 R = find_modint_ring(prime);
1550 // lift all factor combinations
1551 stack<ModFactors> tocheck;
1554 mf.factors = factors;
1558 while ( tocheck.size() ) {
1559 const size_t n = tocheck.top().factors.size();
1560 factor_partition part(tocheck.top().factors);
1562 // call Hensel lifting
1563 hensel_univar(tocheck.top().poly, prime, part.left(), part.right(), f1, f2);
1564 if ( !f1.empty() ) {
1565 // successful, update the stack and the result
1566 if ( part.size_left() == 1 ) {
1567 if ( part.size_right() == 1 ) {
1568 result *= upoly_to_ex(f1, x) * upoly_to_ex(f2, x);
1572 result *= upoly_to_ex(f1, x);
1573 tocheck.top().poly = f2;
1574 for ( size_t i=0; i<n; ++i ) {
1575 if ( part[i] == 0 ) {
1576 tocheck.top().factors.erase(tocheck.top().factors.begin()+i);
1582 else if ( part.size_right() == 1 ) {
1583 if ( part.size_left() == 1 ) {
1584 result *= upoly_to_ex(f1, x) * upoly_to_ex(f2, x);
1588 result *= upoly_to_ex(f2, x);
1589 tocheck.top().poly = f1;
1590 for ( size_t i=0; i<n; ++i ) {
1591 if ( part[i] == 1 ) {
1592 tocheck.top().factors.erase(tocheck.top().factors.begin()+i);
1599 upvec newfactors1(part.size_left()), newfactors2(part.size_right());
1600 auto i1 = newfactors1.begin(), i2 = newfactors2.begin();
1601 for ( size_t i=0; i<n; ++i ) {
1603 *i2++ = tocheck.top().factors[i];
1606 *i1++ = tocheck.top().factors[i];
1609 tocheck.top().factors = newfactors1;
1610 tocheck.top().poly = f1;
1612 mf.factors = newfactors2;
1620 if ( !part.next() ) {
1621 // if no more combinations left, return polynomial as
1623 result *= upoly_to_ex(tocheck.top().poly, x);
1631 return unit * cont * result;
1634 /** Second interface to factor_univariate() to be used if the information about
1635 * the prime is not needed.
1637 static inline ex factor_univariate(const ex& poly, const ex& x)
1640 return factor_univariate(poly, x, prime);
1643 /** Represents an evaluation point (<symbol>==<integer>).
1652 ostream& operator<<(ostream& o, const vector<EvalPoint>& v)
1654 for ( size_t i=0; i<v.size(); ++i ) {
1655 o << "(" << v[i].x << "==" << v[i].evalpoint << ") ";
1659 #endif // def DEBUGFACTOR
1661 // forward declaration
1662 static vector<ex> multivar_diophant(const vector<ex>& a_, const ex& x, const ex& c, const vector<EvalPoint>& I, unsigned int d, unsigned int p, unsigned int k);
1664 /** Utility function for multivariate Hensel lifting.
1666 * Solves the equation
1667 * s_1*b_1 + ... + s_r*b_r == 1 mod p^k
1668 * with deg(s_i) < deg(a_i)
1669 * and with given b_1 = a_1 * ... * a_{i-1} * a_{i+1} * ... * a_r
1671 * The implementation follows the algorithm in chapter 6 of [GCL].
1673 * @param[in] a vector of modular univariate polynomials
1674 * @param[in] x symbol
1675 * @param[in] p prime number
1676 * @param[in] k p^k is modulus
1677 * @return vector of polynomials (s_i)
1679 static upvec multiterm_eea_lift(const upvec& a, const ex& x, unsigned int p, unsigned int k)
1681 const size_t r = a.size();
1682 cl_modint_ring R = find_modint_ring(expt_pos(cl_I(p),k));
1685 for ( size_t j=r-2; j>=1; --j ) {
1686 q[j-1] = a[j] * q[j];
1688 umodpoly beta(1, R->one());
1690 for ( size_t j=1; j<r; ++j ) {
1691 vector<ex> mdarg(2);
1692 mdarg[0] = umodpoly_to_ex(q[j-1], x);
1693 mdarg[1] = umodpoly_to_ex(a[j-1], x);
1694 vector<EvalPoint> empty;
1695 vector<ex> exsigma = multivar_diophant(mdarg, x, umodpoly_to_ex(beta, x), empty, 0, p, k);
1697 umodpoly_from_ex(sigma1, exsigma[0], x, R);
1699 umodpoly_from_ex(sigma2, exsigma[1], x, R);
1701 s.push_back(sigma2);
1707 /** Changes the modulus of a modular polynomial. Used by eea_lift().
1709 * @param[in] R new modular ring
1710 * @param[in,out] a polynomial to change (in situ)
1712 static void change_modulus(const cl_modint_ring& R, umodpoly& a)
1714 if ( a.empty() ) return;
1715 cl_modint_ring oldR = a[0].ring();
1716 for (auto & i : a) {
1717 i = R->canonhom(oldR->retract(i));
1722 /** Utility function for multivariate Hensel lifting.
1724 * Solves s*a + t*b == 1 mod p^k given a,b.
1726 * The implementation follows the algorithm in chapter 6 of [GCL].
1728 * @param[in] a polynomial
1729 * @param[in] b polynomial
1730 * @param[in] x symbol
1731 * @param[in] p prime number
1732 * @param[in] k p^k is modulus
1733 * @param[out] s_ output polynomial
1734 * @param[out] t_ output polynomial
1736 static void eea_lift(const umodpoly& a, const umodpoly& b, const ex& x, unsigned int p, unsigned int k, umodpoly& s_, umodpoly& t_)
1738 cl_modint_ring R = find_modint_ring(p);
1740 change_modulus(R, amod);
1742 change_modulus(R, bmod);
1746 exteuclid(amod, bmod, smod, tmod);
1748 cl_modint_ring Rpk = find_modint_ring(expt_pos(cl_I(p),k));
1750 change_modulus(Rpk, s);
1752 change_modulus(Rpk, t);
1755 umodpoly one(1, Rpk->one());
1756 for ( size_t j=1; j<k; ++j ) {
1757 umodpoly e = one - a * s - b * t;
1758 reduce_coeff(e, modulus);
1760 change_modulus(R, c);
1761 umodpoly sigmabar = smod * c;
1762 umodpoly taubar = tmod * c;
1764 remdiv(sigmabar, bmod, sigma, q);
1765 umodpoly tau = taubar + q * amod;
1766 umodpoly sadd = sigma;
1767 change_modulus(Rpk, sadd);
1768 cl_MI modmodulus(Rpk, modulus);
1769 s = s + sadd * modmodulus;
1770 umodpoly tadd = tau;
1771 change_modulus(Rpk, tadd);
1772 t = t + tadd * modmodulus;
1773 modulus = modulus * p;
1779 /** Utility function for multivariate Hensel lifting.
1781 * Solves the equation
1782 * s_1*b_1 + ... + s_r*b_r == x^m mod p^k
1783 * with given b_1 = a_1 * ... * a_{i-1} * a_{i+1} * ... * a_r
1785 * The implementation follows the algorithm in chapter 6 of [GCL].
1787 * @param a vector with univariate polynomials mod p^k
1789 * @param m exponent of x^m in the equation to solve
1790 * @param p prime number
1791 * @param k p^k is modulus
1792 * @return vector of polynomials (s_i)
1794 static upvec univar_diophant(const upvec& a, const ex& x, unsigned int m, unsigned int p, unsigned int k)
1796 cl_modint_ring R = find_modint_ring(expt_pos(cl_I(p),k));
1798 const size_t r = a.size();
1801 upvec s = multiterm_eea_lift(a, x, p, k);
1802 for ( size_t j=0; j<r; ++j ) {
1803 umodpoly bmod = umodpoly_to_umodpoly(s[j], R, m);
1805 rem(bmod, a[j], buf);
1806 result.push_back(buf);
1811 eea_lift(a[1], a[0], x, p, k, s, t);
1812 umodpoly bmod = umodpoly_to_umodpoly(s, R, m);
1814 remdiv(bmod, a[0], buf, q);
1815 result.push_back(buf);
1816 umodpoly t1mod = umodpoly_to_umodpoly(t, R, m);
1817 buf = t1mod + q * a[1];
1818 result.push_back(buf);
1824 /** Map used by function make_modular().
1825 * Finds every coefficient in a polynomial and replaces it by is value in the
1826 * given modular ring R (symmetric representation).
1828 struct make_modular_map : public map_function {
1830 make_modular_map(const cl_modint_ring& R_) : R(R_) { }
1831 ex operator()(const ex& e)
1833 if ( is_a<add>(e) || is_a<mul>(e) ) {
1834 return e.map(*this);
1836 else if ( is_a<numeric>(e) ) {
1837 numeric mod(R->modulus);
1838 numeric halfmod = (mod-1)/2;
1839 cl_MI emod = R->canonhom(the<cl_I>(ex_to<numeric>(e).to_cl_N()));
1840 numeric n(R->retract(emod));
1841 if ( n > halfmod ) {
1852 /** Helps mimicking modular multivariate polynomial arithmetic.
1854 * @param e expression of which to make the coefficients equal to their value
1855 * in the modular ring R (symmetric representation)
1856 * @param R modular ring
1857 * @return resulting expression
1859 static ex make_modular(const ex& e, const cl_modint_ring& R)
1861 make_modular_map map(R);
1862 return map(e.expand());
1865 /** Utility function for multivariate Hensel lifting.
1867 * Returns the polynomials s_i that fulfill
1868 * s_1*b_1 + ... + s_r*b_r == c mod <I^(d+1),p^k>
1869 * with given b_1 = a_1 * ... * a_{i-1} * a_{i+1} * ... * a_r
1871 * The implementation follows the algorithm in chapter 6 of [GCL].
1873 * @param a_ vector of multivariate factors mod p^k
1874 * @param x symbol (equiv. x_1 in [GCL])
1875 * @param c polynomial mod p^k
1876 * @param I vector of evaluation points
1877 * @param d maximum total degree of result
1878 * @param p prime number
1879 * @param k p^k is modulus
1880 * @return vector of polynomials (s_i)
1882 static vector<ex> multivar_diophant(const vector<ex>& a_, const ex& x, const ex& c, const vector<EvalPoint>& I,
1883 unsigned int d, unsigned int p, unsigned int k)
1887 const cl_modint_ring R = find_modint_ring(expt_pos(cl_I(p),k));
1888 const size_t r = a.size();
1889 const size_t nu = I.size() + 1;
1893 ex xnu = I.back().x;
1894 int alphanu = I.back().evalpoint;
1897 for ( size_t i=0; i<r; ++i ) {
1901 for ( size_t i=0; i<r; ++i ) {
1902 b[i] = normal(A / a[i]);
1905 vector<ex> anew = a;
1906 for ( size_t i=0; i<r; ++i ) {
1907 anew[i] = anew[i].subs(xnu == alphanu);
1909 ex cnew = c.subs(xnu == alphanu);
1910 vector<EvalPoint> Inew = I;
1912 sigma = multivar_diophant(anew, x, cnew, Inew, d, p, k);
1915 for ( size_t i=0; i<r; ++i ) {
1916 buf -= sigma[i] * b[i];
1918 ex e = make_modular(buf, R);
1921 for ( size_t m=1; !e.is_zero() && e.has(xnu) && m<=d; ++m ) {
1922 monomial *= (xnu - alphanu);
1923 monomial = expand(monomial);
1924 ex cm = e.diff(ex_to<symbol>(xnu), m).subs(xnu==alphanu) / factorial(m);
1925 cm = make_modular(cm, R);
1926 if ( !cm.is_zero() ) {
1927 vector<ex> delta_s = multivar_diophant(anew, x, cm, Inew, d, p, k);
1929 for ( size_t j=0; j<delta_s.size(); ++j ) {
1930 delta_s[j] *= monomial;
1931 sigma[j] += delta_s[j];
1932 buf -= delta_s[j] * b[j];
1934 e = make_modular(buf, R);
1940 for ( size_t i=0; i<a.size(); ++i ) {
1942 umodpoly_from_ex(up, a[i], x, R);
1946 sigma.insert(sigma.begin(), r, 0);
1949 if ( is_a<add>(c) ) {
1957 for ( size_t i=0; i<nterms; ++i ) {
1958 int m = z.degree(x);
1959 cl_I cm = the<cl_I>(ex_to<numeric>(z.lcoeff(x)).to_cl_N());
1960 upvec delta_s = univar_diophant(amod, x, m, p, k);
1963 while ( poscm < 0 ) {
1964 poscm = poscm + expt_pos(cl_I(p),k);
1966 modcm = cl_MI(R, poscm);
1967 for ( size_t j=0; j<delta_s.size(); ++j ) {
1968 delta_s[j] = delta_s[j] * modcm;
1969 sigma[j] = sigma[j] + umodpoly_to_ex(delta_s[j], x);
1977 for ( size_t i=0; i<sigma.size(); ++i ) {
1978 sigma[i] = make_modular(sigma[i], R);
1984 /** Multivariate Hensel lifting.
1985 * The implementation follows the algorithm in chapter 6 of [GCL].
1986 * Since we don't have a data type for modular multivariate polynomials, the
1987 * respective operations are done in a GiNaC::ex and the function
1988 * make_modular() is then called to make the coefficient modular p^l.
1990 * @param a multivariate polynomial primitive in x
1991 * @param x symbol (equiv. x_1 in [GCL])
1992 * @param I vector of evaluation points (x_2==a_2,x_3==a_3,...)
1993 * @param p prime number (should not divide lcoeff(a mod I))
1994 * @param l p^l is the modulus of the lifted univariate field
1995 * @param u vector of modular (mod p^l) factors of a mod I
1996 * @param lcU correct leading coefficient of the univariate factors of a mod I
1997 * @return list GiNaC::lst with lifted factors (multivariate factors of a),
1998 * empty if Hensel lifting did not succeed
2000 static ex hensel_multivar(const ex& a, const ex& x, const vector<EvalPoint>& I,
2001 unsigned int p, const cl_I& l, const upvec& u, const vector<ex>& lcU)
2003 const size_t nu = I.size() + 1;
2004 const cl_modint_ring R = find_modint_ring(expt_pos(cl_I(p),l));
2009 for ( size_t j=nu; j>=2; --j ) {
2011 int alpha = I[j-2].evalpoint;
2012 A[j-2] = A[j-1].subs(x==alpha);
2013 A[j-2] = make_modular(A[j-2], R);
2016 int maxdeg = a.degree(I.front().x);
2017 for ( size_t i=1; i<I.size(); ++i ) {
2018 int maxdeg2 = a.degree(I[i].x);
2019 if ( maxdeg2 > maxdeg ) maxdeg = maxdeg2;
2022 const size_t n = u.size();
2024 for ( size_t i=0; i<n; ++i ) {
2025 U[i] = umodpoly_to_ex(u[i], x);
2028 for ( size_t j=2; j<=nu; ++j ) {
2031 for ( size_t m=0; m<n; ++m) {
2032 if ( lcU[m] != 1 ) {
2034 for ( size_t i=j-1; i<nu-1; ++i ) {
2035 coef = coef.subs(I[i].x == I[i].evalpoint);
2037 coef = make_modular(coef, R);
2038 int deg = U[m].degree(x);
2039 U[m] = U[m] - U[m].lcoeff(x) * pow(x,deg) + coef * pow(x,deg);
2043 for ( size_t i=0; i<n; ++i ) {
2046 ex e = expand(A[j-1] - Uprod);
2048 vector<EvalPoint> newI;
2049 for ( size_t i=1; i<=j-2; ++i ) {
2050 newI.push_back(I[i-1]);
2054 int alphaj = I[j-2].evalpoint;
2055 size_t deg = A[j-1].degree(xj);
2056 for ( size_t k=1; k<=deg; ++k ) {
2057 if ( !e.is_zero() ) {
2058 monomial *= (xj - alphaj);
2059 monomial = expand(monomial);
2060 ex dif = e.diff(ex_to<symbol>(xj), k);
2061 ex c = dif.subs(xj==alphaj) / factorial(k);
2062 if ( !c.is_zero() ) {
2063 vector<ex> deltaU = multivar_diophant(U1, x, c, newI, maxdeg, p, cl_I_to_uint(l));
2064 for ( size_t i=0; i<n; ++i ) {
2065 deltaU[i] *= monomial;
2067 U[i] = make_modular(U[i], R);
2070 for ( size_t i=0; i<n; ++i ) {
2074 e = make_modular(e, R);
2081 for ( size_t i=0; i<U.size(); ++i ) {
2084 if ( expand(a-acand).is_zero() ) {
2086 for ( size_t i=0; i<U.size(); ++i ) {
2097 /** Takes a factorized expression and puts the factors in a lst. The exponents
2098 * of the factors are discarded, e.g. 7*x^2*(y+1)^4 --> {7,x,y+1}. The first
2099 * element of the list is always the numeric coefficient.
2101 static ex put_factors_into_lst(const ex& e)
2104 if ( is_a<numeric>(e) ) {
2108 if ( is_a<power>(e) ) {
2110 result.append(e.op(0));
2113 if ( is_a<symbol>(e) || is_a<add>(e) ) {
2114 ex icont(e.integer_content());
2115 result.append(icont);
2116 result.append(e/icont);
2119 if ( is_a<mul>(e) ) {
2121 for ( size_t i=0; i<e.nops(); ++i ) {
2123 if ( is_a<numeric>(op) ) {
2126 if ( is_a<power>(op) ) {
2127 result.append(op.op(0));
2129 if ( is_a<symbol>(op) || is_a<add>(op) ) {
2133 result.prepend(nfac);
2136 throw runtime_error("put_factors_into_lst: bad term.");
2139 /** Checks a set of numbers for whether each number has a unique prime factor.
2141 * @param[in] f list of numbers to check
2142 * @return true: if number set is bad, false: if set is okay (has unique
2145 static bool checkdivisors(const lst& f)
2147 const int k = f.nops();
2149 vector<numeric> d(k);
2150 d[0] = ex_to<numeric>(abs(f.op(0)));
2151 for ( int i=1; i<k; ++i ) {
2152 q = ex_to<numeric>(abs(f.op(i)));
2153 for ( int j=i-1; j>=0; --j ) {
2168 /** Generates a set of evaluation points for a multivariate polynomial.
2169 * The set fulfills the following conditions:
2170 * 1. lcoeff(evaluated_polynomial) does not vanish
2171 * 2. factors of lcoeff(evaluated_polynomial) have each a unique prime factor
2172 * 3. evaluated_polynomial is square free
2173 * See [Wan] for more details.
2175 * @param[in] u multivariate polynomial to be factored
2176 * @param[in] vn leading coefficient of u in x (x==first symbol in syms)
2177 * @param[in] syms set of symbols that appear in u
2178 * @param[in] f lst containing the factors of the leading coefficient vn
2179 * @param[in,out] modulus integer modulus for random number generation (i.e. |a_i| < modulus)
2180 * @param[out] u0 returns the evaluated (univariate) polynomial
2181 * @param[out] a returns the valid evaluation points. must have initial size equal
2182 * number of symbols-1 before calling generate_set
2184 static void generate_set(const ex& u, const ex& vn, const exset& syms, const lst& f,
2185 numeric& modulus, ex& u0, vector<numeric>& a)
2187 const ex& x = *syms.begin();
2190 // generate a set of integers ...
2194 exset::const_iterator s = syms.begin();
2196 for ( size_t i=0; i<a.size(); ++i ) {
2198 a[i] = mod(numeric(rand()), 2*modulus) - modulus;
2199 vnatry = vna.subs(*s == a[i]);
2200 // ... for which the leading coefficient doesn't vanish ...
2201 } while ( vnatry == 0 );
2203 u0 = u0.subs(*s == a[i]);
2206 // ... for which u0 is square free ...
2207 ex g = gcd(u0, u0.diff(ex_to<symbol>(x)));
2208 if ( !is_a<numeric>(g) ) {
2211 if ( !is_a<numeric>(vn) ) {
2212 // ... and for which the evaluated factors have each an unique prime factor
2214 fnum.let_op(0) = fnum.op(0) * u0.content(x);
2215 for ( size_t i=1; i<fnum.nops(); ++i ) {
2216 if ( !is_a<numeric>(fnum.op(i)) ) {
2219 for ( size_t j=0; j<a.size(); ++j, ++s ) {
2220 fnum.let_op(i) = fnum.op(i).subs(*s == a[j]);
2224 if ( checkdivisors(fnum) ) {
2228 // ok, we have a valid set now
2233 // forward declaration
2234 static ex factor_sqrfree(const ex& poly);
2236 /** Multivariate factorization.
2238 * The implementation is based on the algorithm described in [Wan].
2239 * An evaluation homomorphism (a set of integers) is determined that fulfills
2240 * certain criteria. The evaluated polynomial is univariate and is factorized
2241 * by factor_univariate(). The main work then is to find the correct leading
2242 * coefficients of the univariate factors. They have to correspond to the
2243 * factors of the (multivariate) leading coefficient of the input polynomial
2244 * (as defined for a specific variable x). After that the Hensel lifting can be
2247 * @param[in] poly expanded, square free polynomial
2248 * @param[in] syms contains the symbols in the polynomial
2249 * @return factorized polynomial
2251 static ex factor_multivariate(const ex& poly, const exset& syms)
2253 exset::const_iterator s;
2254 const ex& x = *syms.begin();
2256 // make polynomial primitive
2258 poly.unitcontprim(x, unit, cont, pp);
2259 if ( !is_a<numeric>(cont) ) {
2260 return factor_sqrfree(cont) * factor_sqrfree(pp);
2263 // factor leading coefficient
2264 ex vn = pp.collect(x).lcoeff(x);
2266 if ( is_a<numeric>(vn) ) {
2270 ex vnfactors = factor(vn);
2271 vnlst = put_factors_into_lst(vnfactors);
2274 const unsigned int maxtrials = 3;
2275 numeric modulus = (vnlst.nops() > 3) ? vnlst.nops() : 3;
2276 vector<numeric> a(syms.size()-1, 0);
2278 // try now to factorize until we are successful
2281 unsigned int trialcount = 0;
2283 int factor_count = 0;
2284 int min_factor_count = -1;
2288 // try several evaluation points to reduce the number of factors
2289 while ( trialcount < maxtrials ) {
2291 // generate a set of valid evaluation points
2292 generate_set(pp, vn, syms, ex_to<lst>(vnlst), modulus, u, a);
2294 ufac = factor_univariate(u, x, prime);
2295 ufaclst = put_factors_into_lst(ufac);
2296 factor_count = ufaclst.nops()-1;
2297 delta = ufaclst.op(0);
2299 if ( factor_count <= 1 ) {
2303 if ( min_factor_count < 0 ) {
2305 min_factor_count = factor_count;
2307 else if ( min_factor_count == factor_count ) {
2311 else if ( min_factor_count > factor_count ) {
2312 // new minimum, reset trial counter
2313 min_factor_count = factor_count;
2318 // determine true leading coefficients for the Hensel lifting
2319 vector<ex> C(factor_count);
2320 if ( is_a<numeric>(vn) ) {
2322 for ( size_t i=1; i<ufaclst.nops(); ++i ) {
2323 C[i-1] = ufaclst.op(i).lcoeff(x);
2328 // we use the property of the ftilde having a unique prime factor.
2329 // details can be found in [Wan].
2331 vector<numeric> ftilde(vnlst.nops()-1);
2332 for ( size_t i=0; i<ftilde.size(); ++i ) {
2333 ex ft = vnlst.op(i+1);
2336 for ( size_t j=0; j<a.size(); ++j ) {
2337 ft = ft.subs(*s == a[j]);
2340 ftilde[i] = ex_to<numeric>(ft);
2342 // calculate D and C
2343 vector<bool> used_flag(ftilde.size(), false);
2344 vector<ex> D(factor_count, 1);
2346 for ( int i=0; i<factor_count; ++i ) {
2347 numeric prefac = ex_to<numeric>(ufaclst.op(i+1).lcoeff(x));
2348 for ( int j=ftilde.size()-1; j>=0; --j ) {
2350 while ( irem(prefac, ftilde[j]) == 0 ) {
2351 prefac = iquo(prefac, ftilde[j]);
2355 used_flag[j] = true;
2356 D[i] = D[i] * pow(vnlst.op(j+1), count);
2359 C[i] = D[i] * prefac;
2363 for ( int i=0; i<factor_count; ++i ) {
2364 numeric prefac = ex_to<numeric>(ufaclst.op(i+1).lcoeff(x));
2365 for ( int j=ftilde.size()-1; j>=0; --j ) {
2367 while ( irem(prefac, ftilde[j]) == 0 ) {
2368 prefac = iquo(prefac, ftilde[j]);
2371 while ( irem(ex_to<numeric>(delta)*prefac, ftilde[j]) == 0 ) {
2372 numeric g = gcd(prefac, ex_to<numeric>(ftilde[j]));
2373 prefac = iquo(prefac, g);
2374 delta = delta / (ftilde[j]/g);
2375 ufaclst.let_op(i+1) = ufaclst.op(i+1) * (ftilde[j]/g);
2379 used_flag[j] = true;
2380 D[i] = D[i] * pow(vnlst.op(j+1), count);
2383 C[i] = D[i] * prefac;
2386 // check if something went wrong
2387 bool some_factor_unused = false;
2388 for ( size_t i=0; i<used_flag.size(); ++i ) {
2389 if ( !used_flag[i] ) {
2390 some_factor_unused = true;
2394 if ( some_factor_unused ) {
2399 // multiply the remaining content of the univariate polynomial into the
2402 C[0] = C[0] * delta;
2403 ufaclst.let_op(1) = ufaclst.op(1) * delta;
2406 // set up evaluation points
2408 vector<EvalPoint> epv;
2411 for ( size_t i=0; i<a.size(); ++i ) {
2413 ep.evalpoint = a[i].to_int();
2419 for ( int i=1; i<=factor_count; ++i ) {
2420 if ( ufaclst.op(i).degree(x) > maxdeg ) {
2421 maxdeg = ufaclst[i].degree(x);
2424 cl_I B = 2*calc_bound(u, x, maxdeg);
2432 // set up modular factors (mod p^l)
2433 cl_modint_ring R = find_modint_ring(expt_pos(cl_I(prime),l));
2434 upvec modfactors(ufaclst.nops()-1);
2435 for ( size_t i=1; i<ufaclst.nops(); ++i ) {
2436 umodpoly_from_ex(modfactors[i-1], ufaclst.op(i), x, R);
2439 // try Hensel lifting
2440 ex res = hensel_multivar(pp, x, epv, prime, l, modfactors, C);
2441 if ( res != lst() ) {
2442 ex result = cont * unit;
2443 for ( size_t i=0; i<res.nops(); ++i ) {
2444 result *= res.op(i).content(x) * res.op(i).unit(x);
2445 result *= res.op(i).primpart(x);
2452 /** Finds all symbols in an expression. Used by factor_sqrfree() and factor().
2454 struct find_symbols_map : public map_function {
2456 ex operator()(const ex& e)
2458 if ( is_a<symbol>(e) ) {
2462 return e.map(*this);
2466 /** Factorizes a polynomial that is square free. It calls either the univariate
2467 * or the multivariate factorization functions.
2469 static ex factor_sqrfree(const ex& poly)
2471 // determine all symbols in poly
2472 find_symbols_map findsymbols;
2474 if ( findsymbols.syms.size() == 0 ) {
2478 if ( findsymbols.syms.size() == 1 ) {
2480 const ex& x = *(findsymbols.syms.begin());
2481 if ( poly.ldegree(x) > 0 ) {
2482 // pull out direct factors
2483 int ld = poly.ldegree(x);
2484 ex res = factor_univariate(expand(poly/pow(x, ld)), x);
2485 return res * pow(x,ld);
2488 ex res = factor_univariate(poly, x);
2493 // multivariate case
2494 ex res = factor_multivariate(poly, findsymbols.syms);
2498 /** Map used by factor() when factor_options::all is given to access all
2499 * subexpressions and to call factor() on them.
2501 struct apply_factor_map : public map_function {
2503 apply_factor_map(unsigned options_) : options(options_) { }
2504 ex operator()(const ex& e)
2506 if ( e.info(info_flags::polynomial) ) {
2507 return factor(e, options);
2509 if ( is_a<add>(e) ) {
2511 for ( size_t i=0; i<e.nops(); ++i ) {
2512 if ( e.op(i).info(info_flags::polynomial) ) {
2521 return factor(s1, options) + s2.map(*this);
2523 return e.map(*this);
2527 } // anonymous namespace
2529 /** Interface function to the outside world. It checks the arguments, tries a
2530 * square free factorization, and then calls factor_sqrfree to do the hard
2533 ex factor(const ex& poly, unsigned options)
2536 if ( !poly.info(info_flags::polynomial) ) {
2537 if ( options & factor_options::all ) {
2538 options &= ~factor_options::all;
2539 apply_factor_map factor_map(options);
2540 return factor_map(poly);
2545 // determine all symbols in poly
2546 find_symbols_map findsymbols;
2548 if ( findsymbols.syms.size() == 0 ) {
2552 for (auto & i : findsymbols.syms ) {
2556 // make poly square free
2557 ex sfpoly = sqrfree(poly.expand(), syms);
2559 // factorize the square free components
2560 if ( is_a<power>(sfpoly) ) {
2561 // case: (polynomial)^exponent
2562 const ex& base = sfpoly.op(0);
2563 if ( !is_a<add>(base) ) {
2564 // simple case: (monomial)^exponent
2567 ex f = factor_sqrfree(base);
2568 return pow(f, sfpoly.op(1));
2570 if ( is_a<mul>(sfpoly) ) {
2571 // case: multiple factors
2573 for ( size_t i=0; i<sfpoly.nops(); ++i ) {
2574 const ex& t = sfpoly.op(i);
2575 if ( is_a<power>(t) ) {
2576 const ex& base = t.op(0);
2577 if ( !is_a<add>(base) ) {
2581 ex f = factor_sqrfree(base);
2582 res *= pow(f, t.op(1));
2585 else if ( is_a<add>(t) ) {
2586 ex f = factor_sqrfree(t);
2595 if ( is_a<symbol>(sfpoly) ) {
2598 // case: (polynomial)
2599 ex f = factor_sqrfree(sfpoly);
2603 } // namespace GiNaC