1 /** @file exam_factor.cpp
3 * Factorization test suite. */
6 * GiNaC Copyright (C) 1999-2020 Johannes Gutenberg University Mainz, Germany
8 * This program is free software; you can redistribute it and/or modify
9 * it under the terms of the GNU General Public License as published by
10 * the Free Software Foundation; either version 2 of the License, or
11 * (at your option) any later version.
13 * This program is distributed in the hope that it will be useful,
14 * but WITHOUT ANY WARRANTY; without even the implied warranty of
15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16 * GNU General Public License for more details.
18 * You should have received a copy of the GNU General Public License
19 * along with this program; if not, write to the Free Software
20 * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
24 using namespace GiNaC;
29 static unsigned check_factor(const ex& e)
32 ex answer = factor(ee);
33 if ( answer.expand() != ee || answer != e ) {
34 clog << "factorization of " << e << " == " << ee << " gave wrong result: " << answer << endl;
40 static unsigned exam_factor1()
47 e = ex("1+x-x^3", syms);
48 result += check_factor(e);
50 e = ex("1+x^6+x", syms);
51 result += check_factor(e);
53 e = ex("1-x^6+x", syms);
54 result += check_factor(e);
56 e = ex("(1+x)^3", syms);
57 result += check_factor(e);
59 e = ex("(x+1)*(x+4)", syms);
60 result += check_factor(e);
62 e = ex("x^6-3*x^5+x^4-3*x^3-x^2-3*x+1", syms);
63 result += check_factor(e);
65 e = ex("(-1+x)^3*(1+x)^3*(1+x^2)", syms);
66 result += check_factor(e);
68 e = ex("-(-168+20*x-x^2)*(30+x)", syms);
69 result += check_factor(e);
71 e = ex("x^2*(x-3)^2*(x^3-5*x+7)", syms);
72 result += check_factor(e);
74 e = ex("-6*x^2*(x-3)", syms);
75 result += check_factor(e);
77 e = ex("x^16+11*x^4+121", syms);
78 result += check_factor(e);
80 e = ex("x^8-40*x^6+352*x^4-960*x^2+576", syms);
81 result += check_factor(e);
83 e = ex("x*(2+x^2)*(1+x+x^3+x^2+x^6+x^5+x^4)*(1+x)^2*(1-x+x^2)^2*(-1+x)", syms);
84 result += check_factor(e);
86 e = ex("(x+4+x^2-x^3+43*x^4)*(x+1-x^2-3*x^3+4*x^4)", syms);
87 result += check_factor(e);
89 e = ex("-x^2*(x-1)*(1+x^2)", syms);
90 result += check_factor(e);
93 result += check_factor(e);
96 e = ex("(1+x)*(1+x^2-x^29-x^11-x^25-x^9-x^35+x^20-x^3+x^16-x^15-x-x^13+x^28+x^24-x^33+x^8-x^19+x^36+x^12-x^27+x^10-x^23+x^18+x^14+x^34-x^31+x^32+x^30-x^5+x^26+x^4+x^22-x^21-x^7-x^17+x^6)", syms);
97 result += check_factor(e);
99 e = ex("(1+4*x)*x^2*(1-4*x+16*x^2)*(3+5*x+92*x^3)", syms);
100 result += check_factor(e);
102 e = ex("(77+11*x^3+25*x^2+27*x+102*x^4)*(85+57*x^3+92*x^2+29*x+66*x^4)", syms);
103 result += check_factor(e);
108 static unsigned exam_factor2()
112 symbol x("x"), y("y"), z("z");
113 lst syms = {x, y, z};
116 result += check_factor(e);
118 e = ex("(x^2-y+1)*(x+y)", syms);
119 result += check_factor(e);
121 e = ex("-2*(x+y)*(x-y)", syms);
122 result += check_factor(e);
124 e = ex("(16+x^2*z^3)*(-17+3*x-5*z)*(2*x+3*z)*(x-y^2-z^3)", syms);
125 result += check_factor(e);
127 e = ex("(x-y*z)*(x-y^2-z^3)*(x+y+z)", syms);
128 result += check_factor(e);
130 e = ex("-(y^2-x+z^3)*x*(x+y+z)", syms);
131 result += check_factor(e);
133 e = ex("-316*(3*x-4*z)*(2*x+3*z)*(x+y)*(-1+x)", syms);
134 result += check_factor(e);
136 e = ex("(x+x^3+z^2)*(3*x-4*z)", syms);
137 result += check_factor(e);
139 e = ex("250*(-3+x)*(4*z-3*x)*(x^3+z^2+x)*x", syms);
140 result += check_factor(e);
142 e = ex("327*(x+z^2+x^3)*(3*x-4*z)*(-7+5*x-x^3)*(1+x+x^2)", syms);
143 result += check_factor(e);
145 e = ex("x-y^2-z^3", syms);
146 result += check_factor(e);
148 e = ex("-390*(7+3*x^4)*(2+x^2)*(x-z^3-y^2)", syms);
149 result += check_factor(e);
151 e = ex("55*(1+x)^2*(3*x-4*z)*(1+x+x^2)*(x+x^3+z^2)", syms);
152 result += check_factor(e);
154 e = ex("x+y*x-1", syms);
155 result += check_factor(e);
157 e = ex("390*(-1+x^6-x)*(7+3*x^4)*(2+x^2)*(y+x)*(-1+y-x^2)*(1+x^2+x)^2", syms);
158 result += check_factor(e);
160 e = ex("310*(y+x)*(-1+y-x^2)", syms);
161 result += check_factor(e);
166 static unsigned exam_factor3()
170 symbol k("k"), n("n");
173 e = ex("1/2*(-3+3*k-n)*(-2+3*k-n)*(-1+3*k-n)", syms);
174 result += check_factor(e);
176 e = ex("1/4*(2*k-n)*(-1+2*k-n)", syms);
177 result += check_factor(e);
182 static unsigned check_factor_expanded(const ex& e)
185 ex answer = factor(ee);
186 if ( answer.expand() != ee || (!is_a<mul>(answer) && !is_a<power>(answer)) ) {
187 clog << "factorization of " << e << " == " << ee << " gave wrong result: " << answer << endl;
193 static unsigned exam_factor_wang()
195 // these 15 polynomials are from the appendix of P.S.Wang,
196 // "An Improved Multivariate Polynomial Factoring Algorithm"
199 symbol u("u"), w("w"), x("x"), y("y"), z("z");
201 e = ex("(z+x*y+10)*(x*z+y+30)*(y*z+x+20)", lst{x, y, z});
202 result += check_factor_expanded(e);
204 e = ex("(x^3*(z+y)+y-11)*(x^2*(z^2+y^2)+y+90)", lst{x, y, z});
205 result += check_factor_expanded(e);
207 e = ex("(y*z^3+x*y*z+y^2+x^3)*(x*(z^4+1)+z+x^3*y^2)", lst{x, y, z});
208 result += check_factor_expanded(e);
210 e = ex("(z^2-x^3*y+3)*(z^2+x*y^3)*(z^2+x^3*y^4)*(y^4*z^2+x^2*z+5)", lst{x, y, z});
211 result += check_factor_expanded(e);
213 e = ex("(z^2+x^3*y^4+u^2)*((y^2+x)*z^2+3*u^2*x^3*y^4*z+19*y^2)*(u^2*y^4*z^2+x^2*z+5)", lst{u, x, y, z});
214 result += check_factor_expanded(e);
216 e = ex("(w^4*z^3-x*y^2*z^2-w^4*x^5*y^6-w^2*x^3*y)*(-x^5*z^3+y*z+x^2*y^3)"
217 "*(w^4*z^6+y^2*z^3-w^2*x^2*y^2*z^2+x^5*z-x^4*y^2-w^3*x^3*y)", lst{w, x, y, z});
218 result += check_factor_expanded(e);
220 e = ex("(z+y+x-3)^3*(z+y+x-2)^2", lst{x, y, z});
221 result += check_factor_expanded(e);
223 e = ex("(-15*y^2*z^16+29*w^4*x^12*y^12*z^3+21*x^3*z^2+3*w^15*y^20)"
224 "*(-z^31-w^12*z^20+y^18-y^14+x^2*y^2+x^21+w^2)", lst{w, x, y, z});
225 result += check_factor_expanded(e);
227 e = ex("u^4*x*z^2*(6*w^2*y^3*z^2+18*u^2*w^3*x*z^2+15*u*z^2+10*u^2*w*x*y^3)"
228 "*(-44*u*w*x*y^4*z^4-25*u^2*w^3*y*z^4+8*u*w*x^3*z^4-32*u^2*w^4*y^4*z^3"
229 "+48*u^2*x^2*y^3*z^3-12*y^3*z^2+2*u^2*w*x^2*y^2-11*u*w^2*x^3*y-4*w^2*x)", lst{u, w, x, y, z});
230 result += check_factor_expanded(e);
232 e = ex("(31*u^2*x*z+35*w^2*y^2+6*x*y+40*w*x^2)*(u^2*w^2*x*y^2*z^2+24*u^2*w*x*y^2*z^2"
233 "+12*u^2*x*y^2*z^2+24*u^2*x^2*y*z^2+43*w*x*y*z^2+31*w^2*y*z^2+8*u^2*w^2*z^2"
234 "+44*u*w^2*z^2+37*u^2*y^2*z+41*y^2*z+12*w*x^2*y*z+21*u^2*w*x*y*z+23*x*y*z"
235 "+47*u^2*w^2*z+13*u*w^2*x^2*y^2+22*x*y^2+42*u^2*w^2*y^2+29*w^2*y^2+27*u*w^2*x^2*y"
236 "+37*w^2*x*z+39*u*w*x*z+43*u*x^2*y+24*x*y+9*u^2*w*x^2+22*u^2*w^2)", lst{u, w, x, y, z});
237 result += check_factor_expanded(e);
239 e = ex("x*y*(-13*u^3*w^2*x*y*z^3+w^3*z^3+4*u*x*y^2+47*x*y)"
240 "*(43*u*x^3*y^3*z^3+36*u^2*w^3*x*y*z^3+14*w^3*x^3*y^3*z^2-29*w^3*x*y^3*z^2"
241 "-20*u^2*w^2*x^2*y^2*z^2+36*u^2*w*x*y^3*z-48*u*x^3*y^2*z+5*u*w*x^2*y^3"
242 "+36*u*w^2*y^3-9*u*w*y^3-23*u*w*x^3*y^2+46*u*x^3*y^2+8*x*y^2+31*u^2*w^3*y^2"
243 "-9*u^2*y^2+45*x^3-46*u^2*w*x)", lst{u, w, x, y, z});
244 result += check_factor_expanded(e);
246 e = ex("(z+y+x-3)^3", lst{x, y, z});
247 result += check_factor_expanded(e);
249 e = ex("(3*z^3+2*w*z-9*y^3-y^2+45*x^3)*(w^2*z^3+47*x*y-w^2)", lst{w, x, y, z});
250 result += check_factor_expanded(e);
252 e = ex("(-18*x^4*y^5+22*y^5-26*x^3*y^4-38*x^2*y^4+29*x^2*y^3-41*x^4*y^2+37*x^4)"
253 "*(33*x^5*y^6+11*y^2+35*x^3*y-22*x^4)", lst{x, y, z});
254 result += check_factor_expanded(e);
256 e = ex("x^6*y^3*z^2*(3*z^3+2*w*z-8*x*y^2+14*w^2*y^2-y^2+18*x^3*y)"
257 "*(-12*w^2*x*y*z^3+w^2*z^3+3*x*y^2+29*x-w^2)", lst{w, x, y, z});
258 result += check_factor_expanded(e);
263 static unsigned check_factorization(const exvector& factors)
265 ex e = dynallocate<mul>(factors);
266 ex ef = factor(e.expand());
267 if (ef.nops() != factors.size()) {
268 clog << "wrong number of factors, expected " << factors.size() <<
269 ", got " << ef.nops();
272 for (size_t i = 0; i < ef.nops(); ++i) {
273 if (find(factors.begin(), factors.end(), ef.op(i)) == factors.end()) {
274 clog << "wrong factorization: term not found: " << ef.op(i);
281 static unsigned factor_integer_content_bug()
285 factors.push_back(reader("x+y+x*y"));
286 factors.push_back(reader("3*x+2*y"));
287 return check_factorization(factors);
290 unsigned exam_factor()
294 cout << "examining polynomial factorization" << flush;
296 result += exam_factor1(); cout << '.' << flush;
297 result += exam_factor2(); cout << '.' << flush;
298 result += exam_factor3(); cout << '.' << flush;
299 result += exam_factor_wang(); cout << '.' << flush;
300 result += factor_integer_content_bug();
301 cout << '.' << flush;
306 int main(int argc, char** argv)
308 return exam_factor();