From: Alexei Sheplyakov <varg@theor.jinr.ru>
Date: Wed, 19 Mar 2008 09:28:10 +0000 (+0300)
Subject: Implicit conversion from cl_N to numeric considered harmful.
X-Git-Tag: release_1-5-0~90
X-Git-Url: https://www.ginac.de/ginac.git//ginac.git?a=commitdiff_plain;h=2d52c00438cde2c47f43620d26d78022f0d60746;p=ginac.git

Implicit conversion from cl_N to numeric considered harmful.

Finally, mark the numeric(const cl_N&) ctor as explicit.
This allows one to mix the code using GiNaC and CLN, i.e.

cl_N x, y;
// initialize them
cl_N z = sin(x) +  y*exp(y);
symbol a("a");
ex e = exp(a);
---

diff --git a/ginac/numeric.h b/ginac/numeric.h
index c0f9a8b6..bf5c7013 100644
--- a/ginac/numeric.h
+++ b/ginac/numeric.h
@@ -184,7 +184,7 @@ public:
 	const numeric denom() const;
 	int int_length() const;
 	// converting routines for interfacing with CLN:
-	numeric(const cln::cl_N &z);
+	explicit numeric(const cln::cl_N &z);
 
 protected:
 	void print_numeric(const print_context & c, const char *par_open, const char *par_close, const char *imag_sym, const char *mul_sym, unsigned level) const;