*
* @see get_symbol_stats */
struct sym_desc {
+ /** Initialize symbol, leave other variables uninitialized */
+ sym_desc(const ex& s)
+ : sym(s), deg_a(0), deg_b(0), ldeg_a(0), ldeg_b(0), max_deg(0), max_lcnops(0)
+ { }
+
/** Reference to symbol */
ex sym;
// Add symbol the sym_desc_vec (used internally by get_symbol_stats())
static void add_symbol(const ex &s, sym_desc_vec &v)
{
- sym_desc_vec::const_iterator it = v.begin(), itend = v.end();
- while (it != itend) {
- if (it->sym.is_equal(s)) // If it's already in there, don't add it a second time
+ for (auto & it : v)
+ if (it.sym.is_equal(s)) // If it's already in there, don't add it a second time
return;
- ++it;
- }
- sym_desc d;
- d.sym = s;
- v.push_back(d);
+
+ v.push_back(sym_desc(s));
}
// Collect all symbols of an expression (used internally by get_symbol_stats())
{
collect_symbols(a.eval(), v); // eval() to expand assigned symbols
collect_symbols(b.eval(), v);
- sym_desc_vec::iterator it = v.begin(), itend = v.end();
- while (it != itend) {
- int deg_a = a.degree(it->sym);
- int deg_b = b.degree(it->sym);
- it->deg_a = deg_a;
- it->deg_b = deg_b;
- it->max_deg = std::max(deg_a, deg_b);
- it->max_lcnops = std::max(a.lcoeff(it->sym).nops(), b.lcoeff(it->sym).nops());
- it->ldeg_a = a.ldegree(it->sym);
- it->ldeg_b = b.ldegree(it->sym);
- ++it;
+ for (auto & it : v) {
+ int deg_a = a.degree(it.sym);
+ int deg_b = b.degree(it.sym);
+ it.deg_a = deg_a;
+ it.deg_b = deg_b;
+ it.max_deg = std::max(deg_a, deg_b);
+ it.max_lcnops = std::max(a.lcoeff(it.sym).nops(), b.lcoeff(it.sym).nops());
+ it.ldeg_a = a.ldegree(it.sym);
+ it.ldeg_b = b.ldegree(it.sym);
}
std::sort(v.begin(), v.end());
lcm_accum *= op_lcm;
}
v.push_back(lcm / lcm_accum);
- return (new mul(v))->setflag(status_flags::dynallocated);
+ return dynallocate<mul>(v);
} else if (is_exactly_a<add>(e)) {
size_t num = e.nops();
exvector v; v.reserve(num);
for (size_t i=0; i<num; i++)
v.push_back(multiply_lcm(e.op(i), lcm));
- return (new add(v))->setflag(status_flags::dynallocated);
+ return dynallocate<add>(v);
} else if (is_exactly_a<power>(e)) {
if (is_a<symbol>(e.op(0)))
return e * lcm;
numeric add::integer_content() const
{
- epvector::const_iterator it = seq.begin();
- epvector::const_iterator itend = seq.end();
numeric c = *_num0_p, l = *_num1_p;
- while (it != itend) {
- GINAC_ASSERT(!is_exactly_a<numeric>(it->rest));
- GINAC_ASSERT(is_exactly_a<numeric>(it->coeff));
- c = gcd(ex_to<numeric>(it->coeff).numer(), c);
- l = lcm(ex_to<numeric>(it->coeff).denom(), l);
- it++;
+ for (auto & it : seq) {
+ GINAC_ASSERT(!is_exactly_a<numeric>(it.rest));
+ GINAC_ASSERT(is_exactly_a<numeric>(it.coeff));
+ c = gcd(ex_to<numeric>(it.coeff).numer(), c);
+ l = lcm(ex_to<numeric>(it.coeff).denom(), l);
}
GINAC_ASSERT(is_exactly_a<numeric>(overall_coeff));
c = gcd(ex_to<numeric>(overall_coeff).numer(), c);
numeric mul::integer_content() const
{
#ifdef DO_GINAC_ASSERT
- epvector::const_iterator it = seq.begin();
- epvector::const_iterator itend = seq.end();
- while (it != itend) {
- GINAC_ASSERT(!is_exactly_a<numeric>(recombine_pair_to_ex(*it)));
- ++it;
+ for (auto & it : seq) {
+ GINAC_ASSERT(!is_exactly_a<numeric>(recombine_pair_to_ex(it)));
}
#endif // def DO_GINAC_ASSERT
GINAC_ASSERT(is_exactly_a<numeric>(overall_coeff));
term = rcoeff / blcoeff;
else {
if (!divide(rcoeff, blcoeff, term, false))
- return (new fail())->setflag(status_flags::dynallocated);
+ return dynallocate<fail>();
}
term *= power(x, rdeg - bdeg);
v.push_back(term);
break;
rdeg = r.degree(x);
}
- return (new add(v))->setflag(status_flags::dynallocated);
+ return dynallocate<add>(v);
}
term = rcoeff / blcoeff;
else {
if (!divide(rcoeff, blcoeff, term, false))
- return (new fail())->setflag(status_flags::dynallocated);
+ return dynallocate<fail>();
}
term *= power(x, rdeg - bdeg);
r -= (term * b).expand();
else
resv.push_back(a.op(j));
}
- q = (new mul(resv))->setflag(status_flags::dynallocated);
+ q = dynallocate<mul>(resv);
return true;
}
} else if (is_exactly_a<power>(a)) {
v.push_back(term);
r -= (term * b).expand();
if (r.is_zero()) {
- q = (new add(v))->setflag(status_flags::dynallocated);
+ q = dynallocate<add>(v);
return true;
}
rdeg = r.degree(x);
if (is_exactly_a<mul>(b)) {
ex qbar = a;
- for (const_iterator itrb = b.begin(); itrb != b.end(); ++itrb) {
+ for (const auto & it : b) {
sym_desc_vec sym_stats;
- get_symbol_stats(a, *itrb, sym_stats);
- if (!divide_in_z(qbar, *itrb, q, sym_stats.begin()))
+ get_symbol_stats(a, it, sym_stats);
+ if (!divide_in_z(qbar, it, q, sym_stats.begin()))
return false;
qbar = q;
v.push_back(term);
r -= (term * eb).expand();
if (r.is_zero()) {
- q = (new add(v))->setflag(status_flags::dynallocated);
+ q = dynallocate<add>(v);
#if USE_REMEMBER
dr_remember[ex2(a, b)] = exbool(q, true);
#endif
numeric add::max_coefficient() const
{
- epvector::const_iterator it = seq.begin();
- epvector::const_iterator itend = seq.end();
GINAC_ASSERT(is_exactly_a<numeric>(overall_coeff));
numeric cur_max = abs(ex_to<numeric>(overall_coeff));
- while (it != itend) {
+ for (auto & it : seq) {
numeric a;
- GINAC_ASSERT(!is_exactly_a<numeric>(it->rest));
- a = abs(ex_to<numeric>(it->coeff));
+ GINAC_ASSERT(!is_exactly_a<numeric>(it.rest));
+ a = abs(ex_to<numeric>(it.coeff));
if (a > cur_max)
cur_max = a;
- it++;
}
return cur_max;
}
numeric mul::max_coefficient() const
{
#ifdef DO_GINAC_ASSERT
- epvector::const_iterator it = seq.begin();
- epvector::const_iterator itend = seq.end();
- while (it != itend) {
- GINAC_ASSERT(!is_exactly_a<numeric>(recombine_pair_to_ex(*it)));
- it++;
+ for (auto & it : seq) {
+ GINAC_ASSERT(!is_exactly_a<numeric>(recombine_pair_to_ex(it)));
}
#endif // def DO_GINAC_ASSERT
GINAC_ASSERT(is_exactly_a<numeric>(overall_coeff));
{
epvector newseq;
newseq.reserve(seq.size()+1);
- epvector::const_iterator it = seq.begin();
- epvector::const_iterator itend = seq.end();
- while (it != itend) {
- GINAC_ASSERT(!is_exactly_a<numeric>(it->rest));
- numeric coeff = GiNaC::smod(ex_to<numeric>(it->coeff), xi);
+ for (auto & it : seq) {
+ GINAC_ASSERT(!is_exactly_a<numeric>(it.rest));
+ numeric coeff = GiNaC::smod(ex_to<numeric>(it.coeff), xi);
if (!coeff.is_zero())
- newseq.push_back(expair(it->rest, coeff));
- it++;
+ newseq.push_back(expair(it.rest, coeff));
}
GINAC_ASSERT(is_exactly_a<numeric>(overall_coeff));
numeric coeff = GiNaC::smod(ex_to<numeric>(overall_coeff), xi);
- return (new add(newseq,coeff))->setflag(status_flags::dynallocated);
+ return dynallocate<add>(std::move(newseq), coeff);
}
ex mul::smod(const numeric &xi) const
{
#ifdef DO_GINAC_ASSERT
- epvector::const_iterator it = seq.begin();
- epvector::const_iterator itend = seq.end();
- while (it != itend) {
- GINAC_ASSERT(!is_exactly_a<numeric>(recombine_pair_to_ex(*it)));
- it++;
+ for (auto & it : seq) {
+ GINAC_ASSERT(!is_exactly_a<numeric>(recombine_pair_to_ex(it)));
}
#endif // def DO_GINAC_ASSERT
- mul * mulcopyp = new mul(*this);
+ mul & mulcopy = dynallocate<mul>(*this);
GINAC_ASSERT(is_exactly_a<numeric>(overall_coeff));
- mulcopyp->overall_coeff = GiNaC::smod(ex_to<numeric>(overall_coeff),xi);
- mulcopyp->clearflag(status_flags::evaluated);
- mulcopyp->clearflag(status_flags::hash_calculated);
- return mulcopyp->setflag(status_flags::dynallocated);
+ mulcopy.overall_coeff = GiNaC::smod(ex_to<numeric>(overall_coeff),xi);
+ mulcopy.clearflag(status_flags::evaluated);
+ mulcopy.clearflag(status_flags::hash_calculated);
+ return mulcopy;
}
g.push_back(gi * power(x, i));
e = (e - gi) * rxi;
}
- return (new add(g))->setflag(status_flags::dynallocated);
+ return dynallocate<add>(g);
}
/** Exception thrown by heur_gcd() to signal failure. */
part_b = part_cb;
}
if (ca)
- *ca = (new mul(acc_ca))->setflag(status_flags::dynallocated);
+ *ca = dynallocate<mul>(acc_ca);
if (cb)
*cb = part_b;
- return (new mul(g))->setflag(status_flags::dynallocated);
+ return dynallocate<mul>(g);
}
/** Compute LCM (Least Common Multiple) of multivariate polynomials in Z[X].
if (l.nops()==0) {
sym_desc_vec sdv;
get_symbol_stats(a, _ex0, sdv);
- sym_desc_vec::const_iterator it = sdv.begin(), itend = sdv.end();
- while (it != itend) {
- args.append(it->sym);
- ++it;
- }
+ for (auto & it : sdv)
+ args.append(it.sym);
} else {
args = l;
}
// recurse down the factors in remaining variables
if (newargs.nops()>0) {
- exvector::iterator i = factors.begin();
- while (i != factors.end()) {
- *i = sqrfree(*i, newargs);
- ++i;
- }
+ for (auto & it : factors)
+ it = sqrfree(it, newargs);
}
// Done with recursion, now construct the final result
ex result = _ex1;
- exvector::const_iterator it = factors.begin(), itend = factors.end();
- for (int p = 1; it!=itend; ++it, ++p)
- result *= power(*it, p);
+ int p = 1;
+ for (auto & it : factors)
+ result *= power(it, p++);
// Yun's algorithm does not account for constant factors. (For univariate
// polynomials it works only in the monic case.) We can correct this by
ex e_replaced = e.subs(repl, subs_options::no_pattern);
// Expression already replaced? Then return the assigned symbol
- exmap::const_iterator it = rev_lookup.find(e_replaced);
+ auto it = rev_lookup.find(e_replaced);
if (it != rev_lookup.end())
return it->second;
// Otherwise create new symbol and add to list, taking care that the
// replacement expression doesn't itself contain symbols from repl,
// because subs() is not recursive
- ex es = (new symbol)->setflag(status_flags::dynallocated);
+ ex es = dynallocate<symbol>();
repl.insert(std::make_pair(es, e_replaced));
rev_lookup.insert(std::make_pair(e_replaced, es));
return es;
ex e_replaced = e.subs(repl, subs_options::no_pattern);
// Expression already replaced? Then return the assigned symbol
- for (exmap::const_iterator it = repl.begin(); it != repl.end(); ++it)
- if (it->second.is_equal(e_replaced))
- return it->first;
+ for (auto & it : repl)
+ if (it.second.is_equal(e_replaced))
+ return it.first;
// Otherwise create new symbol and add to list, taking care that the
// replacement expression doesn't itself contain symbols from repl,
// because subs() is not recursive
- ex es = (new symbol)->setflag(status_flags::dynallocated);
+ ex es = dynallocate<symbol>();
repl.insert(std::make_pair(es, e_replaced));
return es;
}
struct normal_map_function : public map_function {
int level;
normal_map_function(int l) : level(l) {}
- ex operator()(const ex & e) { return normal(e, level); }
+ ex operator()(const ex & e) override { return normal(e, level); }
};
/** Default implementation of ex::normal(). It normalizes the children and
ex basic::normal(exmap & repl, exmap & rev_lookup, int level) const
{
if (nops() == 0)
- return (new lst(replace_with_symbol(*this, repl, rev_lookup), _ex1))->setflag(status_flags::dynallocated);
+ return dynallocate<lst>({replace_with_symbol(*this, repl, rev_lookup), _ex1});
else {
if (level == 1)
- return (new lst(replace_with_symbol(*this, repl, rev_lookup), _ex1))->setflag(status_flags::dynallocated);
+ return dynallocate<lst>({replace_with_symbol(*this, repl, rev_lookup), _ex1});
else if (level == -max_recursion_level)
throw(std::runtime_error("max recursion level reached"));
else {
normal_map_function map_normal(level - 1);
- return (new lst(replace_with_symbol(map(map_normal), repl, rev_lookup), _ex1))->setflag(status_flags::dynallocated);
+ return dynallocate<lst>({replace_with_symbol(map(map_normal), repl, rev_lookup), _ex1});
}
}
}
* @see ex::normal */
ex symbol::normal(exmap & repl, exmap & rev_lookup, int level) const
{
- return (new lst(*this, _ex1))->setflag(status_flags::dynallocated);
+ return dynallocate<lst>({*this, _ex1});
}
}
// Denominator is always a real integer (see numeric::denom())
- return (new lst(numex, denom()))->setflag(status_flags::dynallocated);
+ return dynallocate<lst>({numex, denom()});
}
// Handle trivial case where denominator is 1
if (den.is_equal(_ex1))
- return (new lst(num, den))->setflag(status_flags::dynallocated);
+ return dynallocate<lst>({num, den});
// Handle special cases where numerator or denominator is 0
if (num.is_zero())
- return (new lst(num, _ex1))->setflag(status_flags::dynallocated);
+ return dynallocate<lst>({num, _ex1});
if (den.expand().is_zero())
throw(std::overflow_error("frac_cancel: division by zero in frac_cancel"));
// Return result as list
//std::clog << " returns num = " << num << ", den = " << den << ", pre_factor = " << pre_factor << std::endl;
- return (new lst(num * pre_factor.numer(), den * pre_factor.denom()))->setflag(status_flags::dynallocated);
+ return dynallocate<lst>({num * pre_factor.numer(), den * pre_factor.denom()});
}
ex add::normal(exmap & repl, exmap & rev_lookup, int level) const
{
if (level == 1)
- return (new lst(replace_with_symbol(*this, repl, rev_lookup), _ex1))->setflag(status_flags::dynallocated);
+ return dynallocate<lst>({replace_with_symbol(*this, repl, rev_lookup), _ex1});
else if (level == -max_recursion_level)
throw(std::runtime_error("max recursion level reached"));
exvector nums, dens;
nums.reserve(seq.size()+1);
dens.reserve(seq.size()+1);
- epvector::const_iterator it = seq.begin(), itend = seq.end();
- while (it != itend) {
- ex n = ex_to<basic>(recombine_pair_to_ex(*it)).normal(repl, rev_lookup, level-1);
+ for (auto & it : seq) {
+ ex n = ex_to<basic>(recombine_pair_to_ex(it)).normal(repl, rev_lookup, level-1);
nums.push_back(n.op(0));
dens.push_back(n.op(1));
- it++;
}
ex n = ex_to<numeric>(overall_coeff).normal(repl, rev_lookup, level-1);
nums.push_back(n.op(0));
//std::clog << "add::normal uses " << nums.size() << " summands:\n";
// Add fractions sequentially
- exvector::const_iterator num_it = nums.begin(), num_itend = nums.end();
- exvector::const_iterator den_it = dens.begin(), den_itend = dens.end();
+ auto num_it = nums.begin(), num_itend = nums.end();
+ auto den_it = dens.begin(), den_itend = dens.end();
//std::clog << " num = " << *num_it << ", den = " << *den_it << std::endl;
ex num = *num_it++, den = *den_it++;
while (num_it != num_itend) {
ex mul::normal(exmap & repl, exmap & rev_lookup, int level) const
{
if (level == 1)
- return (new lst(replace_with_symbol(*this, repl, rev_lookup), _ex1))->setflag(status_flags::dynallocated);
+ return dynallocate<lst>({replace_with_symbol(*this, repl, rev_lookup), _ex1});
else if (level == -max_recursion_level)
throw(std::runtime_error("max recursion level reached"));
exvector num; num.reserve(seq.size());
exvector den; den.reserve(seq.size());
ex n;
- epvector::const_iterator it = seq.begin(), itend = seq.end();
- while (it != itend) {
- n = ex_to<basic>(recombine_pair_to_ex(*it)).normal(repl, rev_lookup, level-1);
+ for (auto & it : seq) {
+ n = ex_to<basic>(recombine_pair_to_ex(it)).normal(repl, rev_lookup, level-1);
num.push_back(n.op(0));
den.push_back(n.op(1));
- it++;
}
n = ex_to<numeric>(overall_coeff).normal(repl, rev_lookup, level-1);
num.push_back(n.op(0));
den.push_back(n.op(1));
// Perform fraction cancellation
- return frac_cancel((new mul(num))->setflag(status_flags::dynallocated),
- (new mul(den))->setflag(status_flags::dynallocated));
+ return frac_cancel(dynallocate<mul>(num), dynallocate<mul>(den));
}
ex power::normal(exmap & repl, exmap & rev_lookup, int level) const
{
if (level == 1)
- return (new lst(replace_with_symbol(*this, repl, rev_lookup), _ex1))->setflag(status_flags::dynallocated);
+ return dynallocate<lst>({replace_with_symbol(*this, repl, rev_lookup), _ex1});
else if (level == -max_recursion_level)
throw(std::runtime_error("max recursion level reached"));
if (n_exponent.info(info_flags::positive)) {
// (a/b)^n -> {a^n, b^n}
- return (new lst(power(n_basis.op(0), n_exponent), power(n_basis.op(1), n_exponent)))->setflag(status_flags::dynallocated);
+ return dynallocate<lst>({power(n_basis.op(0), n_exponent), power(n_basis.op(1), n_exponent)});
} else if (n_exponent.info(info_flags::negative)) {
// (a/b)^-n -> {b^n, a^n}
- return (new lst(power(n_basis.op(1), -n_exponent), power(n_basis.op(0), -n_exponent)))->setflag(status_flags::dynallocated);
+ return dynallocate<lst>({power(n_basis.op(1), -n_exponent), power(n_basis.op(0), -n_exponent)});
}
} else {
if (n_exponent.info(info_flags::positive)) {
// (a/b)^x -> {sym((a/b)^x), 1}
- return (new lst(replace_with_symbol(power(n_basis.op(0) / n_basis.op(1), n_exponent), repl, rev_lookup), _ex1))->setflag(status_flags::dynallocated);
+ return dynallocate<lst>({replace_with_symbol(power(n_basis.op(0) / n_basis.op(1), n_exponent), repl, rev_lookup), _ex1});
} else if (n_exponent.info(info_flags::negative)) {
if (n_basis.op(1).is_equal(_ex1)) {
// a^-x -> {1, sym(a^x)}
- return (new lst(_ex1, replace_with_symbol(power(n_basis.op(0), -n_exponent), repl, rev_lookup)))->setflag(status_flags::dynallocated);
+ return dynallocate<lst>({_ex1, replace_with_symbol(power(n_basis.op(0), -n_exponent), repl, rev_lookup)});
} else {
// (a/b)^-x -> {sym((b/a)^x), 1}
- return (new lst(replace_with_symbol(power(n_basis.op(1) / n_basis.op(0), -n_exponent), repl, rev_lookup), _ex1))->setflag(status_flags::dynallocated);
+ return dynallocate<lst>({replace_with_symbol(power(n_basis.op(1) / n_basis.op(0), -n_exponent), repl, rev_lookup), _ex1});
}
}
}
// (a/b)^x -> {sym((a/b)^x, 1}
- return (new lst(replace_with_symbol(power(n_basis.op(0) / n_basis.op(1), n_exponent), repl, rev_lookup), _ex1))->setflag(status_flags::dynallocated);
+ return dynallocate<lst>({replace_with_symbol(power(n_basis.op(0) / n_basis.op(1), n_exponent), repl, rev_lookup), _ex1});
}
ex pseries::normal(exmap & repl, exmap & rev_lookup, int level) const
{
epvector newseq;
- epvector::const_iterator i = seq.begin(), end = seq.end();
- while (i != end) {
- ex restexp = i->rest.normal();
+ for (auto & it : seq) {
+ ex restexp = it.rest.normal();
if (!restexp.is_zero())
- newseq.push_back(expair(restexp, i->coeff));
- ++i;
+ newseq.push_back(expair(restexp, it.coeff));
}
- ex n = pseries(relational(var,point), newseq);
- return (new lst(replace_with_symbol(n, repl, rev_lookup), _ex1))->setflag(status_flags::dynallocated);
+ ex n = pseries(relational(var,point), std::move(newseq));
+ return dynallocate<lst>({replace_with_symbol(n, repl, rev_lookup), _ex1});
}
{
// Convert lst to exmap
exmap m;
- for (lst::const_iterator it = repl_lst.begin(); it != repl_lst.end(); ++it)
- m.insert(std::make_pair(it->op(0), it->op(1)));
+ for (auto & it : repl_lst)
+ m.insert(std::make_pair(it.op(0), it.op(1)));
ex ret = bp->to_rational(m);
// Convert exmap back to lst
repl_lst.remove_all();
- for (exmap::const_iterator it = m.begin(); it != m.end(); ++it)
- repl_lst.append(it->first == it->second);
+ for (auto & it : m)
+ repl_lst.append(it.first == it.second);
return ret;
}
{
// Convert lst to exmap
exmap m;
- for (lst::const_iterator it = repl_lst.begin(); it != repl_lst.end(); ++it)
- m.insert(std::make_pair(it->op(0), it->op(1)));
+ for (auto & it : repl_lst)
+ m.insert(std::make_pair(it.op(0), it.op(1)));
ex ret = bp->to_polynomial(m);
// Convert exmap back to lst
repl_lst.remove_all();
- for (exmap::const_iterator it = m.begin(); it != m.end(); ++it)
- repl_lst.append(it->first == it->second);
+ for (auto & it : m)
+ repl_lst.append(it.first == it.second);
return ret;
}
{
epvector s;
s.reserve(seq.size());
- epvector::const_iterator i = seq.begin(), end = seq.end();
- while (i != end) {
- s.push_back(split_ex_to_pair(recombine_pair_to_ex(*i).to_rational(repl)));
- ++i;
- }
+ for (auto & it : seq)
+ s.push_back(split_ex_to_pair(recombine_pair_to_ex(it).to_rational(repl)));
+
ex oc = overall_coeff.to_rational(repl);
if (oc.info(info_flags::numeric))
return thisexpairseq(std::move(s), overall_coeff);
{
epvector s;
s.reserve(seq.size());
- epvector::const_iterator i = seq.begin(), end = seq.end();
- while (i != end) {
- s.push_back(split_ex_to_pair(recombine_pair_to_ex(*i).to_polynomial(repl)));
- ++i;
- }
+ for (auto & it : seq)
+ s.push_back(split_ex_to_pair(recombine_pair_to_ex(it).to_polynomial(repl)));
+
ex oc = overall_coeff.to_polynomial(repl);
if (oc.info(info_flags::numeric))
return thisexpairseq(std::move(s), overall_coeff);
else
v.push_back(t.op(k));
}
- t = (new mul(v))->setflag(status_flags::dynallocated);
+ t = dynallocate<mul>(v);
goto term_done;
}
}
t = x;
term_done: ;
}
- return (new add(terms))->setflag(status_flags::dynallocated);
+ return dynallocate<add>(terms);
} else if (is_exactly_a<mul>(e)) {
for (size_t i=0; i<num; i++)
v.push_back(find_common_factor(e.op(i), factor, repl));
- return (new mul(v))->setflag(status_flags::dynallocated);
+ return dynallocate<mul>(v);
} else if (is_exactly_a<power>(e)) {
const ex e_exp(e.op(1));